From patchwork Sun Dec 7 12:26:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: George Spelvin X-Patchwork-Id: 5451601 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 93086BEEBA for ; Sun, 7 Dec 2014 12:27:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D88F020158 for ; Sun, 7 Dec 2014 12:27:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E03720155 for ; Sun, 7 Dec 2014 12:27:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753173AbaLGM1P (ORCPT ); Sun, 7 Dec 2014 07:27:15 -0500 Received: from ns.horizon.com ([71.41.210.147]:17519 "HELO ns.horizon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753219AbaLGM1H (ORCPT ); Sun, 7 Dec 2014 07:27:07 -0500 Received: (qmail 20855 invoked by uid 1000); 7 Dec 2014 07:26:54 -0500 From: George Spelvin To: nhorman@tuxdriver.com, linux-crypto@vger.kernel.org Cc: smueller@chronox.de, herbert@gondor.apana.org.au, linux@horizon.com Subject: [PATCH v2 16/25] crypto: testmgr - Report failure on zero-length crypto_rng_get_bytes Date: Sun, 7 Dec 2014 07:26:24 -0500 Message-Id: <62e1366f793c73930bc8cccda73ab9b47cd6756e.1417951990.git.linux@horizon.com> X-Mailer: git-send-email 2.1.3 In-Reply-To: References: In-Reply-To: References: Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If crypto_rng_get_bytes returns an error code, returning it is a good idea, but if it simply returns zero, the test shouldn't abort successfully. Signed-off-by: George Spelvin --- crypto/testmgr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index 0e179c72..9faf265f 100644 --- a/crypto/testmgr.c +++ b/crypto/testmgr.c @@ -1476,6 +1476,8 @@ static int test_cprng(struct crypto_rng *tfm, "the correct amount of random data for " "%s (requested %d, got %d)\n", algo, template[i].rlen, err); + if (err >= 0) + err = -EINVAL; break; } }