From patchwork Tue Oct 3 23:00:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Lamparter X-Patchwork-Id: 9983629 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B9D006029B for ; Tue, 3 Oct 2017 23:00:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B05F028A45 for ; Tue, 3 Oct 2017 23:00:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A48E428A41; Tue, 3 Oct 2017 23:00:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4696E289DA for ; Tue, 3 Oct 2017 23:00:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751267AbdJCXA0 (ORCPT ); Tue, 3 Oct 2017 19:00:26 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:56492 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbdJCXAZ (ORCPT ); Tue, 3 Oct 2017 19:00:25 -0400 Received: by mail-wm0-f66.google.com with SMTP id l68so5992116wmd.5 for ; Tue, 03 Oct 2017 16:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=aHCUkvD0M6S7CzXKwd+2nWm2nmSijEIeWWr0m9uEjvc=; b=as1YVx0EkvmmfQfqWLt2aC1Nx5mXxFn0uyviWmbkWgJHWjsmOonfqBN6a3DAZtx+kR 80cbTry8fQzhtFZSsiY397ubXV4SRWzyfowe/N5zVYcnvFSseKDjrUPwudAG++/apGrV OEmZk3140YzxQ41ijf5HDbWSKXR5bcQ/BNTWMLfQuHm+3BCQ2UOEoX+BvsgUgLgnsVE+ qft6n8Gh53CeedK0YQNkcbCM8Unf7eRidMk43ysLF6fyiLaewClcQYThzcwIzrpojNfB ImOukf1iXnFgtihRAxs9+VWvW9Th0ciRvKHAsBdoPk1EE/hzaFPNs6fAKB9mMdJ5LKJp +x6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=aHCUkvD0M6S7CzXKwd+2nWm2nmSijEIeWWr0m9uEjvc=; b=AooMjbXC1Fibz8NH9t9dTLfcHY5WCeqtMNXZXgr8p7kpP7VmTKjjerKX9/KzE4myYD pBOM4wmwCINArfkWmpNTjsYlasmh34BKr802qOHbR59S/rth98AJFGf2tuAPZWrbdV3v 6XBTdKWD86vLzjEcW59BYd++saKuYVZVBVL/DhSRfTicoUJkCAOcuaxMCur/M0QkhO3e +P8Ne9X7klrveul/ahQMLE2VZxZlKMjFhDwlY8muFbKVuaZs6PEpAdkox5wCrDPWWZMy dh0G3DR1Wt+O9EodOUYBtUrwMcBE2GHHL1Hru5Idqo37/O/Y1Vj48vOYFGi3f9A2C+6M LUAA== X-Gm-Message-State: AMCzsaWNyY2bC5yB6o5EM8kneRFZcQD8tq+HDLHf2Zer8MMIxr0ISjCJ CWCJ/t+cApfWUH6xEkocrEzQm9Lh X-Google-Smtp-Source: AOwi7QAgs0N6X2/FektO+46hDhIsmLJuvgGx370ovqK1INfWri1eIB/zpXzIunjgLATk6BIjRjAf1Q== X-Received: by 10.28.55.2 with SMTP id e2mr3404326wma.60.1507071623964; Tue, 03 Oct 2017 16:00:23 -0700 (PDT) Received: from debian64.daheim (p200300D5FBCA48FCD63D7EFFFEBDE96E.dip0.t-ipconnect.de. [2003:d5:fbca:48fc:d63d:7eff:febd:e96e]) by smtp.gmail.com with ESMTPSA id 4sm14367843wmg.20.2017.10.03.16.00.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Oct 2017 16:00:19 -0700 (PDT) Received: from chuck by debian64.daheim with local (Exim 4.89) (envelope-from ) id 1dzWAj-00010b-KO; Wed, 04 Oct 2017 01:00:17 +0200 From: Christian Lamparter To: linux-crypto@vger.kernel.org Cc: Herbert Xu Subject: [PATCH 08/13] crypto: crypto4xx: fix various warnings Date: Wed, 4 Oct 2017 01:00:12 +0200 Message-Id: <65233af33b900a33ca0796cf92a8ec7107b9bbae.1507070985.git.chunkeey@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <8c9b4bc7e3a88970fe0fc308034627b8ae972600.1507070985.git.chunkeey@gmail.com> References: <8c9b4bc7e3a88970fe0fc308034627b8ae972600.1507070985.git.chunkeey@gmail.com> In-Reply-To: <8c9b4bc7e3a88970fe0fc308034627b8ae972600.1507070985.git.chunkeey@gmail.com> References: <8c9b4bc7e3a88970fe0fc308034627b8ae972600.1507070985.git.chunkeey@gmail.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP crypto4xx_core.c:179:6: warning: symbol 'crypto4xx_free_state_record' was not declared. Should it be static? crypto4xx_core.c:331:5: warning: symbol 'crypto4xx_get_n_gd' was not declared. Should it be static? crypto4xx_core.c:652:6: warning: symbol 'crypto4xx_return_pd' was not declared. Should it be static? crypto4xx_return_pd() is not used by anything. Therefore it is removed. Signed-off-by: Christian Lamparter --- drivers/crypto/amcc/crypto4xx_core.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c index 254dc61c91a6..1752ea2125db 100644 --- a/drivers/crypto/amcc/crypto4xx_core.c +++ b/drivers/crypto/amcc/crypto4xx_core.c @@ -176,7 +176,7 @@ u32 crypto4xx_alloc_state_record(struct crypto4xx_ctx *ctx) return 0; } -void crypto4xx_free_state_record(struct crypto4xx_ctx *ctx) +static void crypto4xx_free_state_record(struct crypto4xx_ctx *ctx) { if (ctx->state_record != NULL) dma_free_coherent(ctx->dev->core_dev->device, @@ -322,10 +322,11 @@ static inline void crypto4xx_destroy_gdr(struct crypto4xx_device *dev) * when this function is called. * preemption or interrupt must be disabled */ -u32 crypto4xx_get_n_gd(struct crypto4xx_device *dev, int n) +static u32 crypto4xx_get_n_gd(struct crypto4xx_device *dev, int n) { u32 retval; u32 tmp; + if (n >= PPC4XX_NUM_GD) return ERING_WAS_FULL; @@ -616,17 +617,6 @@ static void crypto4xx_stop_all(struct crypto4xx_core_device *core_dev) kfree(core_dev); } -void crypto4xx_return_pd(struct crypto4xx_device *dev, - u32 pd_entry, struct ce_pd *pd, - struct pd_uinfo *pd_uinfo) -{ - /* irq should be already disabled */ - dev->pdr_head = pd_entry; - pd->pd_ctl.w = 0; - pd->pd_ctl_len.w = 0; - pd_uinfo->state = PD_ENTRY_FREE; -} - static u32 get_next_gd(u32 current) { if (current != PPC4XX_LAST_GD)