From patchwork Sat Jul 14 22:27:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michael_M=C3=BCller?= X-Patchwork-Id: 10524887 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EC90960388 for ; Sat, 14 Jul 2018 22:27:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DDED524603 for ; Sat, 14 Jul 2018 22:27:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D19FC25E97; Sat, 14 Jul 2018 22:27:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5184E24603 for ; Sat, 14 Jul 2018 22:27:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731426AbeGNWrm (ORCPT ); Sat, 14 Jul 2018 18:47:42 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38798 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731403AbeGNWrm (ORCPT ); Sat, 14 Jul 2018 18:47:42 -0400 Received: by mail-wr1-f65.google.com with SMTP id m1-v6so15590481wrg.5 for ; Sat, 14 Jul 2018 15:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fds-team.de; s=google; h=from:subject:to:cc:openpgp:autocrypt:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=0Ap0fC2q4MzN92lJV7TV5661ja5OzXUY6aDZvE1URog=; b=doQbjgOaNfnniYJgjdBd7Fl2UIGL5eXywkM8+bcPtYAsRrj1hqd4Twa3eWLOsYngb5 S6r9M9pw1OOK2pOmuqY56lym1uriXzTG/WZF5hOUBKicpz/eHZQYDVVLHE/O2k+AzpHc xb5D6XnWqPe5NV4Z3Epfm2DFBh+WZX5xgPewZzddJLM+W7Gu2M+y9VmmMEsGja3gmiLL sFIHeBtFx64zTCc95LaJWECiq2nOSBofYHp4+WmNrTy4DtcBAGm9DegGgECht9xb0AkX OGHPAA6C5X+rb815stN8YyxtlzOIFjM8HRo+i1ADLZCJN6jOUFZmrWGJYScL/xlWrvwC 5pLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:openpgp:autocrypt:message-id :date:user-agent:mime-version:content-language :content-transfer-encoding; bh=0Ap0fC2q4MzN92lJV7TV5661ja5OzXUY6aDZvE1URog=; b=Ebs37hlS0lWJI8YeZkm00gPtEj0lVHNZuk2EwGsrgAteeAuKh9L2qv+oUb4xiuR4cJ lXfg3TMp5o5sdVs+IAG8x3+PYgck/2Qxh06I6z/0Evz1NBp8UIhrknYFz59MRXKAiXO3 7L2bV49CCvBbJUb5HNXZrG68251bN/NmReKQHSneY0QJ2/Q7SjH77AxNHD7/GjRMZjup vthCLlP++HUCznyF8uxag4OMtaHflQfzgeHwL1kTwSkuwlf5OdUhi6/Co56zwq6wNKoC Y9xMbNrPtLkehTyBO169yNkSk1pLTDz4FXYMxiFhrLAnjM94jag2OjW/X09MvJ3gmMLL f1Vw== X-Gm-Message-State: AOUpUlFhA8Okp76k+o1ZG+4kxp7DWfcyKQqfFH7mjt2DXOpiQTAygZvs PcAE3eBvMzTCRS/Uz0lYVLAX1g== X-Google-Smtp-Source: AAOMgpfDiaFoLY3HuCUd6qi+0tHEwxJwaTRu4z1QAxCkZkig8RXcfjZXBQmR2s1HsSRttrqGN9ANNw== X-Received: by 2002:adf:ee4e:: with SMTP id w14-v6mr8818442wro.63.1531607227709; Sat, 14 Jul 2018 15:27:07 -0700 (PDT) Received: from [192.168.2.14] (p5DD5B15B.dip0.t-ipconnect.de. [93.213.177.91]) by smtp.googlemail.com with ESMTPSA id f20-v6sm2654185wrh.89.2018.07.14.15.27.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Jul 2018 15:27:07 -0700 (PDT) From: =?UTF-8?Q?Michael_M=c3=bcller?= Subject: [PATCH] crypto: sharah: Unregister correct algorithms for SAHARA 3 To: linux-crypto@vger.kernel.org Cc: Herbert Xu , "David S. Miller" , Steffen Trumtrar , Sebastian Lackner Openpgp: preference=signencrypt Autocrypt: addr=michael@fds-team.de; prefer-encrypt=mutual; keydata= xsFNBFD1yaoBEADP2t7UzV6rKZdjoBHQp3yo2uaLA2DxMNxpKDyin0QarA/pRudncQjA87Ao 1l3JPpr0MtYEslFXwpFMjceIUntNVYI8qu6PteD4xcORIDTMQ/GEZ+mfh1sXiTnK1BsZc2dh dJFmtKnqK8c0P4/yzmHD+WyLRXiHUexHm9YSdMeDtw/1K2iK7ZtEeFCaZIzChO3EBPkAEYmk 8LWaMYSEM3CQm+uETxiGyCKTcVqiJSzeWnibpbB6y0e9to7w009PdKR8VC9H+YfK4zD0T9V/ LVjIDO16ia2YgYzPsrQ9yLuK5zwib6jxh8DpwJrhEti6cget9uLEUPpw/9SidWZpWI7Ka3+r qgL4YYhnyvHN+8US0NM094ms7VKBADe3tRFu4DSQZBR2EjR0Vk7PcBuZ1gYJSBT11OvwXwHa JmvYaMUYrFEy5PoiHNJ5p+Bqm8gWMW2wtqVUOT7v2uBd0b/TzpbqLaF5jyLgU5IAgRFeSSTO PpJMC0R+AkcQmQQSdQiL3pmlDHES3ZzViGFx33G6QmiCmyUcwDTUNnaxnAojc16ZoIydmpK+ CIhbF6DTCkpfKkZp+rcpzkPq0noRgP8ad7U8Z0648CVXTo2ZAk1/tmUbYwlvvV6o51ukw0Bs 4QV8McJmThz9fwcxtZ97Ypf/c/KdoB9fFGE8rvswsn6vTrc8EwARAQABzTtNaWNoYWVsIE3D vGxsZXIgKG1pY2hhZWxAZmRzLXRlYW0uZGUpIDxtaWNoYWVsQGZkcy10ZWFtLmRlPsLBfgQT AQIAKAUCUPXJqgIbIwUJHDIEgAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQIdjeRl8r bjUsTw/8C+EKFkNls93yz5EsRiJk5DbbH5lcZ/GLCM/d20ImjCKLvCZ+C9FKqYQ7P4Lqg56s 0xwCmMfzq1zGLems3XSUlCwWdXCoSLcn+PsGlLwgCQBJmVymU+k4obW0VMbE2GgeqXQnlh57 Uga8tt2fwhLn+Es+I1Vqp9smpTSTMCo19wAaeTekIjMlMb8SNmOdeceJlCjZYXBgmkCr++t+ AXgcd4dA8sHc+XpdwW6tE7wTl+y9A4I95HQPwr2trV3w2VJ2fS9nRdZL/JTu/PAPhUacVs04 ygccbmm4BIqHdG6tG/aiF/Bh0DB62Xak3MbktUv7FeEYYEFoUUX9UiMDGN/XqXrN/+tCPgUE 3HZ3XZ1BGwfqCkFkwuIDGNGm0lMUoadA/5CPVhvUhTMLBDW/Nh/bItJE43YhVHSw0oKIfNJu r5ngF+yX0gZRgghyfyhUoiePSDAomDLU67CpDYEYZ225sDDDKhEy9jfoKoTTNZW6rthyAofW +Sjvi7qa9ylmDmjzhprz48+EIbsN5dAUoUGRUI1gi0qMc/sSgX4U7vQu6zRMVYz0KoK1shvb gxjj7WbUBLZGnnEnLvpHWfKeW55wLEetQ8WO2MVyCAGOSW81ZS4NCYEDMd1KFRs6ViRKrbQ7 03Zhuy6LhsRYEHNGmX0C1bAMV0J1+L8imdjSlt1oRRPOwU0EUPXJqgEQAKh6upbn6M5ueIIw V4agMy2gs3RYHBUKOwnnoEfkJ50bZYvyD37yuqEdMdo0RQIoxJWyZg/kjtt3i8yKDVgUGpYi 5NC5HekhsFu/HoyexypOQwkX1YkGqVgwhfuATD7ZOdk2SDVM/THEylK3dqlHwatUehae6Yt7 HUXbfALvtgyoduiUsa+m2uLddiLOzIrgDnGz3F11fqxClSYbkD9pYGAgtg5IIXwItCVDwLzZ /uBVApESRt6ed9WQGdqgsOe26usZKJPYNmhF4rQw/MxFd1cFrjonMURGQ2bumU8kTQEkab2J VJGvVqNrHbGGwoM8mYvZYgT4d0LVQwzpK65ThCeBbYsSxtvcJRu+w3DCmJBGRqlRJ2gg6HZG 3Koo0o+JjaPhezG4DTQqRw01ThOW9knuxrzPACXKRlAtCEUiM81qJXRvRUDx7wYCHloZNPaS 8s47cZd3brL3ow5asNUYYnRc7o7laIQM92J6EmVAsPqMSYf4TsaWqSrM4zTUUhmNe2UyvRYo VMQGZa14jVivr9HjXGgM1eWFi1Aa3jwu2RaxdmCvEaqXHDlctiGsPLAKQyidt1/2EUpzqkMs xvq+gjy0J0Io7JkQ4zFtN0qTUwT8dFr1E6WSuQVliDUEQ6qH0ZsskwqE3IjbMti56mUBUadA PvWrIlSE6PgUE+gsICIZABEBAAHCwWUEGAECAA8FAlD1yaoCGwwFCRwyBIAACgkQIdjeRl8r bjW/+Q/7B0z0TdRHl+R1TbtuJPBCBOCq2pwakAhVde2k2elcTVGAM6GOdddlDGjLHhc6ndyt 6LrRYnjOJ+jatW2njrwrTAXHSNrK17duKEOud2x07BOvqMfsgCl+1tzG+LQewGEc3Spl7TjA vI9JOt0vdgdSwuH3NHTXQvM9d4GrqqFMyQHGUcXQDDYzvYlEamLEEhQXFzq5lQ9EeoYniYqr OwNs2x4A7ulwPLvTU9Ofom8vAouX4hEJdQZZoos1smkpuFpP+PPnLliFodzW2F0puRfga+xj OMRN1z5UNijEl0wWRPu2mRdz4TPiAZYlMwYQTIyns6yvI6FA+mBjcygAxp8XhVmJbrEMzvHk wSVizLZJtnrWGrX1d92YfLI1o1FzywYG/GC1/638Cyz/7xAkxGvgmUoyukQq7ujoJ2k5ik/9 hZsrqUcvBqQql9uSdwPrmN7QFZQIjh8umHh+DQqS+rKOyDn53M/gflJaO1BAnDhlnt6bWzmt CpJ14qRCnC4WQbxXMh03uTUII3B8yIA5ryHPzGEES64XL81LyzEwd6vnC5q2paiNh74l3s9X S2mb6NjhQ0F9/pNn/N8tIUI1hBOBSUUHNCNxkZ4ZJZ8swUkYae1Cpt2OzgbFcHjbRSVN2Kg3 Cdi2J5DDoOMyNor5H3uq2uYtc/+2P1vBZnjb5TyZfow= Message-ID: <91725c6a-6dc9-a503-69cf-f412b7b4cd45@fds-team.de> Date: Sun, 15 Jul 2018 00:27:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Language: en-US Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes two typos related to unregistering algorithms supported by SAHARAH 3. In sahara_register_algs the wrong algorithms are unregistered in case of an error. In sahara_unregister_algs the wrong array is used to determine the iteration count. Signed-off-by: Michael Müller --- Sorry for the duplicate email. I forgot the [PATCH] prefix, which is automatically filtered out by the git tools that I use for other open source projects. drivers/crypto/sahara.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c index 4379f016fbee..e7540a5b8197 100644 --- a/drivers/crypto/sahara.c +++ b/drivers/crypto/sahara.c @@ -1349,7 +1349,7 @@ static int sahara_register_algs(struct sahara_dev *dev) err_sha_v3_algs: for (j = 0; j < k; j++) - crypto_unregister_ahash(&sha_v4_algs[j]); + crypto_unregister_ahash(&sha_v3_algs[j]); err_aes_algs: for (j = 0; j < i; j++) @@ -1365,7 +1365,7 @@ static void sahara_unregister_algs(struct sahara_dev *dev) for (i = 0; i < ARRAY_SIZE(aes_algs); i++) crypto_unregister_alg(&aes_algs[i]); - for (i = 0; i < ARRAY_SIZE(sha_v4_algs); i++) + for (i = 0; i < ARRAY_SIZE(sha_v3_algs); i++) crypto_unregister_ahash(&sha_v3_algs[i]); if (dev->version > SAHARA_VERSION_3)