From patchwork Thu Apr 23 20:10:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 6264901 Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 01F8ABF4A6 for ; Thu, 23 Apr 2015 20:10:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 29AAD2039E for ; Thu, 23 Apr 2015 20:10:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B66E2039D for ; Thu, 23 Apr 2015 20:10:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758318AbbDWUK2 (ORCPT ); Thu, 23 Apr 2015 16:10:28 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:36739 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758310AbbDWUK0 (ORCPT ); Thu, 23 Apr 2015 16:10:26 -0400 Received: by iebrs15 with SMTP id rs15so69495027ieb.3 for ; Thu, 23 Apr 2015 13:10:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=OMMeYz9W56l9B02AKa2lqjFfXr8/mv3Me+k0v6r50M4=; b=Jh4q6D5zYWKslkZ9pbmYu2gg/EcAP9fJ859GZNu5YUT7qv+ftriaRFT0hj9n4x9Q7A LczZ+hD29JwM7Tjc+PhC4YCN84Z0zvAE264gZZ/Tj3LaNZnRzJ/XeKTBTOD6O2dppOMG 5DlImVqiEfZyQZUe6QtvKCZRI5sth+I4n3dMW9j/xo6C7TSdPBX5oH6dWNWwjUDeXM+o eEA0brxtynn/jEtbx6T/H92rEqLneOUk6YiYvGCu4Oa7ov0iZPdlCmAK/HwrVNpVZrKM QwnMZ1esHHZu7tzIT9TSSJEov6Kc+Qkzp9ri3ibDwEnFPTNTHoLlWA2cYdQrxGDfSZfS 35lg== X-Gm-Message-State: ALoCoQnpVg/dkI8DmzxFGCpEsCtJFjQkVKKGP9HA4f/W0MjvJYJL7L62UpBUoe0L6jk+YE1YyiKv MIME-Version: 1.0 X-Received: by 10.107.168.79 with SMTP id r76mr6316734ioe.47.1429819826095; Thu, 23 Apr 2015 13:10:26 -0700 (PDT) Received: by 10.36.125.5 with HTTP; Thu, 23 Apr 2015 13:10:26 -0700 (PDT) In-Reply-To: References: <20140804130339.GA1178@gondor.apana.org.au> <20141007131826.GA29688@gondor.apana.org.au> <20141211125119.GA12380@gondor.apana.org.au> <20150214094328.GA7457@gondor.apana.org.au> <20150415033951.GA1406@gondor.apana.org.au> <20150416024252.GA11558@gondor.apana.org.au> <20150416030713.GA11668@gondor.apana.org.au> Date: Thu, 23 Apr 2015 22:10:26 +0200 Message-ID: Subject: Re: Crypto Update for 4.1 From: Ard Biesheuvel To: Bobby Powers Cc: Linus Torvalds , Herbert Xu , Stephan Mueller , "David S. Miller" , Linux Kernel Mailing List , Linux Crypto Mailing List Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 23 April 2015 at 21:27, Bobby Powers wrote: > Hello, > > Linus Torvalds wrote: >> Ok, this patch seems to fix it for me, so I undid my revert that I >> hadn't pushed out yet, and pushed out this instead. > > Commit e68410ebf62676dfb93aafff7c55b76644f37072 in Linus's tree from > this crpyto update (crypto: x86/sha512_ssse3 - move SHA-384/512 SSSE3 > implementation to base layer) causes a GPF on boot in > sha512_ssse3_finup for me on a Broadwell i7-5600U, rendering the > kernel unbootable. > > Reverting that commit enables me to boot. I don't know enough about > the code to comment. Config is attached, and I can provide a photo of > the reported Call Trace if thats helpful. It is quite reproducible > for me. > Hello Bobby, Would you be able to check whether the following patch fixes the crash? If not, please share the call trace and the content of /proc/cpuinfo Regards, Ard. Tested-By: Bobby Powers --- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/crypto/sha512-avx2-asm.S b/arch/x86/crypto/sha512-avx2-asm.S index a4771dcd1fcf..1f20b35d8573 100644 --- a/arch/x86/crypto/sha512-avx2-asm.S +++ b/arch/x86/crypto/sha512-avx2-asm.S @@ -79,7 +79,7 @@ NUM_BLKS = %rdx c = %rcx d = %r8 e = %rdx -y3 = %rdi +y3 = %rsi TBL = %rbp