| Message ID | CAKv+Gu8tPfX76ntdQmMz53waE73RHfB11oRs8w=Ufy7d=YqbGA@mail.gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
On Thu, Nov 24, 2016 at 05:32:42PM +0000, Ard Biesheuvel wrote: > On 24 November 2016 at 15:43, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > This is a straight transliteration of the Intel algorithm implemented > > using SSE and PCLMULQDQ instructions that resides under in the file > > arch/x86/crypto/crct10dif-pcl-asm_64.S. > > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > --- > > arch/arm/crypto/Kconfig | 5 + > > arch/arm/crypto/Makefile | 2 + > > arch/{arm64 => arm}/crypto/crct10dif-ce-core.S | 457 +++++++++++--------- > > arch/{arm64 => arm}/crypto/crct10dif-ce-glue.c | 23 +- > > 4 files changed, 277 insertions(+), 210 deletions(-) > > > > This patch needs the following hunk folded in to avoid breaking the > Thumb2 build: > > """ > diff --git a/arch/arm/crypto/crct10dif-ce-core.S > b/arch/arm/crypto/crct10dif-ce-core.S > index 30168b0f8581..4fdbca94dd0c 100644 > --- a/arch/arm/crypto/crct10dif-ce-core.S > +++ b/arch/arm/crypto/crct10dif-ce-core.S > @@ -152,7 +152,8 @@ CPU_LE( vrev64.8 q7, q7 ) > // XOR the initial_crc value > veor.8 q0, q0, q10 > > - adrl ip, rk3 > +ARM( adrl ip, rk3 ) > +THUMB( adr ip, rk3 ) > vld1.64 {q10}, [ip] // xmm10 has rk3 and rk4 > // type of pmull instruction > // will determine which constant to use > """ I'm sorry but this patch doesn't apply on top of the other four. So please resend the whole series. Thanks,
On 28 November 2016 at 14:17, Herbert Xu <herbert@gondor.apana.org.au> wrote: > On Thu, Nov 24, 2016 at 05:32:42PM +0000, Ard Biesheuvel wrote: >> On 24 November 2016 at 15:43, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: >> > This is a straight transliteration of the Intel algorithm implemented >> > using SSE and PCLMULQDQ instructions that resides under in the file >> > arch/x86/crypto/crct10dif-pcl-asm_64.S. >> > >> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> > --- >> > arch/arm/crypto/Kconfig | 5 + >> > arch/arm/crypto/Makefile | 2 + >> > arch/{arm64 => arm}/crypto/crct10dif-ce-core.S | 457 +++++++++++--------- >> > arch/{arm64 => arm}/crypto/crct10dif-ce-glue.c | 23 +- >> > 4 files changed, 277 insertions(+), 210 deletions(-) >> > >> >> This patch needs the following hunk folded in to avoid breaking the >> Thumb2 build: >> >> """ >> diff --git a/arch/arm/crypto/crct10dif-ce-core.S >> b/arch/arm/crypto/crct10dif-ce-core.S >> index 30168b0f8581..4fdbca94dd0c 100644 >> --- a/arch/arm/crypto/crct10dif-ce-core.S >> +++ b/arch/arm/crypto/crct10dif-ce-core.S >> @@ -152,7 +152,8 @@ CPU_LE( vrev64.8 q7, q7 ) >> // XOR the initial_crc value >> veor.8 q0, q0, q10 >> >> - adrl ip, rk3 >> +ARM( adrl ip, rk3 ) >> +THUMB( adr ip, rk3 ) >> vld1.64 {q10}, [ip] // xmm10 has rk3 and rk4 >> // type of pmull instruction >> // will determine which constant to use >> """ > > I'm sorry but this patch doesn't apply on top of the other four. > So please resend the whole series. > Yes, please disregard all CRC ARM/arm64 patches for now, I will consolidate them into a single v2 and send it out after the merge window. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/crypto/crct10dif-ce-core.S b/arch/arm/crypto/crct10dif-ce-core.S index 30168b0f8581..4fdbca94dd0c 100644 --- a/arch/arm/crypto/crct10dif-ce-core.S +++ b/arch/arm/crypto/crct10dif-ce-core.S @@ -152,7 +152,8 @@ CPU_LE( vrev64.8 q7, q7 ) // XOR the initial_crc value veor.8 q0, q0, q10 - adrl ip, rk3 +ARM( adrl ip, rk3 ) +THUMB( adr ip, rk3 ) vld1.64 {q10}, [ip] // xmm10 has rk3 and rk4 // type of pmull instruction // will determine which constant to use