| Message ID | SEZPR01MB45275F2F7A32D2DE4D6E2C9BA8C82@SEZPR01MB4527.apcprd01.prod.exchangelabs.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: qat - initialize user_input.lock for rate_limiting | expand |
On Thu, Jun 20, 2024 at 04:51:10PM +0800, Jiwei Sun wrote: > From: Jiwei Sun <sunjw10@lenovo.com> > > If the following configurations are set, > CONFIG_DEBUG_RWSEMS=y > CONFIG_DEBUG_LOCK_ALLOC=y > CONFIG_RWSEM_SPIN_ON_OWNER=y > > And run the following command, > [root@localhost sys]# cat /sys/devices/pci0000:6b/0000:6b:00.0/qat_rl/pir > The following warning log appears, > > ------------[ cut here ]------------ > DEBUG_RWSEMS_WARN_ON(sem->magic != sem): count = 0x0, magic = 0x0, owner = 0x1, curr 0xff11000119288040, list not empty > WARNING: CPU: 131 PID: 1254984 at kernel/locking/rwsem.c:1280 down_read+0x439/0x7f0 > CPU: 131 PID: 1254984 Comm: cat Kdump: loaded Tainted: G W 6.10.0-rc4+ #86 b2ae60c8ceabed15f4fd2dba03c1c5a5f7f4040c > Hardware name: Lenovo ThinkServer SR660 V3/SR660 V3, BIOS T8E166X-2.54 05/30/2024 > RIP: 0010:down_read+0x439/0x7f0 > Code: 44 24 10 80 3c 02 00 0f 85 05 03 00 00 48 8b 13 41 54 48 c7 c6 a0 3e 0e b4 48 c7 c7 e0 3e 0e b4 4c 8b 4c 24 08 e8 77 d5 40 fd <0f> 0b 59 e9 bc fc ff ff 0f 1f 44 00 00 e9 e2 fd ff ff 4c 8d 7b 08 > RSP: 0018:ffa0000035f67a78 EFLAGS: 00010286 > RAX: 0000000000000000 RBX: ff1100012b03a658 RCX: 0000000000000000 > RDX: 0000000080000002 RSI: 0000000000000008 RDI: 0000000000000001 > RBP: 1ff4000006becf53 R08: fff3fc0006becf17 R09: fff3fc0006becf17 > R10: fff3fc0006becf16 R11: ffa0000035f678b7 R12: ffffffffb40e3e60 > R13: ffffffffb627d1f4 R14: ff1100012b03a6d0 R15: ff1100012b03a6c8 > FS: 00007fa9ff9a6740(0000) GS:ff1100081e600000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007fa9ff984000 CR3: 00000002118ae006 CR4: 0000000000771ef0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe07f0 DR7: 0000000000000400 > PKRU: 55555554 > Call Trace: > <TASK> > pir_show+0x5d/0xe0 [intel_qat 9e297e249ab040329cf58b657b06f418fd5c5855] > dev_attr_show+0x3f/0xc0 > sysfs_kf_seq_show+0x1ce/0x400 > seq_read_iter+0x3fa/0x10b0 > vfs_read+0x6f5/0xb20 > ksys_read+0xe9/0x1d0 > do_syscall_64+0x8a/0x170 > entry_SYSCALL_64_after_hwframe+0x76/0x7e > RIP: 0033:0x7fa9ff6fd9b2 > Code: c0 e9 b2 fe ff ff 50 48 8d 3d ea 1d 0c 00 e8 c5 fd 01 00 0f 1f 44 00 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 0f 05 <48> 3d 00 f0 ff ff 77 56 c3 0f 1f 44 00 00 48 83 ec 28 48 89 54 24 > RSP: 002b:00007ffc0616b968 EFLAGS: 00000246 ORIG_RAX: 0000000000000000 > RAX: ffffffffffffffda RBX: 0000000000020000 RCX: 00007fa9ff6fd9b2 > RDX: 0000000000020000 RSI: 00007fa9ff985000 RDI: 0000000000000003 > RBP: 00007fa9ff985000 R08: 00007fa9ff984010 R09: 0000000000000000 > R10: 0000000000000022 R11: 0000000000000246 R12: 0000000000022000 > R13: 0000000000000003 R14: 0000000000020000 R15: 0000000000020000 > </TASK> > irq event stamp: 0 > hardirqs last enabled at (0): [<0000000000000000>] 0x0 > hardirqs last disabled at (0): [<ffffffffb102c126>] copy_process+0x21e6/0x6e70 > softirqs last enabled at (0): [<ffffffffb102c176>] copy_process+0x2236/0x6e70 > softirqs last disabled at (0): [<0000000000000000>] 0x0 > ---[ end trace 0000000000000000 ]--- > > The rate_limiting->user_input.lock rwsem lock is not initialized before > use. Let's initialize it. > > Signed-off-by: Jiwei Sun <sunjw10@lenovo.com> > Reviewed-by: Adrian Huang <ahuang12@lenovo.com> > --- Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
On Thu, Jun 20, 2024 at 04:51:10PM +0800, Jiwei Sun wrote: > From: Jiwei Sun <sunjw10@lenovo.com> > > If the following configurations are set, > CONFIG_DEBUG_RWSEMS=y > CONFIG_DEBUG_LOCK_ALLOC=y > CONFIG_RWSEM_SPIN_ON_OWNER=y > > And run the following command, > [root@localhost sys]# cat /sys/devices/pci0000:6b/0000:6b:00.0/qat_rl/pir > The following warning log appears, > > ------------[ cut here ]------------ > DEBUG_RWSEMS_WARN_ON(sem->magic != sem): count = 0x0, magic = 0x0, owner = 0x1, curr 0xff11000119288040, list not empty > WARNING: CPU: 131 PID: 1254984 at kernel/locking/rwsem.c:1280 down_read+0x439/0x7f0 > CPU: 131 PID: 1254984 Comm: cat Kdump: loaded Tainted: G W 6.10.0-rc4+ #86 b2ae60c8ceabed15f4fd2dba03c1c5a5f7f4040c > Hardware name: Lenovo ThinkServer SR660 V3/SR660 V3, BIOS T8E166X-2.54 05/30/2024 > RIP: 0010:down_read+0x439/0x7f0 > Code: 44 24 10 80 3c 02 00 0f 85 05 03 00 00 48 8b 13 41 54 48 c7 c6 a0 3e 0e b4 48 c7 c7 e0 3e 0e b4 4c 8b 4c 24 08 e8 77 d5 40 fd <0f> 0b 59 e9 bc fc ff ff 0f 1f 44 00 00 e9 e2 fd ff ff 4c 8d 7b 08 > RSP: 0018:ffa0000035f67a78 EFLAGS: 00010286 > RAX: 0000000000000000 RBX: ff1100012b03a658 RCX: 0000000000000000 > RDX: 0000000080000002 RSI: 0000000000000008 RDI: 0000000000000001 > RBP: 1ff4000006becf53 R08: fff3fc0006becf17 R09: fff3fc0006becf17 > R10: fff3fc0006becf16 R11: ffa0000035f678b7 R12: ffffffffb40e3e60 > R13: ffffffffb627d1f4 R14: ff1100012b03a6d0 R15: ff1100012b03a6c8 > FS: 00007fa9ff9a6740(0000) GS:ff1100081e600000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007fa9ff984000 CR3: 00000002118ae006 CR4: 0000000000771ef0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe07f0 DR7: 0000000000000400 > PKRU: 55555554 > Call Trace: > <TASK> > pir_show+0x5d/0xe0 [intel_qat 9e297e249ab040329cf58b657b06f418fd5c5855] > dev_attr_show+0x3f/0xc0 > sysfs_kf_seq_show+0x1ce/0x400 > seq_read_iter+0x3fa/0x10b0 > vfs_read+0x6f5/0xb20 > ksys_read+0xe9/0x1d0 > do_syscall_64+0x8a/0x170 > entry_SYSCALL_64_after_hwframe+0x76/0x7e > RIP: 0033:0x7fa9ff6fd9b2 > Code: c0 e9 b2 fe ff ff 50 48 8d 3d ea 1d 0c 00 e8 c5 fd 01 00 0f 1f 44 00 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 0f 05 <48> 3d 00 f0 ff ff 77 56 c3 0f 1f 44 00 00 48 83 ec 28 48 89 54 24 > RSP: 002b:00007ffc0616b968 EFLAGS: 00000246 ORIG_RAX: 0000000000000000 > RAX: ffffffffffffffda RBX: 0000000000020000 RCX: 00007fa9ff6fd9b2 > RDX: 0000000000020000 RSI: 00007fa9ff985000 RDI: 0000000000000003 > RBP: 00007fa9ff985000 R08: 00007fa9ff984010 R09: 0000000000000000 > R10: 0000000000000022 R11: 0000000000000246 R12: 0000000000022000 > R13: 0000000000000003 R14: 0000000000020000 R15: 0000000000020000 > </TASK> > irq event stamp: 0 > hardirqs last enabled at (0): [<0000000000000000>] 0x0 > hardirqs last disabled at (0): [<ffffffffb102c126>] copy_process+0x21e6/0x6e70 > softirqs last enabled at (0): [<ffffffffb102c176>] copy_process+0x2236/0x6e70 > softirqs last disabled at (0): [<0000000000000000>] 0x0 > ---[ end trace 0000000000000000 ]--- > > The rate_limiting->user_input.lock rwsem lock is not initialized before > use. Let's initialize it. > > Signed-off-by: Jiwei Sun <sunjw10@lenovo.com> > Reviewed-by: Adrian Huang <ahuang12@lenovo.com> > --- > drivers/crypto/intel/qat/qat_common/adf_rl.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks.
diff --git a/drivers/crypto/intel/qat/qat_common/adf_rl.c b/drivers/crypto/intel/qat/qat_common/adf_rl.c index 346ef8bee99d..e782c23fc1bf 100644 --- a/drivers/crypto/intel/qat/qat_common/adf_rl.c +++ b/drivers/crypto/intel/qat/qat_common/adf_rl.c @@ -1106,6 +1106,7 @@ int adf_rl_init(struct adf_accel_dev *accel_dev) mutex_init(&rl->rl_lock); rl->device_data = &accel_dev->hw_device->rl_data; rl->accel_dev = accel_dev; + init_rwsem(&rl->user_input.lock); accel_dev->rate_limiting = rl; err_ret: