From patchwork Tue May 23 02:33:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Herbert Xu X-Patchwork-Id: 13251387 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7311CC7EE29 for ; Tue, 23 May 2023 02:33:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234671AbjEWCd4 (ORCPT ); Mon, 22 May 2023 22:33:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232034AbjEWCdz (ORCPT ); Mon, 22 May 2023 22:33:55 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72BFF185; Mon, 22 May 2023 19:33:51 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1q1HqE-00C99V-IG; Tue, 23 May 2023 10:33:39 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Tue, 23 May 2023 10:33:38 +0800 Date: Tue, 23 May 2023 10:33:38 +0800 From: Herbert Xu To: Stephen Rothwell , Conor Dooley Cc: Linux Crypto List , Huan Feng , Jia Jie Ho , Linux Kernel Mailing List , Linux Next Mailing List Subject: [PATCH] crypto: starfive - Depend on AMBA_PL08X instead of selecting it Message-ID: References: <20230522105257.562cb1ec@canb.auug.org.au> <20230523103637.20175fbc@canb.auug.org.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230523103637.20175fbc@canb.auug.org.au> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, May 23, 2023 at 10:36:37AM +1000, Stephen Rothwell wrote: > > That did not fix it :-( OK, this patch should fix it: ---8<--- A platform option like AMBA should never be selected by a driver. Use a dependency instead. Also remove the depenency on DMADEVICES because the driver builds just fine without it. Instead add a dependency on HAS_DMA for dma mapping support. Reported-by: Stephen Rothwell Reported-by: Conor Dooley Signed-off-by: Herbert Xu Reviewed-by: Conor Dooley diff --git a/drivers/crypto/starfive/Kconfig b/drivers/crypto/starfive/Kconfig index 908c162ba79a..59002abcc0ad 100644 --- a/drivers/crypto/starfive/Kconfig +++ b/drivers/crypto/starfive/Kconfig @@ -4,14 +4,13 @@ config CRYPTO_DEV_JH7110 tristate "StarFive JH7110 cryptographic engine driver" - depends on (SOC_STARFIVE || COMPILE_TEST) && DMADEVICES + depends on SOC_STARFIVE || AMBA_PL08X || COMPILE_TEST + depends on HAS_DMA select CRYPTO_ENGINE select CRYPTO_HMAC select CRYPTO_SHA256 select CRYPTO_SHA512 select CRYPTO_SM3_GENERIC - select ARM_AMBA - select AMBA_PL08X help Support for StarFive JH7110 crypto hardware acceleration engine. This module provides acceleration for public key algo,