diff mbox series

[1/5] ASN.1: Add missing include <linux/types.h>

Message ID a98ae07646e243fe0d9c1a25fcb3feb3e5987960.1722260176.git.lukas@wunner.de (mailing list archive)
State Changes Requested
Delegated to: Herbert Xu
Headers show
Series Templatize ecdsa signature decoding | expand

Commit Message

Lukas Wunner July 29, 2024, 1:47 p.m. UTC
If <linux/asn1_decoder.h> is the first header included from a .c file
(due to headers being sorted alphabetically), the compiler complains:

include/linux/asn1_decoder.h:18:29: error: unknown type name 'size_t'

Fix it.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
---
 include/linux/asn1_decoder.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Berger July 30, 2024, 1:50 p.m. UTC | #1
On 7/29/24 9:47 AM, Lukas Wunner wrote:
> If <linux/asn1_decoder.h> is the first header included from a .c file
> (due to headers being sorted alphabetically), the compiler complains:
> 
> include/linux/asn1_decoder.h:18:29: error: unknown type name 'size_t'
> 
> Fix it.
> 
> Signed-off-by: Lukas Wunner <lukas@wunner.de>

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>

> ---
>   include/linux/asn1_decoder.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/asn1_decoder.h b/include/linux/asn1_decoder.h
> index 83f9c6e1e5e9..b41bce82a191 100644
> --- a/include/linux/asn1_decoder.h
> +++ b/include/linux/asn1_decoder.h
> @@ -9,6 +9,7 @@
>   #define _LINUX_ASN1_DECODER_H
>   
>   #include <linux/asn1.h>
> +#include <linux/types.h>
>   
>   struct asn1_decoder;
>
Jonathan Cameron Aug. 1, 2024, 2:42 p.m. UTC | #2
On Mon, 29 Jul 2024 15:47:00 +0200
Lukas Wunner <lukas@wunner.de> wrote:

> If <linux/asn1_decoder.h> is the first header included from a .c file
> (due to headers being sorted alphabetically), the compiler complains:
> 
> include/linux/asn1_decoder.h:18:29: error: unknown type name 'size_t'
> 
> Fix it.
> 
> Signed-off-by: Lukas Wunner <lukas@wunner.de>

FWIW
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

I see asn1_encoder.h already has this include so this
is nice and consistent.

However that header includes bug.h which should probably be
pushed down into the relevant c files.  Not relevant for this
series though so one for another day (or never :)

> ---
>  include/linux/asn1_decoder.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/asn1_decoder.h b/include/linux/asn1_decoder.h
> index 83f9c6e1e5e9..b41bce82a191 100644
> --- a/include/linux/asn1_decoder.h
> +++ b/include/linux/asn1_decoder.h
> @@ -9,6 +9,7 @@
>  #define _LINUX_ASN1_DECODER_H
>  
>  #include <linux/asn1.h>
> +#include <linux/types.h>
>  
>  struct asn1_decoder;
>
diff mbox series

Patch

diff --git a/include/linux/asn1_decoder.h b/include/linux/asn1_decoder.h
index 83f9c6e1e5e9..b41bce82a191 100644
--- a/include/linux/asn1_decoder.h
+++ b/include/linux/asn1_decoder.h
@@ -9,6 +9,7 @@ 
 #define _LINUX_ASN1_DECODER_H
 
 #include <linux/asn1.h>
+#include <linux/types.h>
 
 struct asn1_decoder;