From patchwork Mon Aug 28 14:00:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geliang Tang X-Patchwork-Id: 9925565 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0FE1A60329 for ; Mon, 28 Aug 2017 14:00:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 031E4286C7 for ; Mon, 28 Aug 2017 14:00:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EBBB0286D9; Mon, 28 Aug 2017 14:00:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 53FD6286C7 for ; Mon, 28 Aug 2017 14:00:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751242AbdH1OAY (ORCPT ); Mon, 28 Aug 2017 10:00:24 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33593 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbdH1OAY (ORCPT ); Mon, 28 Aug 2017 10:00:24 -0400 Received: by mail-lf0-f65.google.com with SMTP id y15so431152lfd.0; Mon, 28 Aug 2017 07:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ugOGD4oT0GNXZWKlstK3s7mY+7ACCU9haSxozeOWJjQ=; b=akyJHyToJHhaiV5keEI+1Eiq7kk9tKF8FzkeWp/U3tYbjwSdRpKJWGN1CKaLls/yCf QcnXcauMNPfBpJ2wMv3XNlAzlLDVyQgduHMqWKC6WsrmENWbsuJv4mjKaYFGKu6E/T18 n/gizEPxsgs9E5X9XhVBsPhry/OHhIm/y7bhg39LnlXeeBXrdEXOgN/8K2J5Wf7wLpEj 6egC9HQZeBRpc/tdLkO2Ciey/sZMUiQsYpbyJF6aKfGLj4U7EM2+nnXPVUqsrshMAGfW 3KfRPjV3SLtuHUrZ7kPHhoIIbZ/V2RuvMkI4kZFiRm2Pqq+k2BIvI4TJNR5IfuNjsFU5 PmoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ugOGD4oT0GNXZWKlstK3s7mY+7ACCU9haSxozeOWJjQ=; b=SCMhJ09KC1fIbSsERtihEobVclR4OxOCPJ0EW2m8YC2KApwHXnCUsCMmcGzUA4CBlG GYCIoyVgDswQ49UUgYHFToNOxjLq3u7xJrY8ouqEvjte4Fax2yXHHXNPrBuvanqrfs44 IZR2Ck2nipxb9T8KlN4D5wFuwH14JqHPqfmkk/MtUjS5JE78hKwMiUlCvqAixHo0sx2Y uz2InCg2uqYKbTHsU9ZR2LgFEYPZspXOCxCXXQOVQLhZGyS3jxB39INVTBg66Y3bVNxn 9WZ6a0Nax5vSr+qepdZF8BnDyQY7KQpCcqg/sZMh6voFs2Q6FcgTLhm8Us7sHLzFiAAl QSJw== X-Gm-Message-State: AHYfb5jRMWjntX82qHVAh+G5Ces2cfvqBS5VdzxsLgVgy41Kd9G8AwOs JyOVXUf01+8hmg== X-Received: by 10.46.0.77 with SMTP id 74mr307881lja.112.1503928822276; Mon, 28 Aug 2017 07:00:22 -0700 (PDT) Received: from localhost ([162.211.125.117]) by smtp.gmail.com with ESMTPSA id u197sm103721lja.70.2017.08.28.07.00.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Aug 2017 07:00:21 -0700 (PDT) From: Geliang Tang To: Herbert Xu , "David S. Miller" , Boris Brezillon , Arnaud Ebalard Cc: Geliang Tang , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: drop unnecessary return statements Date: Mon, 28 Aug 2017 22:00:07 +0800 Message-Id: X-Mailer: git-send-email 2.11.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix checkpatch.pl warnings: WARNING: void function return statements are not generally useful FILE: crypto/rmd128.c:218: FILE: crypto/rmd160.c:261: FILE: crypto/rmd256.c:233: FILE: crypto/rmd320.c:280: FILE: crypto/tcrypt.c:385: FILE: drivers/crypto/ixp4xx_crypto.c:538: FILE: drivers/crypto/marvell/cesa.c:81: FILE: drivers/crypto/ux500/cryp/cryp_core.c:1755: Signed-off-by: Geliang Tang --- crypto/rmd128.c | 2 -- crypto/rmd160.c | 2 -- crypto/rmd256.c | 2 -- crypto/rmd320.c | 2 -- crypto/tcrypt.c | 1 - drivers/crypto/ixp4xx_crypto.c | 1 - drivers/crypto/marvell/cesa.c | 2 -- drivers/crypto/ux500/cryp/cryp_core.c | 1 - 8 files changed, 13 deletions(-) diff --git a/crypto/rmd128.c b/crypto/rmd128.c index 049486e..40e053b 100644 --- a/crypto/rmd128.c +++ b/crypto/rmd128.c @@ -213,8 +213,6 @@ static void rmd128_transform(u32 *state, const __le32 *in) state[2] = state[3] + aa + bbb; state[3] = state[0] + bb + ccc; state[0] = ddd; - - return; } static int rmd128_init(struct shash_desc *desc) diff --git a/crypto/rmd160.c b/crypto/rmd160.c index de585e5..5f3e6ea 100644 --- a/crypto/rmd160.c +++ b/crypto/rmd160.c @@ -256,8 +256,6 @@ static void rmd160_transform(u32 *state, const __le32 *in) state[3] = state[4] + aa + bbb; state[4] = state[0] + bb + ccc; state[0] = ddd; - - return; } static int rmd160_init(struct shash_desc *desc) diff --git a/crypto/rmd256.c b/crypto/rmd256.c index 4ec02a7..f50c025 100644 --- a/crypto/rmd256.c +++ b/crypto/rmd256.c @@ -228,8 +228,6 @@ static void rmd256_transform(u32 *state, const __le32 *in) state[5] += bbb; state[6] += ccc; state[7] += ddd; - - return; } static int rmd256_init(struct shash_desc *desc) diff --git a/crypto/rmd320.c b/crypto/rmd320.c index 770f2cb..e1315e4 100644 --- a/crypto/rmd320.c +++ b/crypto/rmd320.c @@ -275,8 +275,6 @@ static void rmd320_transform(u32 *state, const __le32 *in) state[7] += ccc; state[8] += ddd; state[9] += eee; - - return; } static int rmd320_init(struct shash_desc *desc) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 0022a18..4b20d99 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -381,7 +381,6 @@ static void test_aead_speed(const char *algo, int enc, unsigned int secs, testmgr_free_buf(xbuf); out_noxbuf: kfree(iv); - return; } static void test_hash_sg_init(struct scatterlist *sg) diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c index dadc4a8..8705b28 100644 --- a/drivers/crypto/ixp4xx_crypto.c +++ b/drivers/crypto/ixp4xx_crypto.c @@ -534,7 +534,6 @@ static void release_ixp_crypto(struct device *dev) NPE_QLEN_TOTAL * sizeof( struct crypt_ctl), crypt_virt, crypt_phys); } - return; } static void reset_sa_dir(struct ix_sa_dir *dir) diff --git a/drivers/crypto/marvell/cesa.c b/drivers/crypto/marvell/cesa.c index 6e7a5c7..b657e7c 100644 --- a/drivers/crypto/marvell/cesa.c +++ b/drivers/crypto/marvell/cesa.c @@ -76,8 +76,6 @@ static void mv_cesa_rearm_engine(struct mv_cesa_engine *engine) ctx = crypto_tfm_ctx(req->tfm); ctx->ops->step(req); - - return; } static int mv_cesa_std_process(struct mv_cesa_engine *engine, u32 status) diff --git a/drivers/crypto/ux500/cryp/cryp_core.c b/drivers/crypto/ux500/cryp/cryp_core.c index 790f7ca..765f53e 100644 --- a/drivers/crypto/ux500/cryp/cryp_core.c +++ b/drivers/crypto/ux500/cryp/cryp_core.c @@ -1751,7 +1751,6 @@ static void __exit ux500_cryp_mod_fini(void) { pr_debug("[%s] is called!", __func__); platform_driver_unregister(&cryp_driver); - return; } module_init(ux500_cryp_mod_init);