From patchwork Tue May 14 05:45:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 2562991 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by patchwork2.kernel.org (Postfix) with ESMTP id A5A63DF24C for ; Tue, 14 May 2013 05:50:29 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id r4E5mk46003027; Tue, 14 May 2013 00:48:46 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r4E5mkJY008346; Tue, 14 May 2013 00:48:46 -0500 Received: from dlelxv23.itg.ti.com (172.17.1.198) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.2.342.3; Tue, 14 May 2013 00:48:45 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlelxv23.itg.ti.com (8.13.8/8.13.8) with ESMTP id r4E5mjiB029131; Tue, 14 May 2013 00:48:45 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id AAC1180628; Tue, 14 May 2013 00:48:45 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp51.itg.ti.com (dflp51.itg.ti.com [128.247.22.94]) by linux.omap.com (Postfix) with ESMTP id 8AD7980626 for ; Tue, 14 May 2013 00:48:03 -0500 (CDT) Received: from red.ext.ti.com (red.ext.ti.com [192.94.93.37]) by dflp51.itg.ti.com (8.13.7/8.13.8) with ESMTP id r4E5m3AP007451 for ; Tue, 14 May 2013 00:48:03 -0500 (CDT) Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by red.ext.ti.com (8.13.7/8.13.7) with ESMTP id r4E5m1ej011502 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 May 2013 00:48:02 -0500 Received: from [216.82.250.51:4635] by server-9.bemta-12.messagelabs.com id 3E/B7-17452-110D1915; Tue, 14 May 2013 05:48:01 +0000 X-Env-Sender: prabhakar.csengg@gmail.com X-Msg-Ref: server-15.tower-108.messagelabs.com!1368510480!6057280!1 X-Originating-IP: [209.85.160.54] X-SpamReason: No, hits=0.0 required=7.0 tests=ML_RADAR_SPEW_LINKS_14, spamassassin: X-StarScan-Received: X-StarScan-Version: 6.9.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 25846 invoked from network); 14 May 2013 05:48:01 -0000 Received: from mail-pb0-f54.google.com (HELO mail-pb0-f54.google.com) (209.85.160.54) by server-15.tower-108.messagelabs.com with RC4-SHA encrypted SMTP; 14 May 2013 05:48:01 -0000 Received: by mail-pb0-f54.google.com with SMTP id ro8so122904pbb.13 for ; Mon, 13 May 2013 22:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=An2N5Us6EnBxDjPyRg7gSqCsNdpdLcfSt9gOz+PnZtE=; b=nVngIwiUBJ0UcR+8Z8/PVmjAQKm0qG0+cFijoIUIsnVT6lWNcSY/gtm3zVk4NjyVVM TpIPEIYBAzY0F6E6EdMFBt5td9fanLr4sWwlDBm+z20MbC6KT0rMgmDpWXxdGts1NqH9 mBagkzNKh6ZnVpglxYVFy+BWBEdN2MmKg4bY9VU/UHBu5Gg4FxPedrQytK/VPs4hTBKt 9IiY8/MlzSojQs8DUG4c8cQHGnK5EogzxAAtZLH/RmUT9w4BGoGxf1Kj+zE/Of80PeY7 vay+gG88YbTm0ElaVtdWhDBJDT6B4qE1OAvh9RBVQPfPF/T5TldxvyTDIYpJy2ZcKfal 9ucg== X-Received: by 10.66.25.80 with SMTP id a16mr32682847pag.97.1368510479961; Mon, 13 May 2013 22:47:59 -0700 (PDT) Received: from localhost.localdomain ([59.98.240.128]) by mx.google.com with ESMTPSA id ya4sm16758033pbb.24.2013.05.13.22.47.51 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 13 May 2013 22:47:59 -0700 (PDT) From: Lad Prabhakar To: LMML , , Subject: [PATCH 3/4] media: usb: remove duplicate checks for EPERM in vidioc_g/s_register Date: Tue, 14 May 2013 11:15:16 +0530 Message-ID: <1368510317-4356-4-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1368510317-4356-1-git-send-email-prabhakar.csengg@gmail.com> References: <1368510317-4356-1-git-send-email-prabhakar.csengg@gmail.com> CC: Scott Jiang , Andy Walls , Mauro Carvalho Chehab , Jonathan Corbet , Janne Grunau , DLOS , , Alexey Klimov , Antti Palosaari , Hans Verkuil , Laurent Pinchart , Martin Bugge , =?UTF-8?q?Jon=20Arne=20J=C3=B8rgensen?= , =?UTF-8?q?Frank=20Sch=C3=A4fer?= , Andy Shevchenko , Mike Isely , Guennadi Liakhovetski , Javier Martin , Devin Heitmueller X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com From: Lad, Prabhakar This patch removes check for EPERM in vidioc_g/s_register as this check is already performed by core. Signed-off-by: Lad, Prabhakar --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c index e11267f..01d1c2d 100644 --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c @@ -5173,8 +5173,6 @@ int pvr2_hdw_register_access(struct pvr2_hdw *hdw, int stat = 0; int okFl = 0; - if (!capable(CAP_SYS_ADMIN)) return -EPERM; - req.match = *match; req.reg = reg_id; if (setFl) req.val = *val_ptr;