From patchwork Fri May 31 10:13:10 2013
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: "Hebbar, Gururaja" <gururaja.hebbar@ti.com>
X-Patchwork-Id: 2642081
Return-Path: <davinci-linux-open-source-bounces@linux.davincidsp.com>
X-Original-To: patchwork-davinci@patchwork.kernel.org
Delivered-To: patchwork-process-083081@patchwork1.kernel.org
Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153])
	by patchwork1.kernel.org (Postfix) with ESMTP id 4A9FD3FD2B
	for <patchwork-davinci@patchwork.kernel.org>;
	Fri, 31 May 2013 10:16:54 +0000 (UTC)
Received: from dlelxv90.itg.ti.com ([172.17.2.17])
	by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id r4VAFIc8018895;
	Fri, 31 May 2013 05:15:18 -0500
Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109])
	by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id r4VAFIW4012376;
	Fri, 31 May 2013 05:15:18 -0500
Received: from dlelxv24.itg.ti.com (172.17.1.199) by DFLE72.ent.ti.com
	(128.247.5.109) with Microsoft SMTP Server id 14.2.342.3;
	Fri, 31 May 2013 05:15:17 -0500
Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31])	by
	dlelxv24.itg.ti.com (8.13.8/8.13.8) with ESMTP id r4VAFHju021975;
	Fri, 31 May 2013 05:15:17 -0500
Received: from linux.omap.com (localhost [127.0.0.1])	by linux.omap.com
	(Postfix) with ESMTP	id B44BC8062D;
	Fri, 31 May 2013 05:15:17 -0500 (CDT)
X-Original-To: davinci-linux-open-source@linux.davincidsp.com
Delivered-To: davinci-linux-open-source@linux.davincidsp.com
Received: from dlelxv90.itg.ti.com (dlelxv90.itg.ti.com [172.17.2.17])	by
	linux.omap.com (Postfix) with ESMTP id 106BF8062C	for
	<davinci-linux-open-source@linux.davincidsp.com>;
	Fri, 31 May 2013 05:11:24 -0500 (CDT)
Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114])	by
	dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id r4VABNrp003665;
	Fri, 31 May 2013 05:11:24 -0500
Received: from dlelxv23.itg.ti.com (172.17.1.198) by DLEE71.ent.ti.com
	(157.170.170.114) with Microsoft SMTP Server id 14.2.342.3;
	Fri, 31 May 2013 05:11:23 -0500
Received: from ucmsshproxy.india.ext.ti.com (dbdp20.itg.ti.com
	[172.24.170.38])	by dlelxv23.itg.ti.com (8.13.8/8.13.8) with SMTP id
	r4VABHLl005893;	Fri, 31 May 2013 05:11:17 -0500
Received: from symphony.india.ext.ti.com (unknown [192.168.247.13])	by
	ucmsshproxy.india.ext.ti.com (Postfix) with ESMTP	id 59E50158004;
	Fri, 31 May 2013 15:41:16 +0530 (IST)
Received: from ubuntu-psp-linux.india.ext.ti.com (ubuntu-psp-linux
	[192.168.247.46])	by symphony.india.ext.ti.com
	(8.11.7p1+Sun/8.11.7)	with
	ESMTP id r4VABFR05859;	Fri, 31 May 2013 15:41:15 +0530 (IST)
From: Hebbar Gururaja <gururaja.hebbar@ti.com>
To: <khilman@linaro.org>, <grant.likely@linaro.org>,
	<linus.walleij@linaro.org>, <rob.herring@calxeda.com>
Subject: [PATCH 10/11] video: da8xx-fb: adopt pinctrl support
Date: Fri, 31 May 2013 15:43:10 +0530
Message-ID: <1369995191-20855-11-git-send-email-gururaja.hebbar@ti.com>
X-Mailer: git-send-email 1.7.9.5
In-Reply-To: <1369995191-20855-1-git-send-email-gururaja.hebbar@ti.com>
References: <1369995191-20855-1-git-send-email-gururaja.hebbar@ti.com>
MIME-Version: 1.0
CC: <davinci-linux-open-source@linux.davincidsp.com>,
	<linux@arm.linux.org.uk>, Florian Tobias Schandinat
	<FlorianSchandinat@gmx.de>,
	<devicetree-discuss@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
	<linux-fbdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
X-BeenThere: davinci-linux-open-source@linux.davincidsp.com
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: <davinci-linux-open-source.linux.davincidsp.com>
List-Unsubscribe: 
 <http://linux.davincidsp.com/mailman/options/davinci-linux-open-source>,
	<mailto:davinci-linux-open-source-request@linux.davincidsp.com?subject=unsubscribe>
List-Archive: 
 <http://linux.davincidsp.com/pipermail/davinci-linux-open-source>
List-Post: <mailto:davinci-linux-open-source@linux.davincidsp.com>
List-Help: 
 <mailto:davinci-linux-open-source-request@linux.davincidsp.com?subject=help>
List-Subscribe: 
 <http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source>,
	<mailto:davinci-linux-open-source-request@linux.davincidsp.com?subject=subscribe>
Sender: <davinci-linux-open-source-bounces@linux.davincidsp.com>
Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com

Amend the da8xx-fb controller to optionally take a pin control handle
and set the state of the pins to:

- "default" on boot, resume
- "sleep" on suspend()

By optionally putting the pins into sleep state in the suspend callback
we can accomplish two things.
- One is to minimize current leakage from pins and thus save power,
- second, we can prevent the IP from driving pins output in an
uncontrolled manner, which may happen if the power domain drops the
domain regulator.

If any of the above pin states are missing in dt, a warning message
about the missing state is displayed.
If certain pin-states are not available, to remove this warning message
pass respective state name with null phandler.

Todo:
        - if an idle state is available for pins, add support for it.

Signed-off-by: Hebbar Gururaja <gururaja.hebbar@ti.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: linux-fbdev@vger.kernel.org
---
:100644 100644 0810939... 10c8036... M	drivers/video/da8xx-fb.c
 drivers/video/da8xx-fb.c |   48 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 0810939..10c8036 100644
--- a/drivers/video/da8xx-fb.c
+++ b/drivers/video/da8xx-fb.c
@@ -36,6 +36,7 @@
 #include <linux/slab.h>
 #include <linux/delay.h>
 #include <linux/lcm.h>
+#include <linux/pinctrl/consumer.h>
 #include <video/da8xx-fb.h>
 #include <asm/div64.h>
 
@@ -182,6 +183,11 @@ struct da8xx_fb_par {
 #endif
 	void (*panel_power_ctrl)(int);
 	u32 pseudo_palette[16];
+
+	/* two pin states - default, sleep */
+	struct pinctrl			*pinctrl;
+	struct pinctrl_state		*pins_default;
+	struct pinctrl_state		*pins_sleep;
 };
 
 /* Variable Screen Information */
@@ -1306,6 +1312,36 @@ static int fb_probe(struct platform_device *device)
 	par->lcd_fck_rate = clk_get_rate(fb_clk);
 #endif
 	par->pxl_clk = lcdc_info->pixclock;
+
+	par->pinctrl = devm_pinctrl_get(&device->dev);
+	if (!IS_ERR(par->pinctrl)) {
+		par->pins_default = pinctrl_lookup_state(par->pinctrl,
+							 PINCTRL_STATE_DEFAULT);
+		if (IS_ERR(par->pins_default))
+			dev_dbg(&device->dev, "could not get default pinstate\n");
+		else
+			if (pinctrl_select_state(par->pinctrl,
+						 par->pins_default))
+				dev_err(&device->dev,
+					"could not set default pinstate\n");
+
+		par->pins_sleep = pinctrl_lookup_state(par->pinctrl,
+						       PINCTRL_STATE_SLEEP);
+		if (IS_ERR(par->pins_sleep))
+			dev_dbg(&device->dev, "could not get sleep pinstate\n");
+	} else {
+		/*
+		* Since we continue even when pinctrl node is not found,
+		* Invalidate pins as not available. This is to make sure that
+		* IS_ERR(pins_xxx) results in failure when used.
+		*/
+		par->pins_default = ERR_PTR(-ENODATA);
+		par->pins_sleep = ERR_PTR(-ENODATA);
+
+		dev_dbg(&device->dev, "did not get pins for lcd error: %li\n",
+			PTR_ERR(par->pinctrl));
+	}
+
 	if (fb_pdata->panel_power_ctrl) {
 		par->panel_power_ctrl = fb_pdata->panel_power_ctrl;
 		par->panel_power_ctrl(1);
@@ -1551,6 +1587,12 @@ static int fb_suspend(struct platform_device *dev, pm_message_t state)
 	pm_runtime_put_sync(&dev->dev);
 	console_unlock();
 
+	/* Optionally let pins go into sleep states */
+	if (!IS_ERR(par->pins_sleep))
+		if (pinctrl_select_state(par->pinctrl, par->pins_sleep))
+			dev_err(&dev->dev,
+				"could not set pins to sleep state\n");
+
 	return 0;
 }
 static int fb_resume(struct platform_device *dev)
@@ -1560,6 +1602,12 @@ static int fb_resume(struct platform_device *dev)
 
 	console_lock();
 	pm_runtime_get_sync(&dev->dev);
+
+	/* Optionaly enable pins to be muxed in and configured */
+	if (!IS_ERR(par->pins_default))
+		if (pinctrl_select_state(par->pinctrl, par->pins_default))
+			dev_err(&dev->dev, "could not set default pins\n");
+
 	lcd_context_restore();
 	if (par->blank == FB_BLANK_UNBLANK) {
 		lcd_enable_raster();