From patchwork Tue Sep 10 17:10:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Gardiner X-Patchwork-Id: 2902461 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 390BF9F1BF for ; Tue, 17 Sep 2013 13:03:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 90A0D20378 for ; Tue, 17 Sep 2013 13:03:06 +0000 (UTC) Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14DE52039B for ; Tue, 17 Sep 2013 13:03:01 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id r8HD1oLi028233; Tue, 17 Sep 2013 08:01:50 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r8HD1oug006776; Tue, 17 Sep 2013 08:01:50 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.2.342.3; Tue, 17 Sep 2013 08:01:49 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id r8HD1nlq017603; Tue, 17 Sep 2013 08:01:49 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id A0B9380627; Tue, 17 Sep 2013 08:01:49 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp51.itg.ti.com (dflp51.itg.ti.com [128.247.22.94]) by linux.omap.com (Postfix) with ESMTP id D44B380626 for ; Tue, 10 Sep 2013 12:10:32 -0500 (CDT) Received: from red.ext.ti.com (red.ext.ti.com [192.94.93.37]) by dflp51.itg.ti.com (8.13.7/8.13.8) with ESMTP id r8AHAWok019707 for ; Tue, 10 Sep 2013 12:10:32 -0500 (CDT) Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by red.ext.ti.com (8.13.7/8.13.7) with ESMTP id r8AHAWe0011376 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 10 Sep 2013 12:10:32 -0500 Received: from [216.82.250.99:10229] by server-2.bemta-12.messagelabs.com id 32/5E-24506-8825F225; Tue, 10 Sep 2013 17:10:32 +0000 X-Env-Sender: ben.l.gardiner@gmail.com X-Msg-Ref: server-11.tower-126.messagelabs.com!1378833030!9308663!1 X-Originating-IP: [209.85.128.170] X-SpamReason: No, hits=0.0 required=7.0 tests=ML_RADAR_SPEW_LINKS_14, spamassassin: X-StarScan-Received: X-StarScan-Version: 6.9.12; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24421 invoked from network); 10 Sep 2013 17:10:31 -0000 Received: from mail-ve0-f170.google.com (HELO mail-ve0-f170.google.com) (209.85.128.170) by server-11.tower-126.messagelabs.com with RC4-SHA encrypted SMTP; 10 Sep 2013 17:10:31 -0000 Received: by mail-ve0-f170.google.com with SMTP id c14so5008110vea.1 for ; Tue, 10 Sep 2013 10:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=I2gvaExxKwA2yT+iIYlij0BBnq/jjpn+0Zpmar+YeCE=; b=PP4HK9kLOdcW7lTB7U6zYY63EA4gACVejS9dS+Pf222LMkVE06p8kaJ0wJjvpAcJkB xcmTOrldrLf+fkMXydc3WZT87xgZeHGJtDYxqARxpXSNAuZ36Ak31Ta/XC/vWyyB+ksM H4R3ddulDA10HxH+CFI2W91EHH+sEJKcffGynEFZrZ7fLUibiGFfHEF/2bUaEhhJjuS+ PcaTk8wpYktSlAyt0rlHm1zCAWDaDT/k3D2qVMUXFZgaswHD9/4TL70wbOwwpO3hSJRb WuVfgvktzmbB/Co/w55vBCW0RWYkW8N/okFfxni+vZd1GWqt3ZWswzi4CvQ7qtd+cLYs 5Ntg== X-Received: by 10.52.24.4 with SMTP id q4mr1164640vdf.34.1378833029670; Tue, 10 Sep 2013 10:10:29 -0700 (PDT) Received: from sweetpea.barrettxplore.com ([206.191.47.130]) by mx.google.com with ESMTPSA id jw6sm6301256veb.3.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 10 Sep 2013 10:10:28 -0700 (PDT) From: Ben Gardiner To: , , Subject: [PATCH] spi: spi-davinci: deassert CS on setup() Date: Tue, 10 Sep 2013 13:10:22 -0400 Message-ID: <1378833022-31046-1-git-send-email-ben.l.gardiner@gmail.com> X-Mailer: git-send-email 1.8.1.2 X-Mailman-Approved-At: Tue, 17 Sep 2013 08:01:48 -0500 CC: X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The mmc_spi driver's mmc_cs_off() function states that "chipselect will always be inactive after setup()"; however, the spi-davinci driver's setup() leaves CS state unchanged. Add a call to davinci_spi_chipselect(spi, BITBANG_CS_INACTIVE) to the spi- davinci drivers' setup() function. Signed-off-by: Ben Gardiner --- drivers/spi/spi-davinci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index 707966b..f0f4dbd 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -404,6 +404,7 @@ static int davinci_spi_setup(struct spi_device *spi) (pdata->chip_sel[spi->chip_select] == SPI_INTERN_CS)) set_io_bits(dspi->base + SPIPC0, 1 << spi->chip_select); + davinci_spi_chipselect(spi, BITBANG_CS_INACTIVE); } if (spi->mode & SPI_READY)