From patchwork Sat Nov 2 15:39:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 3130841 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 51F8FBEEB2 for ; Sat, 2 Nov 2013 15:41:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 74CC82027D for ; Sat, 2 Nov 2013 15:41:56 +0000 (UTC) Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94CF320258 for ; Sat, 2 Nov 2013 15:41:55 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id rA2FepAl021018; Sat, 2 Nov 2013 10:40:51 -0500 Received: from DFLE72.ent.ti.com ([128.247.5.109]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id rA2Fep2L016850; Sat, 2 Nov 2013 10:40:51 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.2.342.3; Sat, 2 Nov 2013 10:40:51 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id rA2FenZW020228; Sat, 2 Nov 2013 10:40:49 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id E0B238062E; Sat, 2 Nov 2013 09:40:49 -0600 (CST) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp52.itg.ti.com (dflp52.itg.ti.com [128.247.22.96]) by linux.omap.com (Postfix) with ESMTP id B35E680628 for ; Sat, 2 Nov 2013 09:40:13 -0600 (CST) Received: from neches.ext.ti.com (neches.ext.ti.com [192.91.81.29]) by dflp52.itg.ti.com (8.13.7/8.13.8) with ESMTP id rA2FeCpP014814 for ; Sat, 2 Nov 2013 10:40:12 -0500 (CDT) Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by neches.ext.ti.com (8.13.7/8.13.7) with ESMTP id rA2FeC2E026242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 2 Nov 2013 10:40:12 -0500 Received: from [216.82.253.147:9857] by server-6.bemta-7.messagelabs.com id E3/B2-05834-CDC15725; Sat, 02 Nov 2013 15:40:12 +0000 X-Env-Sender: prabhakar.csengg@gmail.com X-Msg-Ref: server-11.tower-165.messagelabs.com!1383406810!11266016!1 X-Originating-IP: [209.85.220.48] X-SpamReason: No, hits=0.0 required=7.0 tests=ML_RADAR_SPEW_LINKS_14, spamassassin: X-StarScan-Received: X-StarScan-Version: 6.9.12; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8764 invoked from network); 2 Nov 2013 15:40:11 -0000 Received: from mail-pa0-f48.google.com (HELO mail-pa0-f48.google.com) (209.85.220.48) by server-11.tower-165.messagelabs.com with RC4-SHA encrypted SMTP; 2 Nov 2013 15:40:11 -0000 Received: by mail-pa0-f48.google.com with SMTP id kq14so5233867pab.21 for ; Sat, 02 Nov 2013 08:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0Evp7Ay5dgXUJjAGc54iQZxk7mKfX1PlkQ+QRGz47UU=; b=HFt36+8GZu9YzB0w/XY+mqW1YZ8drUIxytOo3Y+j9+DIru6AJO++5yLjMuqKx83z8x G32lQ6+Z5nw3UCECGZDMxKIU+5lukMXGSs8znewRPfq9pR+8K1v5NX10h/JrZDNq8xzc D1IQFabdD4/wICf3dQA4husLm9jSWOMlR1lbZ+DG5kAXl2SnQvYE9Q0mgxWTRkrNUfjq MywUb2/pmJozS31ubq3f6UGrZKf6w0+h/Bsdmv8YElgHeI5QgsXsdfyXgQFETLxpD6Z5 8HlofqAxWdG4nOZhTY1gaG3/NstzaKTGEUG5qKisOOPqQamkvbl7aclPRATKfAE8f2VK Bm4Q== X-Received: by 10.68.225.9 with SMTP id rg9mr8717231pbc.122.1383406810495; Sat, 02 Nov 2013 08:40:10 -0700 (PDT) Received: from localhost.localdomain ([49.200.27.40]) by mx.google.com with ESMTPSA id qp10sm20456849pab.13.2013.11.02.08.40.01 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 02 Nov 2013 08:40:09 -0700 (PDT) From: "Lad, Prabhakar" To: Sekhar Nori , Linus Walleij , Subject: [PATCH v4 2/6] gpio: davinci: remove unnecessary printk Date: Sat, 2 Nov 2013 21:09:31 +0530 Message-ID: <1383406775-14902-3-git-send-email-prabhakar.csenng@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1383406775-14902-1-git-send-email-prabhakar.csenng@gmail.com> References: <1383406775-14902-1-git-send-email-prabhakar.csenng@gmail.com> CC: Mark Rutland , Alex Elder , , Russell King , Pawel Moll , Ian Campbell , Stephen Warren , , , Rob Herring , , Rob Landley , Grant Likely , X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: "Lad, Prabhakar" the devm_*() helper prints error messages in case of errors no need to do the same in the driver. Signed-off-by: Lad, Prabhakar --- drivers/gpio/gpio-davinci.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index 6c90cfb..95c6df1 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -389,11 +389,9 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) } clk = devm_clk_get(dev, "gpio"); - if (IS_ERR(clk)) { - printk(KERN_ERR "Error %ld getting gpio clock?\n", - PTR_ERR(clk)); + if (IS_ERR(clk)) return PTR_ERR(clk); - } + clk_prepare_enable(clk); /*