| Message ID | 1385494815-15740-2-git-send-email-grygorii.strashko@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tuesday 26 November 2013 02:40 PM, Grygorii Strashko wrote: > Since Davinci GPIO driver is moved to support gpiolib it has to use > ARCH_NR_GPIOS (can be configured using CONFIG_ARCH_NR_GPIO Kconfig > option) configuration instead of any mach/platform specific options. > > Hence, replace private DAVINCI_N_GPIO with common ARCH_NR_GPIOS. This is > safe because default value for ARCH_NR_GPIOS=256 and maximum number of > supported GPIOs for Davinci is DAVINCI_N_GPIO=144. > > More over, this is one of steps to re-use Davinci GPIO driver by other > mach/platform. > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- Looks like you just combined the two earlier patches you have posted. Ack applies here as well. regards, Santosh
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index 5bdd9f8..70b5f2f 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -200,8 +200,8 @@ static int davinci_gpio_probe(struct platform_device *pdev) return -EINVAL; } - if (WARN_ON(DAVINCI_N_GPIO < ngpio)) - ngpio = DAVINCI_N_GPIO; + if (WARN_ON(ARCH_NR_GPIOS < ngpio)) + ngpio = ARCH_NR_GPIOS; chips = devm_kzalloc(dev, ngpio * sizeof(struct davinci_gpio_controller),
Since Davinci GPIO driver is moved to support gpiolib it has to use ARCH_NR_GPIOS (can be configured using CONFIG_ARCH_NR_GPIO Kconfig option) configuration instead of any mach/platform specific options. Hence, replace private DAVINCI_N_GPIO with common ARCH_NR_GPIOS. This is safe because default value for ARCH_NR_GPIOS=256 and maximum number of supported GPIOs for Davinci is DAVINCI_N_GPIO=144. More over, this is one of steps to re-use Davinci GPIO driver by other mach/platform. Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- drivers/gpio/gpio-davinci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)