From patchwork Wed Sep 1 20:41:17 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yusuf Caglar AKYUZ X-Patchwork-Id: 147591 Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o81KeOva015980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 1 Sep 2010 20:46:45 GMT Received: from dlep34.itg.ti.com ([157.170.170.115]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id o81KbaBY019506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 1 Sep 2010 15:37:36 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by dlep34.itg.ti.com (8.13.7/8.13.7) with ESMTP id o81KbZdQ021439; Wed, 1 Sep 2010 15:37:36 -0500 (CDT) Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 8DCE780627; Wed, 1 Sep 2010 15:37:35 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp52.itg.ti.com (dflp52.itg.ti.com [128.247.22.96]) by linux.omap.com (Postfix) with ESMTP id 65DDD80626 for ; Wed, 1 Sep 2010 15:37:34 -0500 (CDT) Received: from medina.ext.ti.com (localhost [127.0.0.1]) by dflp52.itg.ti.com (8.13.7/8.13.7) with ESMTP id o81KbYvL021762 for ; Wed, 1 Sep 2010 15:37:34 -0500 (CDT) Received: from psmtp.com (na3sys009amx172.postini.com [74.125.149.98]) by medina.ext.ti.com (8.13.7/8.13.7) with SMTP id o81KbXiw025531 for ; Wed, 1 Sep 2010 15:37:33 -0500 Received: from source ([209.85.215.45]) by na3sys009amx172.postini.com ([74.125.148.10]) with SMTP; Wed, 01 Sep 2010 20:37:33 GMT Received: by ewy27 with SMTP id 27so5121774ewy.4 for ; Wed, 01 Sep 2010 13:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=Vm6nMNUsio8sdpNiOzC+EchrPhM8F8gWPYIbYs9yFY8=; b=RkYcwoXmVlnmMxOPfuGYNbNRv24pXYFVtUcbnuvJ0sgaEZhJDtz7Vrph8b23IqmacQ +ibfeTaTZIp+RO0e224JVYbSxOwwCUs19vB0+OC0CoFU5s8+yh9DVyY0M4CDBOs/LA3/ Ty1U7Pv1HJnQAMDOP1KNFKey4nQRx75sU/aX4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=rqnSotn/9VtSPkXEVmYScI8v4cWLBkWCZdgeToO7FRjvzvKbmi3bMdtK9ZdoyoWdhf QtLIQF0mltk3fG9YOCdG00aI3vgdSCjxf0LrxpNnQORmtImWsTMkA3DK8WjVPAKzmmrZ UQDL6ELLvxNExUSl7ig4aOzJM2E0ISciFiCMI= Received: by 10.213.13.130 with SMTP id c2mr873192eba.77.1283373452211; Wed, 01 Sep 2010 13:37:32 -0700 (PDT) Received: from linux-khzi.localnet ([85.106.136.183]) by mx.google.com with ESMTPS id a48sm16702150eei.1.2010.09.01.13.37.30 (version=SSLv3 cipher=RC4-MD5); Wed, 01 Sep 2010 13:37:31 -0700 (PDT) From: Caglar Akyuz To: "Ambrose, Martin" Subject: Re: [PATCH v3 1/1] DA8XX/OMAP-L1XX: FB: Implement double buffering Date: Wed, 1 Sep 2010 23:41:17 +0300 User-Agent: KMail/1.12.4 (Linux/2.6.31.12-0.1-desktop; KDE/4.3.5; x86_64; ; ) References: <1270504278-15088-1-git-send-email-martin@ti.com> <201009012220.00479.caglarakyuz@gmail.com> In-Reply-To: MIME-Version: 1.0 Message-Id: <201009012341.17458.caglarakyuz@gmail.com> X-pstn-neptune: 0/0/0.00/0 X-pstn-levels: (S:99.90000/99.90000 CV:99.9000 FC:95.5390 LC:95.5390 R:95.9108 P:95.9108 M:97.0282 C:98.6951 ) X-pstn-settings: 2 (0.5000:0.0750) s cv GT3 gt2 gt1 r p m c X-pstn-addresses: from [db-null] Cc: "davinci-linux-open-source@linux.davincidsp.com" X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: davinci-linux-open-source-bounces@linux.davincidsp.com Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com X-Greylist: Sender succeeded STARTTLS authentication, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Wed, 01 Sep 2010 20:46:45 +0000 (UTC) diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c index 0ad6fe4..edb0616 100644 --- a/drivers/video/da8xx-fb.c +++ b/drivers/video/da8xx-fb.c @@ -1020,10 +1020,6 @@ static int __init fb_probe(struct platform_device *device) goto err_release_pl_mem; } - ret = request_irq(par->irq, lcdc_irq_handler, 0, DRIVER_NAME, par); - if (ret) - goto err_release_pl_mem; - /* Initialize par */ da8xx_fb_info->var.bits_per_pixel = lcd_cfg->bpp; @@ -1051,7 +1047,7 @@ static int __init fb_probe(struct platform_device *device) ret = fb_alloc_cmap(&da8xx_fb_info->cmap, PALETTE_SIZE, 0); if (ret) - goto err_free_irq; + goto err_release_pl_mem; da8xx_fb_info->cmap.len = par->palette_sz; /* initialize var_screeninfo */ @@ -1079,8 +1075,13 @@ static int __init fb_probe(struct platform_device *device) goto err_cpu_freq; } #endif + + ret = request_irq(par->irq, lcdc_irq_handler, 0, DRIVER_NAME, par); + if (ret) + goto irq_freq; return 0; +irq_freq: #ifdef CONFIG_CPU_FREQ err_cpu_freq: unregister_framebuffer(da8xx_fb_info); @@ -1089,9 +1090,6 @@ err_cpu_freq: err_dealloc_cmap: fb_dealloc_cmap(&da8xx_fb_info->cmap); -err_free_irq: - free_irq(par->irq, par); - err_release_pl_mem: dma_free_coherent(NULL, PALETTE_SIZE, par->v_palette_base, par->p_palette_base);