From patchwork Sat Oct 9 12:55:54 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Williamson X-Patchwork-Id: 243391 Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o99CvRO0002637 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 9 Oct 2010 12:57:54 GMT Received: from dlep34.itg.ti.com ([157.170.170.115]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id o99Cu1YW015740 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 9 Oct 2010 07:56:01 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by dlep34.itg.ti.com (8.13.7/8.13.7) with ESMTP id o99Cu0ft022596; Sat, 9 Oct 2010 07:56:01 -0500 (CDT) Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 7B11780627; Sat, 9 Oct 2010 07:56:00 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp51.itg.ti.com (dflp51.itg.ti.com [128.247.22.94]) by linux.omap.com (Postfix) with ESMTP id C6E3B80626 for ; Sat, 9 Oct 2010 07:55:58 -0500 (CDT) Received: from medina.ext.ti.com (localhost [127.0.0.1]) by dflp51.itg.ti.com (8.13.7/8.13.7) with ESMTP id o99Ctw10010454 for ; Sat, 9 Oct 2010 07:55:58 -0500 (CDT) Received: from psmtp.com (na3sys009amx212.postini.com [74.125.149.52]) by medina.ext.ti.com (8.13.7/8.13.7) with SMTP id o99CtvUl005308 for ; Sat, 9 Oct 2010 07:55:58 -0500 Received: from source ([209.85.216.173]) by na3sys009amx212.postini.com ([74.125.148.10]) with SMTP; Sat, 09 Oct 2010 05:55:58 PDT Received: by qyk8 with SMTP id 8so990477qyk.4 for ; Sat, 09 Oct 2010 05:55:57 -0700 (PDT) Received: by 10.229.214.73 with SMTP id gz9mr3125638qcb.167.1286628957057; Sat, 09 Oct 2010 05:55:57 -0700 (PDT) Received: from [192.168.1.2] (pool-96-238-148-192.syrcny.fios.verizon.net [96.238.148.192]) by mx.google.com with ESMTPS id l13sm3637628qck.43.2010.10.09.05.55.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 09 Oct 2010 05:55:55 -0700 (PDT) Message-ID: <4CB0665A.3000309@criticallink.com> Date: Sat, 09 Oct 2010 08:55:54 -0400 From: Michael Williamson User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100915 Thunderbird/3.0.8 MIME-Version: 1.0 To: "Nori, Sekhar" Subject: Re: [PATCH v5 1/1] davinci: spi: replace existing driver References: <1280355490-11878-1-git-send-email-bniebuhr@efjohnson.com> <4C8EB795.1080607@criticallink.com> <201009140904.59555.caglarakyuz@gmail.com> <4C8F7460.6050006@criticallink.com> <4C94B9BD.4010606@criticallink.com> <4C979D1D.1070707@criticallink.com> <4CAF6F86.40201@criticallink.com> In-Reply-To: <4CAF6F86.40201@criticallink.com> X-pstn-neptune: 0/0/0.00/0 X-pstn-levels: (S:99.90000/99.90000 CV:99.9000 FC:95.5390 LC:95.5390 R:95.9108 P:95.9108 M:97.0282 C:98.6951 ) X-pstn-settings: 2 (0.5000:0.0750) s cv GT3 gt2 gt1 r p m c X-pstn-addresses: from [db-null] Cc: Grant Likely , "spi-devel-general@lists.sourceforge.net" , "davinci-linux-open-source@linux.davincidsp.com" , Brian Niebuhr X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: davinci-linux-open-source-bounces@linux.davincidsp.com Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com X-Greylist: Sender succeeded STARTTLS authentication, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Sat, 09 Oct 2010 12:57:54 +0000 (UTC) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index 662ebbe..8206df1 100755 --- a/drivers/spi/davinci_spi.c +++ b/drivers/spi/davinci_spi.c @@ -632,13 +632,11 @@ static int davinci_spi_bufs(struct spi_device *spi, struct spi_transfer *t) * source address never increments. */ - if (t->rx_buf) { + rx_buf_count = davinci_spi->rcount; + if (t->rx_buf) rx_buf = t->rx_buf; - rx_buf_count = davinci_spi->rcount; - } else { + else rx_buf = davinci_spi->rx_tmp_buf; - rx_buf_count = sizeof(davinci_spi->rx_tmp_buf); - } t->rx_dma = dma_map_single(&spi->dev, rx_buf, rx_buf_count, DMA_FROM_DEVICE);