From patchwork Sun Jul 29 21:14:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Tobias Schandinat X-Patchwork-Id: 1252951 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by patchwork1.kernel.org (Postfix) with ESMTP id E89253FC33 for ; Sun, 29 Jul 2012 21:16:19 +0000 (UTC) Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id q6TLEgj7022487; Sun, 29 Jul 2012 16:14:42 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id q6TLEg9j014088; Sun, 29 Jul 2012 16:14:42 -0500 Received: from dlelxv23.itg.ti.com (172.17.1.198) by dfle72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.1.323.3; Sun, 29 Jul 2012 16:14:41 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlelxv23.itg.ti.com (8.13.8/8.13.8) with ESMTP id q6TLEfkN004430; Sun, 29 Jul 2012 16:14:41 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id D75B680627; Sun, 29 Jul 2012 16:14:40 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp51.itg.ti.com (dflp51.itg.ti.com [128.247.22.94]) by linux.omap.com (Postfix) with ESMTP id 7B1B080626 for ; Sun, 29 Jul 2012 16:14:38 -0500 (CDT) Received: from neches.ext.ti.com (neches.ext.ti.com [192.91.81.29]) by dflp51.itg.ti.com (8.13.7/8.13.8) with ESMTP id q6TLEcTB011437 for ; Sun, 29 Jul 2012 16:14:38 -0500 (CDT) Received: from psmtp.com (na3sys009amx184.postini.com [74.125.149.165]) by neches.ext.ti.com (8.13.7/8.13.7) with SMTP id q6TLEb53019751 for ; Sun, 29 Jul 2012 16:14:37 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]) by na3sys009amx184.postini.com ([74.125.148.10]) with SMTP; Sun, 29 Jul 2012 21:14:37 GMT Received: (qmail invoked by alias); 29 Jul 2012 21:14:35 -0000 Received: from dslb-092-074-255-101.pools.arcor-ip.net (EHLO [192.168.0.9]) [92.74.255.101] by mail.gmx.net (mp027) with SMTP; 29 Jul 2012 23:14:35 +0200 X-Authenticated: #10250065 X-Provags-ID: V01U2FsdGVkX1/Q61d/FhPQkxJ5/8mDXA+WRPvVM5tYqpSJaR0sYy RB5/IbiakjeIPw Message-ID: <5015A7B9.90200@gmx.de> Date: Sun, 29 Jul 2012 21:14:33 +0000 From: Florian Tobias Schandinat User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120613 Icedove/3.0.11 MIME-Version: 1.0 To: "Manjunathappa, Prakash" Subject: Re: [PATCH] video: da8xx-fb: do clock reset of revision 2 LCDC before enabling References: <1342799471-10729-1-git-send-email-prakash.pm@ti.com> In-Reply-To: <1342799471-10729-1-git-send-email-prakash.pm@ti.com> X-Y-GMX-Trusted: 0 X-pstn-neptune: 0/0/0.00/0 X-pstn-levels: (S:99.90000/99.90000 CV:99.9000 FC:95.5390 LC:95.5390 R:95.9108 P:95.9108 M:97.0282 C:98.6951 ) X-pstn-dkim: 0 skipped:not-enabled X-pstn-settings: 2 (0.5000:0.5000) s cv gt3 gt2 gt1 r p m c X-pstn-addresses: from [82/3] CC: , X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com On 07/20/2012 03:51 PM, Manjunathappa, Prakash wrote: > As in specification software reset should be applied for several > cycles before bringing it out of reset. Without this patch > particularly during suspend and resume clock reset is not guaranteed > to happen. > > Signed-off-by: Manjunathappa, Prakash Applied. But it would be better if you made the patch dependencies clear, as I didn't consider some of your patches mature enough for this merge window. Now I had to figure out why my final build failed and applied the patch below. Best regards, Florian Tobias Schandinat --- commit a0239073fd75489d25575cf3aaf71ab55b416020 Author: Florian Tobias Schandinat Date: Sun Jul 29 16:47:40 2012 +0000 da8xx-fb: fix compile issue due to missing include Signed-off-by: Florian Tobias Schandinat > --- > drivers/video/da8xx-fb.c | 12 ++++++++---- > 1 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c > index 3d2d0d1..4440292 100644 > --- a/drivers/video/da8xx-fb.c > +++ b/drivers/video/da8xx-fb.c > @@ -262,10 +262,18 @@ static inline void lcd_enable_raster(void) > { > u32 reg; > > + /* Put LCDC in reset for several cycles */ > + if (lcd_revision == LCD_VERSION_2) > + /* Write 1 to reset LCDC */ > + lcdc_write(LCD_CLK_MAIN_RESET, LCD_CLK_RESET_REG); > + mdelay(1); > + > /* Bring LCDC out of reset */ > if (lcd_revision == LCD_VERSION_2) > lcdc_write(0, LCD_CLK_RESET_REG); > + mdelay(1); > > + /* Above reset sequence doesnot reset register context */ > reg = lcdc_read(LCD_RASTER_CTRL_REG); > if (!(reg & LCD_RASTER_ENABLE)) > lcdc_write(reg | LCD_RASTER_ENABLE, LCD_RASTER_CTRL_REG); > @@ -279,10 +287,6 @@ static inline void lcd_disable_raster(void) > reg = lcdc_read(LCD_RASTER_CTRL_REG); > if (reg & LCD_RASTER_ENABLE) > lcdc_write(reg & ~LCD_RASTER_ENABLE, LCD_RASTER_CTRL_REG); > - > - if (lcd_revision == LCD_VERSION_2) > - /* Write 1 to reset LCDC */ > - lcdc_write(LCD_CLK_MAIN_RESET, LCD_CLK_RESET_REG); > } > > static void lcd_blit(int load_mode, struct da8xx_fb_par *par) diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c index ca9943a..7ae9d53 100644 --- a/drivers/video/da8xx-fb.c +++ b/drivers/video/da8xx-fb.c @@ -32,6 +32,7 @@ #include #include #include +#include #include #include