From patchwork Fri Mar 15 14:17:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sekhar Nori X-Patchwork-Id: 2278121 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by patchwork2.kernel.org (Postfix) with ESMTP id B1456DF24C for ; Fri, 15 Mar 2013 14:18:10 +0000 (UTC) Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id r2FEI9PZ013570 for ; Fri, 15 Mar 2013 09:18:09 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id r2FEI9Rg023910 for ; Fri, 15 Mar 2013 09:18:09 -0500 Received: from dlelxv24.itg.ti.com (172.17.1.199) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.2.342.3; Fri, 15 Mar 2013 09:18:08 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlelxv24.itg.ti.com (8.13.8/8.13.8) with ESMTP id r2FEI8ZW010185 for ; Fri, 15 Mar 2013 09:18:08 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id DF3178062D for ; Fri, 15 Mar 2013 08:18:08 -0600 (CST) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dbdp20.itg.ti.com (dbdp20.itg.ti.com [172.24.170.38]) by linux.omap.com (Postfix) with ESMTP id F0F9B80626 for ; Fri, 15 Mar 2013 08:18:00 -0600 (CST) Received: from DBDE70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id r2FEHw4h001319; Fri, 15 Mar 2013 19:47:58 +0530 (IST) Received: from dbdp32.itg.ti.com (172.24.170.251) by dbde70.ent.ti.com (172.24.170.148) with Microsoft SMTP Server id 14.1.323.3; Fri, 15 Mar 2013 19:47:58 +0530 Received: from [172.24.81.195] (smtpvbd.itg.ti.com [172.24.170.250]) by dbdp32.itg.ti.com (8.13.8/8.13.8) with ESMTP id r2FEHf3S001050; Fri, 15 Mar 2013 19:47:47 +0530 Message-ID: <51432D7F.4090001@ti.com> Date: Fri, 15 Mar 2013 19:47:35 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Prabhakar Lad Subject: Re: DaVinci platform unable to boot via NFS References: In-Reply-To: CC: , dlos , , Daniel Mack , Mark Jackson , LAK X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces+patchwork-davinci=patchwork.kernel.org@linux.davincidsp.com Prabhakar, On 3/15/2013 7:11 PM, Prabhakar Lad wrote: > Hi Mugunthan, > > With 3.9 release I am not able to boot any davinci board via nfs, finally > digging Into I found that there were recent changes for Ethernet davinci. > Finally I reverting this to some safe commit I was able to boot via nfs. > I reverted back as following:- > git checkout f9a8f83b04e0c362a2fc660dbad980d24af209fc drivers/net/ethernet/ti/ > > Can you please take a look at and fix it. > > Cheers, > --Prabhakar Lad > http://in.linkedin.com/pub/prabhakar-lad/19/92b/955 > A similar bug was reported on cpsw and the following patch from Daniel seems to have helped. https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=d35162f89b8f00537d7b240b76d2d0e8b8d29aa0 I made a similar fix for davinci_emac.c and the resulting diff is below (not tested or built). Can you please check if this helps in DaVinci case? Thanks, Sekhar ----8<---- diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c index 52c0536..ae1b77a 100644 --- a/drivers/net/ethernet/ti/davinci_emac.c +++ b/drivers/net/ethernet/ti/davinci_emac.c @@ -1102,7 +1102,7 @@ static int emac_dev_xmit(struct sk_buff *skb, struct net_device *ndev) /* If there is no more tx desc left free then we need to * tell the kernel to stop sending us tx frames. */ - if (unlikely(cpdma_check_free_tx_desc(priv->txchan))) + if (unlikely(!cpdma_check_free_tx_desc(priv->txchan))) netif_stop_queue(ndev); return NETDEV_TX_OK;