From patchwork Tue Mar 1 13:37:40 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Subhasish Ghosh X-Patchwork-Id: 599151 Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p21DciIk026463 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 1 Mar 2011 13:39:05 GMT Received: from dlep33.itg.ti.com ([157.170.170.112]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id p21DaWrb006240 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 1 Mar 2011 07:36:34 -0600 Received: from linux.omap.com (localhost [127.0.0.1]) by dlep33.itg.ti.com (8.13.7/8.13.7) with ESMTP id p21DaVps009852; Tue, 1 Mar 2011 07:36:31 -0600 (CST) Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 28C6880627; Tue, 1 Mar 2011 07:36:31 -0600 (CST) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp53.itg.ti.com (dflp53.itg.ti.com [128.247.5.6]) by linux.omap.com (Postfix) with ESMTP id 840E480626 for ; Tue, 1 Mar 2011 07:36:29 -0600 (CST) Received: from red.ext.ti.com (localhost [127.0.0.1]) by dflp53.itg.ti.com (8.13.8/8.13.8) with ESMTP id p21DaTMA016840 for ; Tue, 1 Mar 2011 07:36:29 -0600 (CST) Received: from psmtp.com (na3sys009amx194.postini.com [74.125.149.175]) by red.ext.ti.com (8.13.7/8.13.7) with SMTP id p21DaSOd020355 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 1 Mar 2011 07:36:28 -0600 Received: from source ([209.85.220.173]) (using TLSv1) by na3sys009amx194.postini.com ([74.125.148.10]) with SMTP; Tue, 01 Mar 2011 13:36:28 GMT Received: by vxb41 with SMTP id 41so4525819vxb.4 for ; Tue, 01 Mar 2011 05:36:27 -0800 (PST) Received: by 10.52.71.148 with SMTP id v20mr4510617vdu.268.1298986571195; Tue, 01 Mar 2011 05:36:11 -0800 (PST) Received: from subhasishg ([122.166.13.232]) by mx.google.com with ESMTPS id y15sm2183151vch.5.2011.03.01.05.36.05 (version=SSLv3 cipher=OTHER); Tue, 01 Mar 2011 05:36:09 -0800 (PST) Message-ID: <99CE1730AA2F4F2F91AFA71BD75FDC41@subhasishg> From: "Subhasish Ghosh" To: "Alan Cox" References: <1297435892-28278-1-git-send-email-subhasish@mistralsolutions.com><1297435892-28278-14-git-send-email-subhasish@mistralsolutions.com><20110211162814.6ff274f1@lxorguk.ukuu.org.uk> <20110222111103.5d0dd0a7@lxorguk.ukuu.org.uk> In-Reply-To: <20110222111103.5d0dd0a7@lxorguk.ukuu.org.uk> Subject: Re: [PATCH v2 13/13] tty: pruss SUART driver Date: Tue, 1 Mar 2011 19:07:40 +0530 Organization: Mistral Solutions MIME-Version: 1.0 X-Priority: 3 X-MSMail-Priority: Normal Importance: Normal X-Mailer: Microsoft Windows Live Mail 14.0.8117.416 X-MimeOLE: Produced By Microsoft MimeOLE V14.0.8117.416 X-pstn-neptune: 0/0/0.00/0 X-pstn-levels: (S:99.90000/99.90000 CV:99.9000 FC:95.5390 LC:95.5390 R:95.9108 P:95.9108 M:97.0282 C:98.6951 ) X-pstn-settings: 2 (0.5000:0.0750) s cv GT3 gt2 gt1 r p m c X-pstn-addresses: from [db-null] Cc: sachi@mistralsolutions.com, davinci-linux-open-source@linux.davincidsp.com, Stalin Srinivasan , Greg Kroah-Hartman , open list , m-watkins@ti.com, linux-arm-kernel@lists.infradead.org X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: davinci-linux-open-source-bounces@linux.davincidsp.com Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com X-Greylist: Sender succeeded STARTTLS authentication, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 01 Mar 2011 13:39:05 +0000 (UTC) ================================================================================== --- a/drivers/tty/serial/da8xx_pruss/pruss_suart.c +++ b/drivers/tty/serial/da8xx_pruss/pruss_suart.c @@ -170,8 +170,9 @@ static void omapl_pru_rx_chars(struct omapl_pru_suart *soft_uart, u32 uart_no) s8 flags = TTY_NORMAL; u16 rx_status, data_len = SUART_FIFO_LEN; u32 data_len_read; - u8 suart_data[SUART_FIFO_LEN + 1]; + u8 *suart_data = NULL; s32 i = 0; + s32 alloc_len = 0; if (!(suart_get_duplex(soft_uart, uart_no) & ePRU_SUART_HALF_RX))