From patchwork Tue Feb 22 10:26:41 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Subhasish Ghosh X-Patchwork-Id: 580051 Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p1MARlTF014042 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 22 Feb 2011 10:28:08 GMT Received: from dlep34.itg.ti.com ([157.170.170.115]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id p1MAPhBv027029 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Feb 2011 04:25:43 -0600 Received: from linux.omap.com (localhost [127.0.0.1]) by dlep34.itg.ti.com (8.13.7/8.13.7) with ESMTP id p1MAPfNK009469; Tue, 22 Feb 2011 04:25:41 -0600 (CST) Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 4B00F80627; Tue, 22 Feb 2011 04:25:41 -0600 (CST) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp52.itg.ti.com (dflp52.itg.ti.com [128.247.22.96]) by linux.omap.com (Postfix) with ESMTP id A755780626 for ; Tue, 22 Feb 2011 04:25:39 -0600 (CST) Received: from medina.ext.ti.com (localhost [127.0.0.1]) by dflp52.itg.ti.com (8.13.7/8.13.7) with ESMTP id p1MAPdMa005492 for ; Tue, 22 Feb 2011 04:25:39 -0600 (CST) Received: from psmtp.com (na3sys009amx218.postini.com [74.125.149.58]) by medina.ext.ti.com (8.13.7/8.13.7) with SMTP id p1MAPb1L000617 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 22 Feb 2011 04:25:37 -0600 Received: from source ([220.227.112.130]) (using TLSv1) by na3sys009amx218.postini.com ([74.125.148.10]) with SMTP; Tue, 22 Feb 2011 02:25:38 PST Received: from subhasishg by mistralsolutions.com (MDaemon PRO v11.0.2) with ESMTP id md50004047483.msg for ; Tue, 22 Feb 2011 15:56:47 +0530 X-Spam-Processed: mistralsolutions.com, Tue, 22 Feb 2011 15:56:47 +0530 (not processed: spam filter heuristic analysis disabled) X-Authenticated-Sender: subhasish@mistralsolutions.com X-MDRemoteIP: 192.168.13.21 X-Return-Path: subhasish@mistralsolutions.com X-Envelope-From: subhasish@mistralsolutions.com X-MDaemon-Deliver-To: davinci-linux-open-source@linux.davincidsp.com Message-ID: From: "Subhasish" To: "Alan Cox" References: <1297435892-28278-1-git-send-email-subhasish@mistralsolutions.com><1297435892-28278-14-git-send-email-subhasish@mistralsolutions.com> <20110211162814.6ff274f1@lxorguk.ukuu.org.uk> In-Reply-To: <20110211162814.6ff274f1@lxorguk.ukuu.org.uk> Subject: Re: [PATCH v2 13/13] tty: pruss SUART driver Date: Tue, 22 Feb 2011 15:56:41 +0530 MIME-Version: 1.0 X-Priority: 3 X-MSMail-Priority: Normal Importance: Normal X-Mailer: Microsoft Windows Live Mail 14.0.8117.416 X-MimeOLE: Produced By Microsoft MimeOLE V14.0.8117.416 X-pstn-neptune: 0/0/0.00/0 X-pstn-levels: (S:99.90000/99.90000 CV:99.9000 FC:95.5390 LC:95.5390 R:95.9108 P:95.9108 M:97.0282 C:98.6951 ) X-pstn-settings: 2 (0.5000:0.5000) s cv gt3 gt2 gt1 r p m c X-pstn-addresses: from [db-null] Cc: sachi@mistralsolutions.com, davinci-linux-open-source@linux.davincidsp.com, Stalin Srinivasan , Greg Kroah-Hartman , open list , m-watkins@ti.com, linux-arm-kernel@lists.infradead.org X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: davinci-linux-open-source-bounces@linux.davincidsp.com Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com X-Greylist: Sender succeeded STARTTLS authentication, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 22 Feb 2011 10:28:08 +0000 (UTC) ================================================================================== --- a/drivers/tty/serial/da8xx_pruss/pruss_suart.c +++ b/drivers/tty/serial/da8xx_pruss/pruss_suart.c @@ -170,8 +170,9 @@ static void omapl_pru_rx_chars(struct omapl_pru_suart *soft_uart, u32 uart_no) s8 flags = TTY_NORMAL; u16 rx_status, data_len = SUART_FIFO_LEN; u32 data_len_read; - u8 suart_data[SUART_FIFO_LEN + 1]; + u8 *suart_data = NULL; s32 i = 0; + s32 alloc_len = 0; if (!(suart_get_duplex(soft_uart, uart_no) & ePRU_SUART_HALF_RX))