From patchwork Mon Mar 31 17:24:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 3916981 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 517F29F2B6 for ; Mon, 31 Mar 2014 17:25:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3F1B62037B for ; Mon, 31 Mar 2014 17:25:49 +0000 (UTC) Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7971D20380 for ; Mon, 31 Mar 2014 17:25:46 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id s2VHPjYR030880 for ; Mon, 31 Mar 2014 12:25:45 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s2VHPj49028384 for ; Mon, 31 Mar 2014 12:25:45 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Mon, 31 Mar 2014 12:25:45 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s2VHPjoP020393 for ; Mon, 31 Mar 2014 12:25:45 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 34DAA8062A for ; Mon, 31 Mar 2014 11:25:45 -0600 (CST) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflxv17.itg.ti.com (dflxv17.itg.ti.com [128.247.5.93]) by linux.omap.com (Postfix) with ESMTP id E4BD280626 for ; Mon, 31 Mar 2014 11:24:47 -0600 (CST) Received: from medina.ext.ti.com (medina.ext.ti.com [192.91.81.31]) by dflxv17.itg.ti.com (8.14.3/8.13.8) with ESMTP id s2VHOlVD022902 for ; Mon, 31 Mar 2014 12:24:47 -0500 Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by medina.ext.ti.com (8.13.7/8.13.7) with ESMTP id s2VHOlhA026401 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 31 Mar 2014 12:24:47 -0500 Received: from [216.82.250.83:21720] by server-13.bemta-12.messagelabs.com id FC/CE-28941-FD4A9335; Mon, 31 Mar 2014 17:24:47 +0000 X-Env-Sender: prabhakar.csengg@gmail.com X-Msg-Ref: server-7.tower-120.messagelabs.com!1396286685!3897627!1 X-Originating-IP: [209.85.128.174] X-SpamReason: No, hits=0.3 required=7.0 tests=ML_RADAR_SPEW_LINKS_14, RCVD_BY_IP,spamassassin: X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 18910 invoked from network); 31 Mar 2014 17:24:46 -0000 Received: from mail-ve0-f174.google.com (HELO mail-ve0-f174.google.com) (209.85.128.174) by server-7.tower-120.messagelabs.com with RC4-SHA encrypted SMTP; 31 Mar 2014 17:24:46 -0000 Received: by mail-ve0-f174.google.com with SMTP id oz11so8465916veb.33 for ; Mon, 31 Mar 2014 10:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=wR7pbEVV0SDK3qz8NeNpXUXrn2MrMUPAOzQCcEjJwws=; b=tqBSika1g+Ui4cc0IktuHL4tV4RRVnMxMX+JMBSm8fujnqOA4mcOf8DLi0dpjffF+7 tKn+B4Tpa8dvPmF/jhtN50lOAxHR0/4SnV0LraVkuEG5LFESjbocyDqddqpXaVBBnpbI msTad2goKYgAIUgEw/cc2V0waqWQh8C61+SuJkyDcchvjxoNwObD9I2JlDPE1qWNDD14 xV5F5BtzRiOC8g6vEn3YRXSU6A4AmnWg+5kVCUxbgfsrBtRcjos28q8txEoA5/bX96oc 3sDWkEKElvQkimDjAxTpc82+UdBpwVWAnIHZ2YwvFHqfiVxZjuQtjvqCsbxzfB9i1yWY +Jfw== X-Received: by 10.220.198.197 with SMTP id ep5mr2641104vcb.21.1396286684754; Mon, 31 Mar 2014 10:24:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.221.31.73 with HTTP; Mon, 31 Mar 2014 10:24:14 -0700 (PDT) In-Reply-To: <5339840D.9000702@xs4all.nl> References: <1396277573-9513-1-git-send-email-prabhakar.csengg@gmail.com> <1396277573-9513-2-git-send-email-prabhakar.csengg@gmail.com> <5339840D.9000702@xs4all.nl> From: Prabhakar Lad Date: Mon, 31 Mar 2014 22:54:14 +0530 Message-ID: Subject: Re: [PATCH 1/2] media: davinci: vpif capture: upgrade the driver with v4l offerings To: Hans Verkuil CC: DLOS , Mauro Carvalho Chehab , Hans Verkuil , LKML , LMML X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces+patchwork-davinci=patchwork.kernel.org@linux.davincidsp.com X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Hans, On Mon, Mar 31, 2014 at 8:34 PM, Hans Verkuil wrote: > Hi Prabhakar, > > This looks really nice! > Writing a video driver has become really easy with almost 90% of work done by v4l core itself :) > I'll do a full review on Friday, but in the meantime can you post the output OK. > of 'v4l2-compliance -s' using the latest v4l2-compliance version? I've made > some commits today, so you need to do a git pull of v4l-utils.git. > I had compilation failures for v4l2-compliance following is the patch fixing that, (I am facing some issues in cross compilation once done I'll post the o/p of it) --------------X------------X------------------- >From 14029f4ca57be5f2b0ec053d375655ca5a60f698 Mon Sep 17 00:00:00 2001 From: "Lad, Prabhakar" Date: Mon, 31 Mar 2014 22:24:33 +0530 Subject: [PATCH] v4l-utils: v4l-compliance: fix compilation this patch fixes following build error, In file included from v4l2-compliance.h:31, from v4l2-compliance.cpp:37: ./cv4l-helpers.h:9: error: a class-key must be used when declaring a friend ./cv4l-helpers.h:9: error: friend declaration does not name a class or function ./cv4l-helpers.h: In member function 'int cv4l_buffer::querybuf(const cv4l_queue&, unsigned int)': ./cv4l-helpers.h:103: error: 'v4l_fd* cv4l_queue::fd' is protected ./cv4l-helpers.h:213: error: within this context ./cv4l-helpers.h: In member function 'int cv4l_buffer::dqbuf(const cv4l_queue&)': ./cv4l-helpers.h:103: error: 'v4l_fd* cv4l_queue::fd' is protected ./cv4l-helpers.h:221: error: within this context ./cv4l-helpers.h: In member function 'int cv4l_buffer::qbuf(const cv4l_queue&)': ./cv4l-helpers.h:103: error: 'v4l_fd* cv4l_queue::fd' is protected ./cv4l-helpers.h:229: error: within this context ./cv4l-helpers.h: In member function 'int cv4l_buffer::prepare_buf(const cv4l_queue&)': ./cv4l-helpers.h:103: error: 'v4l_fd* cv4l_queue::fd' is protected ./cv4l-helpers.h:237: error: within this context v4l2-compliance.cpp: In function 'void v4l_fd_test_init(v4l_fd*, int)': v4l2-compliance.cpp:132: error: invalid conversion from 'void* (*)(void*, size_t, int, int, int, int64_t)' to 'void* (*)(void*, size_t, int, int, int, off_t)' Signed-off-by: Lad, Prabhakar --- utils/v4l2-compliance/cv4l-helpers.h | 2 +- utils/v4l2-compliance/v4l2-compliance.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/v4l2-compliance/cv4l-helpers.h b/utils/v4l2-compliance/cv4l-helpers.h index 2423ef9..e2729a6 100644 --- a/utils/v4l2-compliance/cv4l-helpers.h +++ b/utils/v4l2-compliance/cv4l-helpers.h @@ -6,7 +6,7 @@ class cv4l_buffer; class cv4l_queue : v4l_queue { - friend cv4l_buffer; + friend class cv4l_buffer; public: cv4l_queue(v4l_fd *_fd, unsigned type = V4L2_BUF_TYPE_VIDEO_CAPTURE, unsigned memory = V4L2_MEMORY_MMAP) diff --git a/utils/v4l2-compliance/v4l2-compliance.h b/utils/v4l2-compliance/v4l2-compliance.h index f2f7072..b6d4dae 100644 --- a/utils/v4l2-compliance/v4l2-compliance.h +++ b/utils/v4l2-compliance/v4l2-compliance.h @@ -137,7 +137,7 @@ static inline int test_ioctl(int fd, unsigned long cmd, ...) } static inline void *test_mmap(void *start, size_t length, int prot, int flags, - int fd, int64_t offset) + int fd, off_t offset) { return wrapper ? v4l2_mmap(start, length, prot, flags, fd, offset) : mmap(start, length, prot, flags, fd, offset);