From patchwork Thu May 9 17:28:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jose Pablo Carballo X-Patchwork-Id: 2544851 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by patchwork2.kernel.org (Postfix) with ESMTP id 2D7E1DF24C for ; Thu, 9 May 2013 17:29:53 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id r49HSQOl001785; Thu, 9 May 2013 12:28:26 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r49HSQKp023235; Thu, 9 May 2013 12:28:26 -0500 Received: from dlelxv24.itg.ti.com (172.17.1.199) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.2.342.3; Thu, 9 May 2013 12:28:23 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlelxv24.itg.ti.com (8.13.8/8.13.8) with ESMTP id r49HSNWV000997; Thu, 9 May 2013 12:28:23 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 906EA80627; Thu, 9 May 2013 12:28:22 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp51.itg.ti.com (dflp51.itg.ti.com [128.247.22.94]) by linux.omap.com (Postfix) with ESMTP id 030C480626 for ; Thu, 9 May 2013 12:28:21 -0500 (CDT) Received: from neches.ext.ti.com (neches.ext.ti.com [192.91.81.29]) by dflp51.itg.ti.com (8.13.7/8.13.8) with ESMTP id r49HSKp4028785 for ; Thu, 9 May 2013 12:28:20 -0500 (CDT) Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by neches.ext.ti.com (8.13.7/8.13.7) with ESMTP id r49HSKYO016828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 May 2013 12:28:20 -0500 Received: from [216.82.242.131:31457] by server-5.bemta-8.messagelabs.com id 31/A1-07470-4BCDB815; Thu, 09 May 2013 17:28:20 +0000 X-Env-Sender: jose.carballo@ridgerun.com X-Msg-Ref: server-13.tower-76.messagelabs.com!1368120498!30969372!1 X-Originating-IP: [209.85.214.174] X-SpamReason: No, hits=0.4 required=7.0 tests=HTML_50_60,HTML_MESSAGE, RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.8.6.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7757 invoked from network); 9 May 2013 17:28:18 -0000 Received: from mail-ob0-f174.google.com (HELO mail-ob0-f174.google.com) (209.85.214.174) by server-13.tower-76.messagelabs.com with RC4-SHA encrypted SMTP; 9 May 2013 17:28:18 -0000 Received: by mail-ob0-f174.google.com with SMTP id dn14so3199867obc.19 for ; Thu, 09 May 2013 10:28:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:x-originating-ip:date:message-id:subject :from:to:content-type:x-gm-message-state; bh=gzTnKSZ8CfkcB8bO/zIUMyLGUSyC4ehAWMhye2tSCNM=; b=MOLK9QpNtKHdcdMWZP2lcR4tbUvUD5jThxe67MLeVZFqXpYjqbZo6m62yljPMOmRZD 9F5H3NXzq+uPdACf/Se3X7ZYDs8ioo6vnBj/VWyeFgoe1bCxCEfCd6Ns14/bgpbEUENU WmwcwbfznyixYVrfPNAVRFswJ0/Glefwi8L1Y9EsEZyrTLWRT48dbIT8ipgFAhU7CLjg THC55ZWUgcu2/U29sa2y5Uxj3bEJRVXJ3NCBRz9v+l0p7BleInWO861gj3SU7xN4k8QC Cgjy4jbZsUWuwh6G2LALl8V+2ceNnOTvmKKqbSBoQ0oqq6qafcYuwTXmo/k0VnIE7HT3 0xGQ== MIME-Version: 1.0 X-Received: by 10.182.97.168 with SMTP id eb8mr4855976obb.89.1368120497904; Thu, 09 May 2013 10:28:17 -0700 (PDT) Received: by 10.182.101.164 with HTTP; Thu, 9 May 2013 10:28:17 -0700 (PDT) X-Originating-IP: [181.193.1.26] Date: Thu, 9 May 2013 11:28:17 -0600 Message-ID: Subject: Patch for vpfe_probe() From: Jose Pablo Carballo To: X-Gm-Message-State: ALoCoQnLZ7cEQLTDe+FzF3CXgAmJCyvnHDQGXNMDJNvFQorA+FFJ/mCBuMwBG/GCwVlINSDuHGIa X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com Hi, On file drivers/media/platform/davinci/vpfe_capture.c, function vpfe_probe(): The check NULL == ccdc_cfg takes the function to probe_free_lock on error, which unlocks the mutex that has not been previously locked. JP diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c index 28d019d..1d9a12d 100644 --- a/drivers/media/platform/davinci/vpfe_capture.c +++ b/drivers/media/platform/davinci/vpfe_capture.c @@ -1866,6 +1866,8 @@ static int vpfe_probe(struct platform_device *pdev) goto probe_free_dev_mem; } + mutex_lock(&ccdc_lock); + /* Allocate memory for ccdc configuration */ ccdc_cfg = kmalloc(sizeof(struct ccdc_config), GFP_KERNEL); if (NULL == ccdc_cfg) { @@ -1874,8 +1876,6 @@ static int vpfe_probe(struct platform_device *pdev) goto probe_free_lock; } - mutex_lock(&ccdc_lock); - strncpy(ccdc_cfg->name, vpfe_cfg->ccdc, 32); /* Get VINT0 irq resource */ res1 = platform_get_resource(pdev, IORESOURCE_IRQ, 0);