| Message ID | CAPgLHd-0+fYLMh+Ff+cgewBPy1itjp-EtbAjzs5UrJsqrY3aNg@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Wei, Thanks for the patch. On Fri, Aug 23, 2013 at 8:30 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fix to return -ENODEV in the subdevice register error handling > case instead of 0, as done elsewhere in this function. > > Introduced by commit 873229e4fdf34196aa5d707957c59ba54c25eaba > ([media] media: davinci: vpif: capture: add V4L2-async support) > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> Regards, --Prabhakar Lad
Hi Wei, I retract my Ack. On Fri, Aug 23, 2013 at 8:30 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fix to return -ENODEV in the subdevice register error handling > case instead of 0, as done elsewhere in this function. > > Introduced by commit 873229e4fdf34196aa5d707957c59ba54c25eaba > ([media] media: davinci: vpif: capture: add V4L2-async support) > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > drivers/media/platform/davinci/vpif_capture.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c > index 7fbde6d..e4b6a26 100644 > --- a/drivers/media/platform/davinci/vpif_capture.c > +++ b/drivers/media/platform/davinci/vpif_capture.c > @@ -2160,6 +2160,7 @@ static __init int vpif_probe(struct platform_device *pdev) > > if (!vpif_obj.sd[i]) { > vpif_err("Error registering v4l2 subdevice\n"); > + err = -ENOMEM; This should be err = -ENODEV Regards, --Prabhakar Lad
Hi Wei, On Fri, Aug 23, 2013 at 8:50 AM, Prabhakar Lad <prabhakar.csengg@gmail.com> wrote: > Hi Wei, > > I retract my Ack. > > On Fri, Aug 23, 2013 at 8:30 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote: >> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> >> >> Fix to return -ENODEV in the subdevice register error handling >> case instead of 0, as done elsewhere in this function. >> >> Introduced by commit 873229e4fdf34196aa5d707957c59ba54c25eaba >> ([media] media: davinci: vpif: capture: add V4L2-async support) >> >> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> >> --- >> drivers/media/platform/davinci/vpif_capture.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c >> index 7fbde6d..e4b6a26 100644 >> --- a/drivers/media/platform/davinci/vpif_capture.c >> +++ b/drivers/media/platform/davinci/vpif_capture.c >> @@ -2160,6 +2160,7 @@ static __init int vpif_probe(struct platform_device *pdev) >> >> if (!vpif_obj.sd[i]) { >> vpif_err("Error registering v4l2 subdevice\n"); >> + err = -ENOMEM; > > This should be err = -ENODEV > I assume you will fix it and repost this patch. Regards, --Prabhakar Lad
diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index 7fbde6d..e4b6a26 100644 --- a/drivers/media/platform/davinci/vpif_capture.c +++ b/drivers/media/platform/davinci/vpif_capture.c @@ -2160,6 +2160,7 @@ static __init int vpif_probe(struct platform_device *pdev) if (!vpif_obj.sd[i]) { vpif_err("Error registering v4l2 subdevice\n"); + err = -ENOMEM; goto probe_subdev_out; } v4l2_info(&vpif_obj.v4l2_dev,