From patchwork Fri Aug 23 02:59:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2848525 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3F47BBF546 for ; Fri, 23 Aug 2013 03:01:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DE10A202C7 for ; Fri, 23 Aug 2013 03:01:08 +0000 (UTC) Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 727E4202DD for ; Fri, 23 Aug 2013 03:01:04 +0000 (UTC) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id r7N2xnbx029192; Thu, 22 Aug 2013 21:59:50 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id r7N2xnJg003722; Thu, 22 Aug 2013 21:59:49 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.2.342.3; Thu, 22 Aug 2013 21:59:49 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id r7N2xmXU011583; Thu, 22 Aug 2013 21:59:48 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id 2D6BB80627; Thu, 22 Aug 2013 21:59:48 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp53.itg.ti.com (dflp53.itg.ti.com [128.247.5.6]) by linux.omap.com (Postfix) with ESMTP id 90AB280626 for ; Thu, 22 Aug 2013 21:59:47 -0500 (CDT) Received: from white.ext.ti.com (white.ext.ti.com [192.94.93.38]) by dflp53.itg.ti.com (8.13.8/8.13.8) with ESMTP id r7N2xlUr023988 for ; Thu, 22 Aug 2013 21:59:47 -0500 (CDT) Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by white.ext.ti.com (8.13.7/8.13.7) with ESMTP id r7N2xkif016930 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 22 Aug 2013 21:59:47 -0500 Received: from [216.82.253.163:44535] by server-13.bemta-7.messagelabs.com id FD/45-21957-220D6125; Fri, 23 Aug 2013 02:59:46 +0000 X-Env-Sender: weiyj.lk@gmail.com X-Msg-Ref: server-7.tower-166.messagelabs.com!1377226784!17563991!1 X-Originating-IP: [209.85.214.42] X-SpamReason: No, hits=0.3 required=7.0 tests=ML_RADAR_SPEW_LINKS_14, RCVD_BY_IP,spamassassin: X-StarScan-Received: X-StarScan-Version: 6.9.11; banners=-,-,- X-VirusChecked: Checked Received: (qmail 29538 invoked from network); 23 Aug 2013 02:59:46 -0000 Received: from mail-bk0-f42.google.com (HELO mail-bk0-f42.google.com) (209.85.214.42) by server-7.tower-166.messagelabs.com with RC4-SHA encrypted SMTP; 23 Aug 2013 02:59:46 -0000 Received: by mail-bk0-f42.google.com with SMTP id my10so33570bkb.1 for ; Thu, 22 Aug 2013 19:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=9ZoinRxZ15ab0ft1K1loAoN2SNWRJSREt1/5j/P2e3Y=; b=ZZi138tihukTMR9n+YwMfCVPMtZCS2dSIcaharghHXiWaRqvyW/BMwlUfzMIe+UoUf 2x2p4+woRI6H7ooXyRYUkYzpt/p5GMXlfoWUdDAqO0THr+n6Qe8DVlO+edqMRzWUqVC7 teGN4UwcMH3vu+6p5lxkSJ+viqMHgsZNzmqzor3HyJc6lGVr/dZrblP2NFswsAwjaaAr IgGmFxG+mfNO9eI5OOgt2frKIJojVyyzdvFpjf+A9Y9U73H8Jgs9E/kdCgqtFOSoAksI ovEkneF5h9S1P771f5ZAx9RzN2UfrdAvg6neMneHFdC5ivdo4WH2+yEPMYZIH0DxOTu9 uD5w== MIME-Version: 1.0 X-Received: by 10.204.224.77 with SMTP id in13mr9482203bkb.24.1377226784153; Thu, 22 Aug 2013 19:59:44 -0700 (PDT) Received: by 10.205.13.74 with HTTP; Thu, 22 Aug 2013 19:59:44 -0700 (PDT) Date: Fri, 23 Aug 2013 10:59:44 +0800 Message-ID: Subject: [PATCH -next] [media] davinci: vpif_display: fix error return code in vpif_probe() From: Wei Yongjun To: , CC: , , X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun Fix to return -ENODEV in the subdevice register error handling case instead of 0, as done elsewhere in this function. Introduce by commit 4b8a531e6bb0686203e9cf82a54dfe189de7d5c2. ([media] media: davinci: vpif: display: add V4L2-async support) Signed-off-by: Wei Yongjun Acked-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/davinci/vpif_display.c b/drivers/media/platform/davinci/vpif_display.c index 6336dfc..0e03b9a 100644 --- a/drivers/media/platform/davinci/vpif_display.c +++ b/drivers/media/platform/davinci/vpif_display.c @@ -1824,6 +1824,7 @@ static __init int vpif_probe(struct platform_device *pdev) NULL); if (!vpif_obj.sd[i]) { vpif_err("Error registering v4l2 subdevice\n"); + err = -ENODEV; goto probe_subdev_out; }