From patchwork Mon May 13 05:57:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2556441 Return-Path: X-Original-To: patchwork-davinci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by patchwork1.kernel.org (Postfix) with ESMTP id 3EFE53FD4E for ; Mon, 13 May 2013 05:59:19 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id r4D5w4jr012308; Mon, 13 May 2013 00:58:04 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r4D5w3cU003557; Mon, 13 May 2013 00:58:04 -0500 Received: from dlelxv23.itg.ti.com (172.17.1.198) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.2.342.3; Mon, 13 May 2013 00:58:03 -0500 Received: from linux.omap.com (dlelxs01.itg.ti.com [157.170.227.31]) by dlelxv23.itg.ti.com (8.13.8/8.13.8) with ESMTP id r4D5w315014564; Mon, 13 May 2013 00:58:03 -0500 Received: from linux.omap.com (localhost [127.0.0.1]) by linux.omap.com (Postfix) with ESMTP id AF18B80627; Mon, 13 May 2013 00:58:03 -0500 (CDT) X-Original-To: davinci-linux-open-source@linux.davincidsp.com Delivered-To: davinci-linux-open-source@linux.davincidsp.com Received: from dflp52.itg.ti.com (dflp52.itg.ti.com [128.247.22.96]) by linux.omap.com (Postfix) with ESMTP id 226F880626 for ; Mon, 13 May 2013 00:58:03 -0500 (CDT) Received: from red.ext.ti.com (red.ext.ti.com [192.94.93.37]) by dflp52.itg.ti.com (8.13.7/8.13.8) with ESMTP id r4D5w2Xp020362 for ; Mon, 13 May 2013 00:58:02 -0500 (CDT) Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by red.ext.ti.com (8.13.7/8.13.7) with ESMTP id r4D5w2if025600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 May 2013 00:58:02 -0500 Received: from [216.82.253.147:34965] by server-15.bemta-7.messagelabs.com id 64/A2-16944-AE080915; Mon, 13 May 2013 05:58:02 +0000 X-Env-Sender: weiyj.lk@gmail.com X-Msg-Ref: server-10.tower-165.messagelabs.com!1368424657!10915932!1 X-Originating-IP: [209.85.214.44] X-SpamReason: No, hits=0.3 required=7.0 tests=ML_RADAR_SPEW_LINKS_14, RCVD_BY_IP,spamassassin: X-StarScan-Received: X-StarScan-Version: 6.9.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 2611 invoked from network); 13 May 2013 05:57:39 -0000 Received: from mail-bk0-f44.google.com (HELO mail-bk0-f44.google.com) (209.85.214.44) by server-10.tower-165.messagelabs.com with RC4-SHA encrypted SMTP; 13 May 2013 05:57:39 -0000 Received: by mail-bk0-f44.google.com with SMTP id jk13so2214255bkc.17 for ; Sun, 12 May 2013 22:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to:cc :content-type; bh=CE2OHZZrypDsJag+hiLeJRHyJZpe/e7Qyt8vh8TpJ+k=; b=xuc3CGxi+ukwatM1pO+n6yBpe5rzFJNLcfsaSoNlU/jy/kR0n/YJN2EGaLXk38h5/p ViwJpfuMirKxmU2myYKluwAz7c7QEkN8Vm9QsL0zTCrfwcePqcWjqM7Q6UvBA/gBodU/ pIOW8pkJj3ZYz74NWLAQDiUfDpGZ6dL2f9E8KwrtDmyLyJPY4zrj0Ys2ZY7AAFiDz1Ik ZuSgK1DmBJcX2QWBDK6Omw/USSXEkliH/9COFElPYqx/KCSXNhFD85pAE2nEhgZ0P+Jc GT+mTxPE7J+X/j+WkdINnegq2ZAsMowYXtwR5iae7xX5GHeYnyfLj+mKaEMSXJgURuCY rB5g== MIME-Version: 1.0 X-Received: by 10.204.173.9 with SMTP id n9mr5111229bkz.47.1368424657415; Sun, 12 May 2013 22:57:37 -0700 (PDT) Received: by 10.204.199.129 with HTTP; Sun, 12 May 2013 22:57:37 -0700 (PDT) Date: Mon, 13 May 2013 13:57:37 +0800 Message-ID: Subject: [PATCH] [media] vpif_capture: fix error return code in vpif_probe() From: Wei Yongjun To: , CC: , , X-BeenThere: davinci-linux-open-source@linux.davincidsp.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces@linux.davincidsp.com From: Wei Yongjun Fix to return -ENODEV in the subdevice register error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Acked-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_capture.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index 5f98df1..ef0fc94 100644 --- a/drivers/media/platform/davinci/vpif_capture.c +++ b/drivers/media/platform/davinci/vpif_capture.c @@ -2170,6 +2170,7 @@ static __init int vpif_probe(struct platform_device *pdev) if (!vpif_obj.sd[i]) { vpif_err("Error registering v4l2 subdevice\n"); + err = -ENODEV; goto probe_subdev_out; } v4l2_info(&vpif_obj.v4l2_dev, "registered sub device %s\n",