| Message ID | ef225dbf63b1d834761773384d3f70cb4ac7b611.1364205812.git.viresh.kumar@linaro.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
Hi Viresh, On 3/25/2013 3:41 PM, Viresh Kumar wrote: > This patch moves cpufreq driver of ARM based davinci platform to > drivers/cpufreq. > > Cc: Sekhar Nori <nsekhar@ti.com> > Cc: davinci-linux-open-source@linux.davincidsp.com > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> I am unable to apply this patch for testing. Looks like this could be because of: Content-Type: text/plain; charset="WINDOWS-1252" Can you get rid of that charset="WINDOWS-1252"? Thanks, Sekhar
On 27 March 2013 15:47, Sekhar Nori <nsekhar@ti.com> wrote: > On 3/25/2013 3:41 PM, Viresh Kumar wrote: > I am unable to apply this patch for testing. Looks like this could be > because of: > > Content-Type: text/plain; charset="WINDOWS-1252" > > Can you get rid of that charset="WINDOWS-1252"? I can't, its MSF exchange server behind this. And for this reason only i push my patches in my public repo all the time, mentioned in cover-letter. http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/heads/cpufreq-move-drivers
On 3/27/2013 3:51 PM, Viresh Kumar wrote: > On 27 March 2013 15:47, Sekhar Nori <nsekhar@ti.com> wrote: >> On 3/25/2013 3:41 PM, Viresh Kumar wrote: >> I am unable to apply this patch for testing. Looks like this could be >> because of: >> >> Content-Type: text/plain; charset="WINDOWS-1252" >> >> Can you get rid of that charset="WINDOWS-1252"? > > I can't, its MSF exchange server behind this. Too bad. But something needs to be done about it since we all like to apply patches received in email ;). I have seen reports of people configuring gmail to know their @company.com address as another e-mail address they own and then using gmail SMTP to send patches (git config). You should try that. > > And for this reason only i push my patches in my public repo all the > time, mentioned in cover-letter. > > http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/heads/cpufreq-move-drivers Okay but you never copied me on the cover letter so I only saw this one patch. I will pull your tree and test now. Thanks, Sekhar
On 27 March 2013 16:02, Sekhar Nori <nsekhar@ti.com> wrote: > Too bad. But something needs to be done about it since we all like to > apply patches received in email ;). I have seen reports of people > configuring gmail to know their @company.com address as another e-mail > address they own and then using gmail SMTP to send patches (git config). > You should try that. I don't use ARM's email id for sending mails and linaro id uses gmail servers only for sending mails.. The problem is, when i am in office, i can' use google servers to send mails and whatever mail i send from within ARM, they are broken. I can use linaro servers from outside office without any issues and it is never broken. >> And for this reason only i push my patches in my public repo all the >> time, mentioned in cover-letter. >> >> http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/heads/cpufreq-move-drivers > > Okay but you never copied me on the cover letter so I only saw this one > patch. I will pull your tree and test now. This series was affecting lots of people and so every patch had a number of people added as cc. I didn't wanted to add everybody in cc of complete patchset. BUT, i have another idea now. The way i used to add people in cc for specific patches (by editing the patch), i will do the same for cover-letter too next time. And so all people will receive relevant patches + cover letter. -- viresh
On 3/27/2013 3:51 PM, Viresh Kumar wrote: > On 27 March 2013 15:47, Sekhar Nori <nsekhar@ti.com> wrote: >> On 3/25/2013 3:41 PM, Viresh Kumar wrote: >> I am unable to apply this patch for testing. Looks like this could be >> because of: >> >> Content-Type: text/plain; charset="WINDOWS-1252" >> >> Can you get rid of that charset="WINDOWS-1252"? > > I can't, its MSF exchange server behind this. > > And for this reason only i push my patches in my public repo all the > time, mentioned in cover-letter. > > http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/heads/cpufreq-move-drivers I pulled your branch and briefly tested it on da850 evm. It doesn't seem to have broken anything. So you can add: Acked-by: Sekhar Nori <nsekhar@ti.com> Thanks, Sekhar
diff --git a/arch/arm/mach-davinci/Makefile b/arch/arm/mach-davinci/Makefile index fb5c1aa..dd1ffcc 100644 --- a/arch/arm/mach-davinci/Makefile +++ b/arch/arm/mach-davinci/Makefile @@ -37,7 +37,6 @@ obj-$(CONFIG_MACH_MITYOMAPL138) += board-mityomapl138.o obj-$(CONFIG_MACH_OMAPL138_HAWKBOARD) += board-omapl138-hawk.o # Power Management -obj-$(CONFIG_CPU_FREQ) += cpufreq.o obj-$(CONFIG_CPU_IDLE) += cpuidle.o obj-$(CONFIG_SUSPEND) += pm.o sleep.o obj-$(CONFIG_HAVE_CLK) += pm_domain.o diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile index 966ea28..efce6c7 100644 --- a/drivers/cpufreq/Makefile +++ b/drivers/cpufreq/Makefile @@ -44,6 +44,7 @@ obj-$(CONFIG_X86_INTEL_PSTATE) += intel_pstate.o ################################################################################## # ARM SoC drivers +obj-$(CONFIG_ARCH_DAVINCI_DA850) += davinci-cpufreq.o obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += exynos-cpufreq.o obj-$(CONFIG_ARM_EXYNOS4210_CPUFREQ) += exynos4210-cpufreq.o diff --git a/arch/arm/mach-davinci/cpufreq.c b/drivers/cpufreq/davinci-cpufreq.c similarity index 99% rename from arch/arm/mach-davinci/cpufreq.c rename to drivers/cpufreq/davinci-cpufreq.c index 8fb0c2a..5b34f61 100644 --- a/arch/arm/mach-davinci/cpufreq.c +++ b/drivers/cpufreq/davinci-cpufreq.c @@ -30,8 +30,6 @@ #include <mach/cpufreq.h> #include <mach/common.h> -#include "clock.h" - struct davinci_cpufreq { struct device *dev; struct clk *armclk;
This patch moves cpufreq driver of ARM based davinci platform to drivers/cpufreq. Cc: Sekhar Nori <nsekhar@ti.com> Cc: davinci-linux-open-source@linux.davincidsp.com Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- arch/arm/mach-davinci/Makefile | 1 - drivers/cpufreq/Makefile | 1 + arch/arm/mach-davinci/cpufreq.c => drivers/cpufreq/davinci-cpufreq.c | 2 -- 3 files changed, 1 insertion(+), 3 deletions(-) rename arch/arm/mach-davinci/cpufreq.c => drivers/cpufreq/davinci-cpufreq.c (99%)