[RESEND,0/3] Few Tegra210 ADMA fixes

Message

Sameer Pujar Sept. 15, 2021, 4:07 p.m. UTC

Following are the fixes in the series:
 - Couple of minor fixes (non functional fixes)

 - ADMA FIFO size fix: The slave ADMAIF channels have different default
   FIFO sizes (ADMAIF FIFO is actually a ring buffer and it is divided
   amongst all available channels). As per HW recommendation the sizes
   should match with the corresponding ADMA channels to which ADMAIF
   channel is mapped to at runtime. Thus program ADMA channel FIFO sizes
   accordingly. Otherwise FIFO corruption is observed.

Sameer Pujar (3):
  dmaengine: tegra210-adma: Re-order 'has_outstanding_reqs' member
  dmaengine: tegra210-adma: Add description for 'adma_get_burst_config'
  dmaengine: tegra210-adma: Override ADMA FIFO size

 drivers/dma/tegra210-adma.c | 55 +++++++++++++++++++++++++++++++--------------
 1 file changed, 38 insertions(+), 17 deletions(-)

Comments

Sameer Pujar Sept. 27, 2021, 6:20 a.m. UTC | #1

Hi Vinod,


On 9/15/2021 9:37 PM, Sameer Pujar wrote:
> Following are the fixes in the series:
>   - Couple of minor fixes (non functional fixes)
>
>   - ADMA FIFO size fix: The slave ADMAIF channels have different default
>     FIFO sizes (ADMAIF FIFO is actually a ring buffer and it is divided
>     amongst all available channels). As per HW recommendation the sizes
>     should match with the corresponding ADMA channels to which ADMAIF
>     channel is mapped to at runtime. Thus program ADMA channel FIFO sizes
>     accordingly. Otherwise FIFO corruption is observed.
>
> Sameer Pujar (3):
>    dmaengine: tegra210-adma: Re-order 'has_outstanding_reqs' member
>    dmaengine: tegra210-adma: Add description for 'adma_get_burst_config'
>    dmaengine: tegra210-adma: Override ADMA FIFO size
>
>   drivers/dma/tegra210-adma.c | 55 +++++++++++++++++++++++++++++++--------------
>   1 file changed, 38 insertions(+), 17 deletions(-)

Can you please pick up these changes?


Thanks,
Sameer.

Sameer Pujar Oct. 4, 2021, 3:49 p.m. UTC | #2

Hi Vinod,

On 9/15/2021 9:37 PM, Sameer Pujar wrote:
> Following are the fixes in the series:
>   - Couple of minor fixes (non functional fixes)
>
>   - ADMA FIFO size fix: The slave ADMAIF channels have different default
>     FIFO sizes (ADMAIF FIFO is actually a ring buffer and it is divided
>     amongst all available channels). As per HW recommendation the sizes
>     should match with the corresponding ADMA channels to which ADMAIF
>     channel is mapped to at runtime. Thus program ADMA channel FIFO sizes
>     accordingly. Otherwise FIFO corruption is observed.
>
> Sameer Pujar (3):
>    dmaengine: tegra210-adma: Re-order 'has_outstanding_reqs' member
>    dmaengine: tegra210-adma: Add description for 'adma_get_burst_config'
>    dmaengine: tegra210-adma: Override ADMA FIFO size
>
>   drivers/dma/tegra210-adma.c | 55 +++++++++++++++++++++++++++++++--------------
>   1 file changed, 38 insertions(+), 17 deletions(-)
>

Are these patches good to be picked up? or I need to resend these?


Thanks,
Sameer.

Vinod Koul Oct. 5, 2021, 6:33 a.m. UTC | #3

On 04-10-21, 21:19, Sameer Pujar wrote:
> Hi Vinod,
> 
> On 9/15/2021 9:37 PM, Sameer Pujar wrote:
> > Following are the fixes in the series:
> >   - Couple of minor fixes (non functional fixes)
> > 
> >   - ADMA FIFO size fix: The slave ADMAIF channels have different default
> >     FIFO sizes (ADMAIF FIFO is actually a ring buffer and it is divided
> >     amongst all available channels). As per HW recommendation the sizes
> >     should match with the corresponding ADMA channels to which ADMAIF
> >     channel is mapped to at runtime. Thus program ADMA channel FIFO sizes
> >     accordingly. Otherwise FIFO corruption is observed.
> > 
> > Sameer Pujar (3):
> >    dmaengine: tegra210-adma: Re-order 'has_outstanding_reqs' member
> >    dmaengine: tegra210-adma: Add description for 'adma_get_burst_config'
> >    dmaengine: tegra210-adma: Override ADMA FIFO size
> > 
> >   drivers/dma/tegra210-adma.c | 55 +++++++++++++++++++++++++++++++--------------
> >   1 file changed, 38 insertions(+), 17 deletions(-)
> > 
> 
> Are these patches good to be picked up? or I need to resend these?

Pls do not send unnecessary pings, I was on vacation, back now and going
thru the queue!

Vinod Koul Oct. 18, 2021, 4:03 a.m. UTC | #4

On 15-09-21, 21:37, Sameer Pujar wrote:
> Following are the fixes in the series:
>  - Couple of minor fixes (non functional fixes)
> 
>  - ADMA FIFO size fix: The slave ADMAIF channels have different default
>    FIFO sizes (ADMAIF FIFO is actually a ring buffer and it is divided
>    amongst all available channels). As per HW recommendation the sizes
>    should match with the corresponding ADMA channels to which ADMAIF
>    channel is mapped to at runtime. Thus program ADMA channel FIFO sizes
>    accordingly. Otherwise FIFO corruption is observed.

The patches are semantically and doing the right thing by ordering. But
that does not really make it a 'fix' imo. I am applying these to next

Thanks and apologies for delay