| Message ID | 20200527070612.636-1-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | dmaengine: ti: k3-udma: Fixes for alloc_chan_resources | expand |
On 27-05-20, 10:06, Peter Ujfalusi wrote: > Hi, > > It turned out that udma_stop() can not be used to stop the channel which was > left enabled during boot (missing cleanup in early boot) since it would initiate > teardown. This is not supported on non configured channels. > Simply reset the running channel instead fixes the issue. > > While looking at this issue I have noticed that the cleanup path misses > resources if the error happens early. Applied, thanks
Hi, It turned out that udma_stop() can not be used to stop the channel which was left enabled during boot (missing cleanup in early boot) since it would initiate teardown. This is not supported on non configured channels. Simply reset the running channel instead fixes the issue. While looking at this issue I have noticed that the cleanup path misses resources if the error happens early. Regards, Peter --- Peter Ujfalusi (2): dmaengine: ti: k3-udma: Fix cleanup code for alloc_chan_resources dmaengine: ti: k3-udma: Fix the running channel handling in alloc_chan_resources drivers/dma/ti/k3-udma.c | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-)