| Message ID | 20220301182551.883474-1-benjamin.walker@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | dmaengine: memset clarifications and fixes | expand |
On 01-03-22, 11:25, Ben Walker wrote: > The following contains a clarification for the behavior of the 'value' > parameter in the memset operation. It is intended to be a single byte > pattern as laid out here: > > https://lore.kernel.org/dmaengine/YejrA5ZWZ3lTRO%2F1@matsya/ > > Then I'm attempting to fix all places it is currently used. But note > that I do not have access to this hardware and cannot test it. We'll > really need a maintainer to take a look at each of these to verify that > the changes are correct. Applied, thanks
+ Maxime. Hi! On 3/1/22 20:25, Ben Walker wrote: > The following contains a clarification for the behavior of the 'value' > parameter in the memset operation. It is intended to be a single byte > pattern as laid out here: > > https://lore.kernel.org/dmaengine/YejrA5ZWZ3lTRO%2F1@matsya/ > > Then I'm attempting to fix all places it is currently used. But note Sorry for being late. I see there are no in kernel users of dma_memset/dma_memset_sg methods (other than dmatest.c). Any idea why do we still keep them?
The following contains a clarification for the behavior of the 'value' parameter in the memset operation. It is intended to be a single byte pattern as laid out here: https://lore.kernel.org/dmaengine/YejrA5ZWZ3lTRO%2F1@matsya/ Then I'm attempting to fix all places it is currently used. But note that I do not have access to this hardware and cannot test it. We'll really need a maintainer to take a look at each of these to verify that the changes are correct. v3: - Using signed byte for pattern everywhere Ben Walker (4): dmaengine: Document dmaengine_prep_dma_memset dmaengine: at_hdmac: In atc_prep_dma_memset, treat value as a single byte dmaengine: at_xdmac: In at_xdmac_prep_dma_memset, treat value as a single byte dmaengine: hidma: In hidma_prep_dma_memset treat value as a single byte drivers/dma/at_hdmac.c | 10 +++++++++- drivers/dma/at_xdmac.c | 9 ++++++++- drivers/dma/qcom/hidma.c | 13 ++++++++++++- include/linux/dmaengine.h | 8 ++++++++ 4 files changed, 37 insertions(+), 3 deletions(-)