[v12,0/2] Add support for Loongson1 APB DMA

Message

Keguang Zhang via B4 Relay Aug. 9, 2024, 10:30 a.m. UTC

Add the driver and dt-binding document for Loongson1 APB DMA.

Changes in v12:
- Delete superfluous blank lines in the examples section.
- Move the call to devm_request_irq() into ls1x_dma_alloc_chan_resources()
  to use dma_chan_name() as a parameter.
- Move the call to devm_free_irq() into ls1x_dma_free_chan_resources() accordingly.
- Rename ls1x_dma_alloc_llis() to ls1x_dma_prep_lli().
- Merge ls1x_dma_free_lli() into ls1x_dma_free_desc().
- Add ls1x_dma_synchronize().
- Fix the error handling of ls1x_dma_probe().
- Some minor fixes and improvements.
- Link to v11: https://lore.kernel.org/r/[e-mail]

Changes in v11:
- Use guard notation to acquire the spinlock.
- Fix the build error of LS1X_DMA_LLI_ALIGNMENT.
- Some minor fixes.
- Link to v10: https://lore.kernel.org/r/[e-mail]

Changes in v10:
- Implement the hwdescs by link list to eliminate the limitation of the desc number.
- Add the prefix 'LS1X_' for all registers and their bits.
- Drop the macros: chan_readl() and chan_writel().
- Use %pad for printing a dma_addr_t type.
- Some minor fixes.
- Link to v9: https://lore.kernel.org/r/[e-mail]

Changes in v9:
- Fix all the errors and warnings when building with W=1 and C=1
- Link to v8: https://lore.kernel.org/r/[e-mail]

Changes in v8:
- Change 'interrupts' property to an items list
- Link to v7: https://lore.kernel.org/r/[e-mail]

Changes in v7:
- Change the comptible to 'loongson,ls1*-apbdma' (suggested by Huacai Chen)
- Update the title and description part accordingly
- Rename the file to loongson,ls1b-apbdma.yaml
- Add a compatible string for LS1A
- Delete minItems of 'interrupts'
- Change patterns of 'interrupt-names' to const
- Rename the file to loongson1-apb-dma.c to keep the consistency
- Update Kconfig and Makefile accordingly
- Link to v6: https://lore.kernel.org/r/[e-mail]

Changes in v6:
- Change the compatible to the fallback
- Implement .device_prep_dma_cyclic for Loongson1 sound driver,
  as well as .device_pause and .device_resume.
- Set the limitation LS1X_DMA_MAX_DESC and put all descriptors
  into one page to save memory
- Move dma_pool_zalloc() into ls1x_dma_alloc_desc()
- Drop dma_slave_config structure
- Use .remove_new instead of .remove
- Use KBUILD_MODNAME for the driver name
- Improve the debug information
- Some minor fixes

Changes in v5:
- Add the dt-binding document
- Add DT support
- Use DT information instead of platform data
- Use chan_id of struct dma_chan instead of own id
- Use of_dma_xlate_by_chan_id() instead of ls1x_dma_filter()
- Update the author information to my official name

Changes in v4:
- Use dma_slave_map to find the proper channel.
- Explicitly call devm_request_irq() and tasklet_kill().
- Fix namespace issue.
- Some minor fixes and cleanups.

Changes in v3:
- Rename ls1x_dma_filter_fn to ls1x_dma_filter.

Changes in v2:
- Change the config from 'DMA_LOONGSON1' to 'LOONGSON1_DMA',
- and rearrange it in alphabetical order in Kconfig and Makefile.
- Fix comment style.

---
Keguang Zhang (2):
      dt-bindings: dma: Add Loongson-1 APB DMA
      dmaengine: Loongson1: Add Loongson-1 APB DMA driver

 .../bindings/dma/loongson,ls1b-apbdma.yaml         |  65 ++
 drivers/dma/Kconfig                                |   9 +
 drivers/dma/Makefile                               |   1 +
 drivers/dma/loongson1-apb-dma.c                    | 660 +++++++++++++++++++++
 4 files changed, 735 insertions(+)
---
base-commit: 61c01d2e181adfba02fe09764f9fca1de2be0dbe
change-id: 20231120-loongson1-dma-163afe5708b9

Best regards,

Comments

Vinod Koul Aug. 29, 2024, 5:30 p.m. UTC | #1

On Fri, 09 Aug 2024 18:30:57 +0800, Keguang Zhang wrote:
> Add the driver and dt-binding document for Loongson1 APB DMA.
> 
> Changes in v12:
> - Delete superfluous blank lines in the examples section.
> - Move the call to devm_request_irq() into ls1x_dma_alloc_chan_resources()
>   to use dma_chan_name() as a parameter.
> - Move the call to devm_free_irq() into ls1x_dma_free_chan_resources() accordingly.
> - Rename ls1x_dma_alloc_llis() to ls1x_dma_prep_lli().
> - Merge ls1x_dma_free_lli() into ls1x_dma_free_desc().
> - Add ls1x_dma_synchronize().
> - Fix the error handling of ls1x_dma_probe().
> - Some minor fixes and improvements.
> - Link to v11: https://lore.kernel.org/r/[e-mail]
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: dma: Add Loongson-1 APB DMA
      commit: 7ea270bb93e4ce165bb4f834c29c05e9815b6ca8
[2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver
      commit: e06c432312148ddb550ec55b004e32671657ea23

Best regards,

Keguang Zhang Aug. 30, 2024, 2:33 a.m. UTC | #2

On Fri, Aug 30, 2024 at 1:30 AM Vinod Koul <[e-mail]> wrote:
>
>
> On Fri, 09 Aug 2024 18:30:57 +0800, Keguang Zhang wrote:
> > Add the driver and dt-binding document for Loongson1 APB DMA.
> >
> > Changes in v12:
> > - Delete superfluous blank lines in the examples section.
> > - Move the call to devm_request_irq() into ls1x_dma_alloc_chan_resources()
> >   to use dma_chan_name() as a parameter.
> > - Move the call to devm_free_irq() into ls1x_dma_free_chan_resources() accordingly.
> > - Rename ls1x_dma_alloc_llis() to ls1x_dma_prep_lli().
> > - Merge ls1x_dma_free_lli() into ls1x_dma_free_desc().
> > - Add ls1x_dma_synchronize().
> > - Fix the error handling of ls1x_dma_probe().
> > - Some minor fixes and improvements.
> > - Link to v11: https://lore.kernel.org/r/[e-mail]
> >
> > [...]
>
> Applied, thanks!
>
Great!
Thanks very much!

> [1/2] dt-bindings: dma: Add Loongson-1 APB DMA
>       commit: 7ea270bb93e4ce165bb4f834c29c05e9815b6ca8
> [2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver
>       commit: e06c432312148ddb550ec55b004e32671657ea23
>
> Best regards,
> --
> ~Vinod
>
>