| Message ID | ebd531dd-60e3-4ac3-821e-aa9890960283@web.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | dmaengine: timb_dma: Adjustments for td_alloc_init_desc() | expand |
On 25-12-23, 11:15, Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Mon, 25 Dec 2023 11:05:45 +0100 > > A few update suggestions were taken into account > from static source code analysis. was this anaysis done by you or some tool reported this. Frabkly I dont see much value in these patches, can you fix something real please > > Markus Elfring (3): > Return directly after a failed kzalloc() > Improve a size determination > One function call less after error detection > > drivers/dma/timb_dma.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > -- > 2.43.0
>> A few update suggestions were taken into account >> from static source code analysis. > > was this anaysis done by you Mostly, yes. > or some tool reported this. Some scripts for the semantic patch language (Coccinelle software) can help to point places out for desirable source code transformations. > Frabkly I dont see much value in these patches, It is a pity that you view the presented update steps in this direction. > can you fix something real please You might occasionally find adjustments from my patch selection more worthwhile. Regards, Markus
From: Markus Elfring <elfring@users.sourceforge.net> Date: Mon, 25 Dec 2023 11:05:45 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Return directly after a failed kzalloc() Improve a size determination One function call less after error detection drivers/dma/timb_dma.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.43.0