| Message ID | 1393925935-24528-1-git-send-email-jerome.blin@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2acec15034cc |
| Delegated to: | Vinod Koul |
| Headers | show |
On Tue, Mar 04, 2014 at 10:38:55AM +0100, Jerome Blin wrote: > Prevents test result strings from being output on same line. Issue will > happen with verbose and multi-iteration modes enabled. > > Signed-off-by: Jerome Blin <jerome.blin@intel.com> Applied, thanks > --- > drivers/dma/dmatest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c > index 05b6dea..e27cec2 100644 > --- a/drivers/dma/dmatest.c > +++ b/drivers/dma/dmatest.c > @@ -340,7 +340,7 @@ static unsigned int min_odd(unsigned int x, unsigned int y) > static void result(const char *err, unsigned int n, unsigned int src_off, > unsigned int dst_off, unsigned int len, unsigned long data) > { > - pr_info("%s: result #%u: '%s' with src_off=0x%x dst_off=0x%x len=0x%x (%lu)", > + pr_info("%s: result #%u: '%s' with src_off=0x%x dst_off=0x%x len=0x%x (%lu)\n", > current->comm, n, err, src_off, dst_off, len, data); > } > > @@ -348,7 +348,7 @@ static void dbg_result(const char *err, unsigned int n, unsigned int src_off, > unsigned int dst_off, unsigned int len, > unsigned long data) > { > - pr_debug("%s: result #%u: '%s' with src_off=0x%x dst_off=0x%x len=0x%x (%lu)", > + pr_debug("%s: result #%u: '%s' with src_off=0x%x dst_off=0x%x len=0x%x (%lu)\n", > current->comm, n, err, src_off, dst_off, len, data); > } > > -- > 1.8.3.2 > > --------------------------------------------------------------------- > Intel Corporation SAS (French simplified joint stock company) > Registered headquarters: "Les Montalets"- 2, rue de Paris, > 92196 Meudon Cedex, France > Registration Number: 302 456 199 R.C.S. NANTERRE > Capital: 4,572,000 Euros > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. Pls ensure this is omitted from your emails to public lists! -- ~Vinod > > -- > To unsubscribe from this list: send the line "unsubscribe dmaengine" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2014-03-26 at 11:42 +0530, Vinod Koul wrote: [] > > This e-mail and any attachments may contain confidential material for > > the sole use of the intended recipient(s). Any review or distribution > > by others is strictly prohibited. If you are not the intended > > recipient, please contact the sender and delete all copies. > Pls ensure this is omitted from your emails to public lists! Thanks for pointing this out, though I already informed Jerome about this footer. I think he already fixed it and it will be no such case in future.
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index 05b6dea..e27cec2 100644 --- a/drivers/dma/dmatest.c +++ b/drivers/dma/dmatest.c @@ -340,7 +340,7 @@ static unsigned int min_odd(unsigned int x, unsigned int y) static void result(const char *err, unsigned int n, unsigned int src_off, unsigned int dst_off, unsigned int len, unsigned long data) { - pr_info("%s: result #%u: '%s' with src_off=0x%x dst_off=0x%x len=0x%x (%lu)", + pr_info("%s: result #%u: '%s' with src_off=0x%x dst_off=0x%x len=0x%x (%lu)\n", current->comm, n, err, src_off, dst_off, len, data); } @@ -348,7 +348,7 @@ static void dbg_result(const char *err, unsigned int n, unsigned int src_off, unsigned int dst_off, unsigned int len, unsigned long data) { - pr_debug("%s: result #%u: '%s' with src_off=0x%x dst_off=0x%x len=0x%x (%lu)", + pr_debug("%s: result #%u: '%s' with src_off=0x%x dst_off=0x%x len=0x%x (%lu)\n", current->comm, n, err, src_off, dst_off, len, data); }
Prevents test result strings from being output on same line. Issue will happen with verbose and multi-iteration modes enabled. Signed-off-by: Jerome Blin <jerome.blin@intel.com> --- drivers/dma/dmatest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)