diff mbox

[v3] dmaengine: inherit debug settings from the subsystem for subdirectories

Message ID 1405370846-13986-1-git-send-email-wsa@the-dreams.de (mailing list archive)
State Accepted
Commit 653e67f7e5e0
Delegated to: Vinod Koul
Headers show

Commit Message

Wolfram Sang July 14, 2014, 8:47 p.m. UTC
From: Wolfram Sang <wsa+renesas@sang-engineering.com>

To be able to see debug messages during boot, enable the debug settings
from Kconfig also for drivers in subdirectories.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/dma/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Horman July 15, 2014, 4:15 a.m. UTC | #1
On Mon, Jul 14, 2014 at 10:47:26PM +0200, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> To be able to see debug messages during boot, enable the debug settings
> from Kconfig also for drivers in subdirectories.

Thanks, I have added this to the shdma-for-v3.17 branch.

> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/dma/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
> index c779e1eb2db2..aca5eb577d44 100644
> --- a/drivers/dma/Makefile
> +++ b/drivers/dma/Makefile
> @@ -1,5 +1,5 @@
> -ccflags-$(CONFIG_DMADEVICES_DEBUG)  := -DDEBUG
> -ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
> +subdir-ccflags-$(CONFIG_DMADEVICES_DEBUG)  := -DDEBUG
> +subdir-ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
>  
>  obj-$(CONFIG_DMA_ENGINE) += dmaengine.o
>  obj-$(CONFIG_DMA_VIRTUAL_CHANNELS) += virt-dma.o
> -- 
> 2.0.0
> 
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vinod Koul July 15, 2014, 5:31 a.m. UTC | #2
On Tue, Jul 15, 2014 at 01:15:45PM +0900, Simon Horman wrote:
> On Mon, Jul 14, 2014 at 10:47:26PM +0200, Wolfram Sang wrote:
> > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > 
> > To be able to see debug messages during boot, enable the debug settings
> > from Kconfig also for drivers in subdirectories.
> 
> Thanks, I have added this to the shdma-for-v3.17 branch.
Sorry, but this belong to dmaengine tree!
Simon Horman July 15, 2014, 7:44 a.m. UTC | #3
On Tue, Jul 15, 2014 at 11:01:46AM +0530, Vinod Koul wrote:
> On Tue, Jul 15, 2014 at 01:15:45PM +0900, Simon Horman wrote:
> > On Mon, Jul 14, 2014 at 10:47:26PM +0200, Wolfram Sang wrote:
> > > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > 
> > > To be able to see debug messages during boot, enable the debug settings
> > > from Kconfig also for drivers in subdirectories.
> > 
> > Thanks, I have added this to the shdma-for-v3.17 branch.
> Sorry, but this belong to dmaengine tree!

Thanks, I will drop it.

> -- 
> ~Vinod
> 
> > 
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > ---
> > >  drivers/dma/Makefile | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
> > > index c779e1eb2db2..aca5eb577d44 100644
> > > --- a/drivers/dma/Makefile
> > > +++ b/drivers/dma/Makefile
> > > @@ -1,5 +1,5 @@
> > > -ccflags-$(CONFIG_DMADEVICES_DEBUG)  := -DDEBUG
> > > -ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
> > > +subdir-ccflags-$(CONFIG_DMADEVICES_DEBUG)  := -DDEBUG
> > > +subdir-ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
> > >  
> > >  obj-$(CONFIG_DMA_ENGINE) += dmaengine.o
> > >  obj-$(CONFIG_DMA_VIRTUAL_CHANNELS) += virt-dma.o
> > > -- 
> > > 2.0.0
> > > 
> 
> -- 
> 
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vinod Koul July 15, 2014, 4:18 p.m. UTC | #4
On Mon, Jul 14, 2014 at 10:47:26PM +0200, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> To be able to see debug messages during boot, enable the debug settings
> from Kconfig also for drivers in subdirectories.
> 
Applied, thanks
diff mbox

Patch

diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
index c779e1eb2db2..aca5eb577d44 100644
--- a/drivers/dma/Makefile
+++ b/drivers/dma/Makefile
@@ -1,5 +1,5 @@ 
-ccflags-$(CONFIG_DMADEVICES_DEBUG)  := -DDEBUG
-ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
+subdir-ccflags-$(CONFIG_DMADEVICES_DEBUG)  := -DDEBUG
+subdir-ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
 
 obj-$(CONFIG_DMA_ENGINE) += dmaengine.o
 obj-$(CONFIG_DMA_VIRTUAL_CHANNELS) += virt-dma.o