diff mbox

[1/1] dmaengine: of: kconfig: select DMA_ENGINE when DMA_OF is selected

Message ID 1406721531-23635-1-git-send-email-a13xp0p0v88@gmail.com (mailing list archive)
State Accepted
Commit 2795eedf2fbd
Delegated to: Vinod Koul
Headers show

Commit Message

Alexander Popov July 30, 2014, 11:58 a.m. UTC
Select DMA_ENGINE when DMA_OF is selected since
of_dma_xlate_by_chan_id() from drivers/dma/of-dma.c uses
dma_get_slave_channel() from drivers/dma/dmaengine.c

Signed-off-by: Alexander Popov <a13xp0p0v88@gmail.com>
---
 drivers/dma/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Vinod Koul July 30, 2014, 1:38 p.m. UTC | #1
On Wed, Jul 30, 2014 at 03:58:51PM +0400, Alexander Popov wrote:
> Select DMA_ENGINE when DMA_OF is selected since
> of_dma_xlate_by_chan_id() from drivers/dma/of-dma.c uses
> dma_get_slave_channel() from drivers/dma/dmaengine.c
>
Please give credit to reporter by adding "Reported-by:" tag in commit

It is also got practice to give error log 
> Signed-off-by: Alexander Popov <a13xp0p0v88@gmail.com>

Applied, now after adding reported tag and error log
Alexander Popov July 30, 2014, 2:12 p.m. UTC | #2
2014-07-30 17:38 GMT+04:00 Vinod Koul <vinod.koul@intel.com>:
> On Wed, Jul 30, 2014 at 03:58:51PM +0400, Alexander Popov wrote:
>> Select DMA_ENGINE when DMA_OF is selected since
>> of_dma_xlate_by_chan_id() from drivers/dma/of-dma.c uses
>> dma_get_slave_channel() from drivers/dma/dmaengine.c
>>
> Please give credit to reporter by adding "Reported-by:" tag in commit
> It is also got practice to give error log
Ok, I got it.

>> Signed-off-by: Alexander Popov <a13xp0p0v88@gmail.com>
> Applied, now after adding reported tag and error log
Thanks, Vinod.

Best regards,
Alexander
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 1eca7b9..f887b19 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -388,6 +388,7 @@  config DMA_ACPI
 config DMA_OF
 	def_bool y
 	depends on OF
+	select DMA_ENGINE
 
 comment "DMA Clients"
 	depends on DMA_ENGINE