dmaengine: Mark the struct dma_slave_config direction field deprecated

Commit Message

Laurent Pinchart Aug. 20, 2014, 5:20 p.m. UTC

The direction passed to the device_prep_slave_sg, device_prep_dma_cyclic
or device_prep_interleaved_dma (through struct dma_interleaved_template)
should be used instead.

Signed-off-by: Laurent Pinchart <[e-mail]>
---
 include/linux/dmaengine.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Vinod Koul Sept. 23, 2014, 2:56 p.m. UTC | #1

On Wed, Aug 20, 2014 at 07:20:53PM +0200, Laurent Pinchart wrote:
> The direction passed to the device_prep_slave_sg, device_prep_dma_cyclic
> or device_prep_interleaved_dma (through struct dma_interleaved_template)
> should be used instead.
> 
Applied, thanks

Patch

diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index 0c4e65a..0c6481f 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -310,7 +310,9 @@  enum dma_slave_buswidth {
  * struct dma_slave_config - dma slave channel runtime config
  * @direction: whether the data shall go in or out on this slave
  * channel, right now. DMA_MEM_TO_DEV and DMA_DEV_TO_MEM are
- * legal values.
+ * legal values. DEPRECATED, drivers should use the direction argument
+ * to the device_prep_slave_sg and device_prep_dma_cyclic functions or
+ * the dir field in the dma_interleaved_template structure.
  * @src_addr: this is the physical address where DMA slave data
  * should be read (RX), if the source is memory this argument is
  * ignored.