From patchwork Wed Feb 4 13:03:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 5776381 Return-Path: X-Original-To: patchwork-dmaengine@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 214B79F302 for ; Wed, 4 Feb 2015 13:03:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 54B8B201E4 for ; Wed, 4 Feb 2015 13:03:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 84EB420149 for ; Wed, 4 Feb 2015 13:03:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965309AbbBDNDz (ORCPT ); Wed, 4 Feb 2015 08:03:55 -0500 Received: from mail-we0-f178.google.com ([74.125.82.178]:38454 "EHLO mail-we0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965788AbbBDNDy (ORCPT ); Wed, 4 Feb 2015 08:03:54 -0500 Received: by mail-we0-f178.google.com with SMTP id k48so1592038wev.9; Wed, 04 Feb 2015 05:03:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=sjNrVNiW0aPcAimh14Jg4L9rWdXJXYLNVGdGQR+vAvE=; b=jt+z+SqyBMrpKfj567ivfwxLvzTvuqWETCcl6aad8bjShVmRLm6aYPql4c0pRmO3yk 44KPNzYtm1vq2nJ9rT/YptMGYrHtAz+pOxlQ+AP7PttvSAF1/nFO40enV3PrjmOOqqds T/xWGvk7BwMcd53gvUCa6iBe0RCj4DKi5yM1MAiPqlmbI4KhaynxAi5oooB8FhwxuFm0 gXP8jABneP8JyhxQ8zwLL8gjFE/YLdXd7yaHsgZLAsIfTeqndZALlW9M0+lHJoTmdLaP qdKyHdtHy2iuAx3dG82TV3ew2QUwTd+PGneVTPEczX6bfqkC16bg3gK2kv1DQSzklB8U rjuQ== X-Received: by 10.180.75.168 with SMTP id d8mr45450722wiw.74.1423055033221; Wed, 04 Feb 2015 05:03:53 -0800 (PST) Received: from tango-charlie.RL.local ([194.72.83.162]) by mx.google.com with ESMTPSA id dj4sm2664664wjc.13.2015.02.04.05.03.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 04 Feb 2015 05:03:52 -0800 (PST) From: Lad Prabhakar To: Vinod Koul , Dan Williams , dmaengine@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Lad, Prabhakar" Subject: [PATCH] dma/edma.c: fix sparse warnings Date: Wed, 4 Feb 2015 13:03:27 +0000 Message-Id: <1423055007-32102-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: "Lad, Prabhakar" this patch fixes following sparse warnings: edma.c:537:32: warning: symbol 'edma_prep_dma_memcpy' was not declared. Should it be static? edma.c:1070:6: warning: symbol 'edma_filter_fn' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar --- Found this issue on linux-next (arm-cortex-a8-gcc version 4.7.3, sparse version 0.4.5-rc1)and applies on top linux-next. drivers/dma/edma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index e95fa7d..276157f 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c @@ -15,6 +15,7 @@ #include #include +#include #include #include #include @@ -534,7 +535,7 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg( return vchan_tx_prep(&echan->vchan, &edesc->vdesc, tx_flags); } -struct dma_async_tx_descriptor *edma_prep_dma_memcpy( +static struct dma_async_tx_descriptor *edma_prep_dma_memcpy( struct dma_chan *chan, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long tx_flags) {