| Message ID | 1434356716-32726-1-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Jun 15, 2015 at 05:25:16PM +0900, Krzysztof Kozlowski wrote: > During memcpy operations the residue was always set to an u32 overflowed > value. > > In pl330_tx_status() function number of currently transferred bytes was > subtracted from internal "bytes_requested" field. However this > "bytes_requested" was not initialized at start to length of memcpy > buffer so transferred bytes were subtracted from 0 causing overflow. Applied, thanks
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index f513f77b1d85..c535cd059724 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -2623,6 +2623,7 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst, desc->rqcfg.brst_len = 1; desc->rqcfg.brst_len = get_burst_len(desc, len); + desc->bytes_requested = len; desc->txd.flags = flags;
During memcpy operations the residue was always set to an u32 overflowed value. In pl330_tx_status() function number of currently transferred bytes was subtracted from internal "bytes_requested" field. However this "bytes_requested" was not initialized at start to length of memcpy buffer so transferred bytes were subtracted from 0 causing overflow. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Cc: <stable@vger.kernel.org> Fixes: aee4d1fac887 ("dmaengine: pl330: improve pl330_tx_status() function") --- drivers/dma/pl330.c | 1 + 1 file changed, 1 insertion(+)