From patchwork Fri Jul 10 14:13:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 6766241 Return-Path: X-Original-To: patchwork-dmaengine@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6812CC05AC for ; Fri, 10 Jul 2015 14:13:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 65DC920681 for ; Fri, 10 Jul 2015 14:13:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74D862068A for ; Fri, 10 Jul 2015 14:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754251AbbGJON0 (ORCPT ); Fri, 10 Jul 2015 10:13:26 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:35199 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754489AbbGJONZ (ORCPT ); Fri, 10 Jul 2015 10:13:25 -0400 Received: by pdrg1 with SMTP id g1so53164847pdr.2 for ; Fri, 10 Jul 2015 07:13:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=hCmtbDd7GXH1c4jhRHo31MG0u8qLUOo3PBZkofWzpoA=; b=D0urDgqaVaUZMwy0UlyNGJ4SHyV43Ocw5sKGKPEHs24FP1vYet85yoku70TTzblvga XQI8a89StIJ3tLxTsMltor4FnYexbjLg0+o1X4F1++sAqQstd0A+Dqamo8VkFW096UHf IrseyFhMARY8yJGsLdBjXl39+q/1Janw9/hs+PJlh0k3DRoN795K96fkm/pUnrjuLl9T WSw1FtTLidhY8GWl6t0G5i0fHjbKf3Wko5n8sRnVhx1lomkYc4D33Xz+2aArcultzk9l ByXLV+mTF7YWQDhJALvO0ndyxV2nkM2gk8qxUQwrBBL7WRpj5KiojYwZ72kgL8JFeY6j TbsA== X-Gm-Message-State: ALoCoQmhTBA0ivXIG4gS+YtDUV2WsgtVIq8gseGeSlZVehcZeXDprxe9augNjEBGDthqxdCxzx2M X-Received: by 10.66.63.70 with SMTP id e6mr41981343pas.62.1436537604892; Fri, 10 Jul 2015 07:13:24 -0700 (PDT) Received: from phoenix.local (218-164-28-88.dynamic.hinet.net. [218.164.28.88]) by smtp.gmail.com with ESMTPSA id a7sm9399030pbu.0.2015.07.10.07.13.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Jul 2015 07:13:23 -0700 (PDT) Message-ID: <1436537599.10674.1.camel@ingics.com> Subject: [PATCH] dma: ti-dma-crossbar: Fix checking return value of devm_ioremap_resource From: Axel Lin To: Vinod Koul Cc: Peter Ujfalusi , Dan Williams , dmaengine@vger.kernel.org Date: Fri, 10 Jul 2015 22:13:19 +0800 X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP devm_ioremap_resource returns ERR_PTR on failure. Signed-off-by: Axel Lin --- drivers/dma/ti-dma-crossbar.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/dma/ti-dma-crossbar.c b/drivers/dma/ti-dma-crossbar.c index 24f5ca2..5e261d1 100644 --- a/drivers/dma/ti-dma-crossbar.c +++ b/drivers/dma/ti-dma-crossbar.c @@ -139,12 +139,9 @@ static int ti_dma_xbar_probe(struct platform_device *pdev) xbar->safe_val = (u16)safe_val; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; - iomem = devm_ioremap_resource(&pdev->dev, res); - if (!iomem) - return -ENOMEM; + if (IS_ERR(iomem)) + return PTR_ERR(iomem); xbar->iomem = iomem;