From patchwork Tue Sep 29 20:44:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: hamzahfrq.sub@gmail.com X-Patchwork-Id: 7289891 Return-Path: X-Original-To: patchwork-dmaengine@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 67B289F4DC for ; Tue, 29 Sep 2015 20:45:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8D7952060A for ; Tue, 29 Sep 2015 20:45:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA9DF2066F for ; Tue, 29 Sep 2015 20:45:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754499AbbI2UpW (ORCPT ); Tue, 29 Sep 2015 16:45:22 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:37656 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754329AbbI2UpP (ORCPT ); Tue, 29 Sep 2015 16:45:15 -0400 Received: by wicfx3 with SMTP id fx3so33525788wic.0; Tue, 29 Sep 2015 13:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=+JeNfAkV+OShsoYHyuto3Xs5kFVvvLNeSMApxDBjB/s=; b=PX8PtB1FPAaYEI+BR02dF4FQ8R6PTOs+dVyiVWNZk0n6zghEK6lna3nAmlhUW7g+JZ 6VsOIEqbVZFnU2t31LnL+b3A5Id1zwJkhfkJW0kywzg+xWWBHxlQUXj/tEzwSXWfnd9z 33or6U+76xrE7U5tosdJIWxB+7gvPLGtWKBF923M9eecbiiVP9Mju50hMSEcI9972V4E OLtTpUkpb8Bu1Zrq76+BYG41KiSGIbdyyVvGwD7/MZk3VEpz8dvDVvR6zBszDNYghaej g9wJY1zAW4+cqNcKwfOC2xdtUzWkrv1X1k8CbTCkjJtlRbdlhEFglVb50QOQhAolAsyP vZvw== X-Received: by 10.194.203.5 with SMTP id km5mr41956wjc.52.1443559513084; Tue, 29 Sep 2015 13:45:13 -0700 (PDT) Received: from ubuntu-VirtualBox.fritz.box (p5B02D56B.dip0.t-ipconnect.de. [91.2.213.107]) by smtp.googlemail.com with ESMTPSA id c2sm25721838wiy.11.2015.09.29.13.45.11 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 29 Sep 2015 13:45:12 -0700 (PDT) From: hamzahfrq.sub@gmail.com Cc: dmaengine@vger.kernel.org, j@bitron.ch, joe@perches.com, kuninori.morimoto.gx@renesas.com, broonie@kernel.org, geert+renesas@glider.be, vinod.koul@intel.com, laurent.pinchart+renesas@ideasonboard.com, linux-sh@vger.kernel.org, jacob@teenageengineering.com, Muhammad Hamza Farooq Subject: [PATCH v3 5/6] dma: rcar-dma: warn if transfer cannot start as TE = 1 Date: Tue, 29 Sep 2015 22:44:47 +0200 Message-Id: <1443559488-2416-6-git-send-email-hamzahfrq.sub@gmail.com> X-Mailer: git-send-email 1.7.9.5 To: unlisted-recipients:; (no To-header on input) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Muhammad Hamza Farooq Signed-off-by: Muhammad Hamza Farooq --- drivers/dma/sh/rcar-dmac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c index 0b5a367..6eec878 100644 --- a/drivers/dma/sh/rcar-dmac.c +++ b/drivers/dma/sh/rcar-dmac.c @@ -327,7 +327,8 @@ static void rcar_dmac_chan_start_xfer(struct rcar_dmac_chan *chan) struct rcar_dmac_desc *desc = chan->desc.running; u32 chcr = desc->chcr; - WARN_ON_ONCE(rcar_dmac_chan_is_busy(chan)); + WARN_ON_ONCE(rcar_dmac_chan_is_busy(chan) || + rcar_dmac_last_tx_complete(chan)); if (chan->mid_rid >= 0) rcar_dmac_chan_write(chan, RCAR_DMARS, chan->mid_rid);