diff mbox

dmaengine: zxdma: fix memset that is currently doing nothing

Message ID 1444323694-3189-1-git-send-email-colin.king@canonical.com (mailing list archive)
State Rejected
Headers show

Commit Message

Colin King Oct. 8, 2015, 5:01 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The size and value arguments are swapped in the call to memset
effectively making it a no-op because of the zero size.  Swap
these arguments around to do the memset correctly.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/dma/zx296702_dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vinod Koul Oct. 9, 2015, 3:50 p.m. UTC | #1 
On Thu, Oct 08, 2015 at 06:01:34PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The size and value arguments are swapped in the call to memset
> effectively making it a no-op because of the zero size.  Swap
> these arguments around to do the memset correctly.

Sorry you are late! You should always sync to target tree before generating
a patch

commit 1a492ac2b87b05c8a175478e79d3c74511c74921
Author: Vinod Koul <vinod.koul@intel.com>
Date:   Thu Oct 1 07:11:48 2015 +0530

    dmaengine: zxdma: fix memset call
    
    Fix the call to memset in this driver
    [linux-4.2-next-20150911/drivers/dma/zx296702_dma.c:444]: (warning)
    memset() called to fill 0 bytes of 'ds'.
    
    Reported-by: David Binderman <dcb314@hotmail.com>
    Signed-off-by: Vinod Koul <vinod.koul@intel.com>
diff mbox

Patch

diff --git a/drivers/dma/zx296702_dma.c b/drivers/dma/zx296702_dma.c
index c017fcd..245d759 100644
--- a/drivers/dma/zx296702_dma.c
+++ b/drivers/dma/zx296702_dma.c
@@ -441,7 +441,7 @@  static struct zx_dma_desc_sw *zx_alloc_desc_resource(int num,
 		kfree(ds);
 		return NULL;
 	}
-	memset(ds->desc_hw, sizeof(struct zx_desc_hw) * num, 0);
+	memset(ds->desc_hw, 0, sizeof(struct zx_desc_hw) * num);
 	ds->desc_num = num;
 	return ds;
 }