| Message ID | 1455225798-9510-2-git-send-email-robert.jarzmik@free.fr (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Thursday 11 February 2016 22:23:15 Robert Jarzmik wrote: > @@ -12,6 +12,8 @@ Required properties: > Optional properties: > - #dma-channels: Number of DMA channels supported by the controller (defaults > to 32 when not specified) > +- #requestors: Number of DMA requestor lines supported by the controller > + (defaults to 0 when not specified) > > Most other ones use "#dma-requests" as the property name here, I think it makes sense to stay with that convention. Arnd -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Arnd Bergmann <arnd@arndb.de> writes: > On Thursday 11 February 2016 22:23:15 Robert Jarzmik wrote: >> @@ -12,6 +12,8 @@ Required properties: >> Optional properties: >> - #dma-channels: Number of DMA channels supported by the controller (defaults >> to 32 when not specified) >> +- #requestors: Number of DMA requestor lines supported by the controller >> + (defaults to 0 when not specified) >> >> > > Most other ones use "#dma-requests" as the property name here, I think it makes > sense to stay with that convention. Most certainly, for v2. I'll await for a couple of days for other reviews, especially Vinod's one and Haojian's ack for the .h change. Cheers.
diff --git a/Documentation/devicetree/bindings/dma/mmp-dma.txt b/Documentation/devicetree/bindings/dma/mmp-dma.txt index 7a802f64e5bd..716b70338a15 100644 --- a/Documentation/devicetree/bindings/dma/mmp-dma.txt +++ b/Documentation/devicetree/bindings/dma/mmp-dma.txt @@ -12,6 +12,8 @@ Required properties: Optional properties: - #dma-channels: Number of DMA channels supported by the controller (defaults to 32 when not specified) +- #requestors: Number of DMA requestor lines supported by the controller + (defaults to 0 when not specified) "marvell,pdma-1.0" Used platforms: pxa25x, pxa27x, pxa3xx, pxa93x, pxa168, pxa910, pxa688.
For pxa based platforms, the number of requestor lines should be specified, so that the driver can check if the flow control should be activated (when a requestor line is asked for) or not. Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> --- Documentation/devicetree/bindings/dma/mmp-dma.txt | 2 ++ 1 file changed, 2 insertions(+)