diff mbox

[v1,1/1] dmaengine: idma64: fix typo in WR_ISSUE_THD(x)

Message ID 1455614885-29593-1-git-send-email-andriy.shevchenko@linux.intel.com (mailing list archive)
State Accepted
Headers show

Commit Message

Andy Shevchenko Feb. 16, 2016, 9:28 a.m. UTC
There is a typo in the definition of IDMA64C_CFGH_WR_ISSUE_THD(x). Fix it by
swapping characters.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/dma/idma64.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vinod Koul Feb. 22, 2016, 3:37 a.m. UTC | #1
On Tue, Feb 16, 2016 at 11:28:05AM +0200, Andy Shevchenko wrote:
> There is a typo in the definition of IDMA64C_CFGH_WR_ISSUE_THD(x). Fix it by
> swapping characters.

And this is unused, so why did we define :D

Applied, anyway
Andy Shevchenko Feb. 22, 2016, 8:57 a.m. UTC | #2
On Mon, 2016-02-22 at 09:07 +0530, Vinod Koul wrote:
> On Tue, Feb 16, 2016 at 11:28:05AM +0200, Andy Shevchenko wrote:
> > There is a typo in the definition of IDMA64C_CFGH_WR_ISSUE_THD(x).
> > Fix it by
> > swapping characters.
> 
> And this is unused, so why did we define :D

During development we was fighting against one issue when transfer
wasn't started. I guess this is leftover from that times.
Though I think it will be useful to have just in case of debugging in
the future.

> Applied, anyway

Thanks!
diff mbox

Patch

diff --git a/drivers/dma/idma64.h b/drivers/dma/idma64.h
index 8423f13..dc68744 100644
--- a/drivers/dma/idma64.h
+++ b/drivers/dma/idma64.h
@@ -71,7 +71,7 @@ 
 #define IDMA64C_CFGH_SRC_PER(x)		((x) << 0)	/* src peripheral */
 #define IDMA64C_CFGH_DST_PER(x)		((x) << 4)	/* dst peripheral */
 #define IDMA64C_CFGH_RD_ISSUE_THD(x)	((x) << 8)
-#define IDMA64C_CFGH_RW_ISSUE_THD(x)	((x) << 18)
+#define IDMA64C_CFGH_WR_ISSUE_THD(x)	((x) << 18)
 
 /* Interrupt registers */