| Message ID | 1461152599-28858-1-git-send-email-appanad@xilinx.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Wed, 2016-04-20 at 17:13:18 +0530, Kedareswara rao Appana wrote: > This patch updates the binding doc with clock description > for vdma. > > Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> > --- > Changes for v2: > --> Listed down all the clocks supported by the h/w > as suggested by the Datta. > --> Used IP clock names instead of shortcut clock names. > > Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > index fcc2b65..afe9eb7 100644 > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > @@ -21,6 +21,11 @@ Required properties: > - dma-channel child node: Should have at least one channel and can have up to > two channels per device. This node specifies the properties of each > DMA channel (see child node properties below). > +- clocks: Input clock specifier. Refer to common clock bindings. > +- clock-names: List of input clocks "s_axi_lite_aclk", "m_axi_mm2s_aclk" > + "m_axi_s2mm_aclk", "m_axis_mm2s_aclk", "s_axis_s2mm_aclk" > + (list of input cloks may vary based on the ip configuration. s/cloks/clocks Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com> Sören -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
SGkgU29yZW4sCQ0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFPDtnJl biBCcmlua21hbm4gW21haWx0bzpzb3Jlbi5icmlua21hbm5AeGlsaW54LmNvbV0NCj4gU2VudDog V2VkbmVzZGF5LCBBcHJpbCAyMCwgMjAxNiA3OjU4IFBNDQo+IFRvOiBBcHBhbmEgRHVyZ2EgS2Vk YXJlc3dhcmEgUmFvIDxhcHBhbmFkQHhpbGlueC5jb20+DQo+IENjOiByb2JoK2R0QGtlcm5lbC5v cmc7IHBhd2VsLm1vbGxAYXJtLmNvbTsgbWFyay5ydXRsYW5kQGFybS5jb207DQo+IGlqYytkZXZp Y2V0cmVlQGhlbGxpb24ub3JnLnVrOyBnYWxha0Bjb2RlYXVyb3JhLm9yZzsgTWljaGFsIFNpbWVr DQo+IDxtaWNoYWxzQHhpbGlueC5jb20+OyB2aW5vZC5rb3VsQGludGVsLmNvbTsgZGFuLmoud2ls bGlhbXNAaW50ZWwuY29tOw0KPiBBcHBhbmEgRHVyZ2EgS2VkYXJlc3dhcmEgUmFvIDxhcHBhbmFk QHhpbGlueC5jb20+Ow0KPiBtb3JpdHouZmlzY2hlckBldHR1cy5jb207IGxhdXJlbnQucGluY2hh cnRAaWRlYXNvbmJvYXJkLmNvbTsNCj4gbHVpc0BkZWJldGhlbmNvdXJ0LmNvbTsgQW5pcnVkaGEg U2FyYW5naSA8YW5pcnVkaEB4aWxpbnguY29tPjsgUHVubmFpYWgNCj4gQ2hvdWRhcnkgS2FsbHVy aSA8cHVubmFpYUB4aWxpbnguY29tPjsgU2h1YmhyYWp5b3RpIERhdHRhDQo+IDxzaHViaHJhakB4 aWxpbnguY29tPjsgZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWFybS0NCj4ga2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7DQo+ IGRtYWVuZ2luZUB2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAxLzJd IERvY3VtZW50YXRpb246IERUOiB2ZG1hOiBBZGQgY2xvY2sgc3VwcG9ydCBmb3INCj4gdmRtYQ0K PiANCj4gT24gV2VkLCAyMDE2LTA0LTIwIGF0IDE3OjEzOjE4ICswNTMwLCBLZWRhcmVzd2FyYSBy YW8gQXBwYW5hIHdyb3RlOg0KPiA+IFRoaXMgcGF0Y2ggdXBkYXRlcyB0aGUgYmluZGluZyBkb2Mg d2l0aCBjbG9jayBkZXNjcmlwdGlvbiBmb3IgdmRtYS4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6 IEtlZGFyZXN3YXJhIHJhbyBBcHBhbmEgPGFwcGFuYWRAeGlsaW54LmNvbT4NCj4gPiAtLS0NCj4g PiBDaGFuZ2VzIGZvciB2MjoNCj4gPiAtLT4gTGlzdGVkIGRvd24gYWxsIHRoZSBjbG9ja3Mgc3Vw cG9ydGVkIGJ5IHRoZSBoL3cNCj4gPiAgICAgYXMgc3VnZ2VzdGVkIGJ5IHRoZSBEYXR0YS4NCj4g PiAtLT4gVXNlZCBJUCBjbG9jayBuYW1lcyBpbnN0ZWFkIG9mIHNob3J0Y3V0IGNsb2NrIG5hbWVz Lg0KPiA+DQo+ID4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEveGlsaW54 L3hpbGlueF92ZG1hLnR4dCB8IDgNCj4gPiArKysrKysrKw0KPiA+ICAxIGZpbGUgY2hhbmdlZCwg OCBpbnNlcnRpb25zKCspDQo+ID4NCj4gPiBkaWZmIC0tZ2l0DQo+ID4gYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvZG1hL3hpbGlueC94aWxpbnhfdmRtYS50eHQNCj4gPiBiL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEveGlsaW54L3hpbGlueF92ZG1hLnR4 dA0KPiA+IGluZGV4IGZjYzJiNjUuLmFmZTllYjcgMTAwNjQ0DQo+ID4gLS0tIGEvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RtYS94aWxpbngveGlsaW54X3ZkbWEudHh0DQo+ID4g KysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RtYS94aWxpbngveGlsaW54 X3ZkbWEudHh0DQo+ID4gQEAgLTIxLDYgKzIxLDExIEBAIFJlcXVpcmVkIHByb3BlcnRpZXM6DQo+ ID4gIC0gZG1hLWNoYW5uZWwgY2hpbGQgbm9kZTogU2hvdWxkIGhhdmUgYXQgbGVhc3Qgb25lIGNo YW5uZWwgYW5kIGNhbiBoYXZlIHVwDQo+IHRvDQo+ID4gIAl0d28gY2hhbm5lbHMgcGVyIGRldmlj ZS4gVGhpcyBub2RlIHNwZWNpZmllcyB0aGUgcHJvcGVydGllcyBvZiBlYWNoDQo+ID4gIAlETUEg Y2hhbm5lbCAoc2VlIGNoaWxkIG5vZGUgcHJvcGVydGllcyBiZWxvdykuDQo+ID4gKy0gY2xvY2tz OiBJbnB1dCBjbG9jayBzcGVjaWZpZXIuIFJlZmVyIHRvIGNvbW1vbiBjbG9jayBiaW5kaW5ncy4N Cj4gPiArLSBjbG9jay1uYW1lczogTGlzdCBvZiBpbnB1dCBjbG9ja3MgInNfYXhpX2xpdGVfYWNs ayIsICJtX2F4aV9tbTJzX2FjbGsiDQo+ID4gKwkgICAgICAgIm1fYXhpX3MybW1fYWNsayIsICJt X2F4aXNfbW0yc19hY2xrIiwgInNfYXhpc19zMm1tX2FjbGsiDQo+ID4gKwkgICAgICAgKGxpc3Qg b2YgaW5wdXQgY2xva3MgbWF5IHZhcnkgYmFzZWQgb24gdGhlIGlwIGNvbmZpZ3VyYXRpb24uDQo+ IA0KPiBzL2Nsb2tzL2Nsb2Nrcw0KDQpPayB3aWxsIGZpeCBpbiBuZXh0IHZlcnNpb24uLi4NCj4g DQo+IEFja2VkLWJ5OiBTw7ZyZW4gQnJpbmttYW5uIDxzb3Jlbi5icmlua21hbm5AeGlsaW54LmNv bT4NCg0KVGhhbmtzIGZvciB0aGUgYWNrLi4uDQoNClJlZ2FyZHMsDQpLZWRhci4NCg0KPiANCj4g CVPDtnJlbg0K -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Apr 20, 2016 at 05:13:18PM +0530, Kedareswara rao Appana wrote: > This patch updates the binding doc with clock description > for vdma. > > Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> > --- > Changes for v2: > --> Listed down all the clocks supported by the h/w > as suggested by the Datta. > --> Used IP clock names instead of shortcut clock names. > > Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > index fcc2b65..afe9eb7 100644 > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > @@ -21,6 +21,11 @@ Required properties: > - dma-channel child node: Should have at least one channel and can have up to > two channels per device. This node specifies the properties of each > DMA channel (see child node properties below). > +- clocks: Input clock specifier. Refer to common clock bindings. > +- clock-names: List of input clocks "s_axi_lite_aclk", "m_axi_mm2s_aclk" > + "m_axi_s2mm_aclk", "m_axis_mm2s_aclk", "s_axis_s2mm_aclk" > + (list of input cloks may vary based on the ip configuration. s/cloks/clocks/ > + see clock bindings for more info). This does not make sense. The common clock binding is going to tell me more about how the clocks vary? You need to define here how the clocks can vary. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, Thanks for the review... > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: Saturday, April 23, 2016 1:07 AM > To: Appana Durga Kedareswara Rao <appanad@xilinx.com> > Cc: pawel.moll@arm.com; mark.rutland@arm.com; > ijc+devicetree@hellion.org.uk; galak@codeaurora.org; Michal Simek > <michals@xilinx.com>; Soren Brinkmann <sorenb@xilinx.com>; > vinod.koul@intel.com; dan.j.williams@intel.com; Appana Durga Kedareswara > Rao <appanad@xilinx.com>; moritz.fischer@ettus.com; > laurent.pinchart@ideasonboard.com; luis@debethencourt.com; Anirudha > Sarangi <anirudh@xilinx.com>; Punnaiah Choudary Kalluri > <punnaia@xilinx.com>; Shubhrajyoti Datta <shubhraj@xilinx.com>; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; dmaengine@vger.kernel.org > Subject: Re: [PATCH v2 1/2] Documentation: DT: vdma: Add clock support for > vdma > > On Wed, Apr 20, 2016 at 05:13:18PM +0530, Kedareswara rao Appana wrote: > > This patch updates the binding doc with clock description for vdma. > > > > Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> > > --- > > Changes for v2: > > --> Listed down all the clocks supported by the h/w > > as suggested by the Datta. > > --> Used IP clock names instead of shortcut clock names. > > > > Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 8 > > ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > index fcc2b65..afe9eb7 100644 > > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > @@ -21,6 +21,11 @@ Required properties: > > - dma-channel child node: Should have at least one channel and can have up > to > > two channels per device. This node specifies the properties of each > > DMA channel (see child node properties below). > > +- clocks: Input clock specifier. Refer to common clock bindings. > > +- clock-names: List of input clocks "s_axi_lite_aclk", "m_axi_mm2s_aclk" > > + "m_axi_s2mm_aclk", "m_axis_mm2s_aclk", "s_axis_s2mm_aclk" > > + (list of input cloks may vary based on the ip configuration. > > s/cloks/clocks/ > > > + see clock bindings for more info). > > This does not make sense. The common clock binding is going to tell me more > about how the clocks vary? I have fixed these comments in the other version (v4) you acked that patch... Regards, Kedar. > > You need to define here how the clocks can vary. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt index fcc2b65..afe9eb7 100644 --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt @@ -21,6 +21,11 @@ Required properties: - dma-channel child node: Should have at least one channel and can have up to two channels per device. This node specifies the properties of each DMA channel (see child node properties below). +- clocks: Input clock specifier. Refer to common clock bindings. +- clock-names: List of input clocks "s_axi_lite_aclk", "m_axi_mm2s_aclk" + "m_axi_s2mm_aclk", "m_axis_mm2s_aclk", "s_axis_s2mm_aclk" + (list of input cloks may vary based on the ip configuration. + see clock bindings for more info). Required properties for VDMA: - xlnx,num-fstores: Should be the number of framebuffers as configured in h/w. @@ -60,6 +65,9 @@ axi_vdma_0: axivdma@40030000 { xlnx,num-fstores = <0x8>; xlnx,flush-fsync = <0x1>; xlnx,addrwidth = <0x20>; + clocks = <&clk 0>, <&clk 1>, <&clk 2>, <&clk 3>, <&clk 4>; + clock-names = "s_axi_lite_aclk", "m_axi_mm2s_aclk", "m_axi_s2mm_aclk", + "m_axis_mm2s_aclk", "s_axis_s2mm_aclk"; dma-channel@40030000 { compatible = "xlnx,axi-vdma-mm2s-channel"; interrupts = < 0 54 4 >;
This patch updates the binding doc with clock description for vdma. Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> --- Changes for v2: --> Listed down all the clocks supported by the h/w as suggested by the Datta. --> Used IP clock names instead of shortcut clock names. Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 8 ++++++++ 1 file changed, 8 insertions(+)