diff mbox

[-next] dmaengine: qcom_hidma: remove unneeded of_node_put()

Message ID 1477147134-3038-1-git-send-email-weiyj.lk@gmail.com (mailing list archive)
State Accepted
Headers show

Commit Message

Wei Yongjun Oct. 22, 2016, 2:38 p.m. UTC 
From: Wei Yongjun <weiyongjun1@huawei.com>

Device node iterators put the previous value of the index variable, so an
explicit put causes a double put.

Generated by: scripts/coccinelle/iterators/device_node_continue.cocci

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/dma/qcom/hidma_mgmt.c | 1 -
 1 file changed, 1 deletion(-)




--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Vinod Koul Nov. 14, 2016, 3:38 a.m. UTC | #1 
On Sat, Oct 22, 2016 at 02:38:54PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Device node iterators put the previous value of the index variable, so an
> explicit put causes a double put.
> 
> Generated by: scripts/coccinelle/iterators/device_node_continue.cocci

Applied, thanks
diff mbox

Patch

diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c
index 185d29c..985f5ac 100644
--- a/drivers/dma/qcom/hidma_mgmt.c
+++ b/drivers/dma/qcom/hidma_mgmt.c
@@ -402,7 +402,6 @@  static int __init hidma_mgmt_init(void)
 	for_each_matching_node(child, hidma_mgmt_match) {
 		/* device tree based firmware here */
 		hidma_mgmt_of_populate_channels(child);
-		of_node_put(child);
 	}
 #endif
 	platform_driver_register(&hidma_mgmt_driver);