| Message ID | 1485516359-4232-1-git-send-email-shailendra.v@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Jan 27, 2017 at 04:55:59PM +0530, Shailendra Verma wrote: > of_match_device could return NULL, and so cause a NULL > pointer dereference later. Why is this tagged Dma - .... Please look at he git log for the file before coming up with random tags Worst part, this patch fails to apply, so which was this generated against? > > Signed-off-by: Shailendra Verma <shailendra.v@samsung.com> > --- > drivers/dma/mv_xor.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c > index 23f7528..c25b3bb 100644 > --- a/drivers/dma/mv_xor.c > +++ b/drivers/dma/mv_xor.c > @@ -1323,7 +1323,10 @@ static int mv_xor_probe(struct platform_device *pdev) > const struct of_device_id *of_id = > of_match_device(mv_xor_dt_ids, > &pdev->dev); > + if (!of_id) { > + dev_err(&pdev->dev, "Error: No device match found\n"); > + return -ENODEV; > + } > xordev->xor_type = (uintptr_t)of_id->data; > } > > -- > 1.7.9.5 >
diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index 23f7528..c25b3bb 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1323,7 +1323,10 @@ static int mv_xor_probe(struct platform_device *pdev) const struct of_device_id *of_id = of_match_device(mv_xor_dt_ids, &pdev->dev); + if (!of_id) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } xordev->xor_type = (uintptr_t)of_id->data; } --
of_match_device could return NULL, and so cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma <shailendra.v@samsung.com> --- drivers/dma/mv_xor.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html