From patchwork Tue Feb 14 06:51:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 9571307 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DEA49601E7 for ; Tue, 14 Feb 2017 06:53:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CD4C826E77 for ; Tue, 14 Feb 2017 06:53:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C1C5820009; Tue, 14 Feb 2017 06:53:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 640ED26E77 for ; Tue, 14 Feb 2017 06:53:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752606AbdBNGwv (ORCPT ); Tue, 14 Feb 2017 01:52:51 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37972 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604AbdBNGwt (ORCPT ); Tue, 14 Feb 2017 01:52:49 -0500 Received: by mail-wm0-f54.google.com with SMTP id r141so9741935wmg.1 for ; Mon, 13 Feb 2017 22:52:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=92Sq4I4UInpzq2CbNnJQfee071l2ERx49mmNUjUXieo=; b=d1nF5go4JPVQNH3Y8kpTarhkzuVRU4ZsQAwPlpkNCiiEQMbOmQu3pdTI6B7dAhnGEc b7+N2PauZYqRO1u0L0bR3VzIEhgKCd/+0aobcYZddIYoqGkYYaEr/hF8xGav4SWByhrp vHajLhCEpCxJENHYztm9wstKc2N3QKlTFYw20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=92Sq4I4UInpzq2CbNnJQfee071l2ERx49mmNUjUXieo=; b=lLC7o8FtbR2ctmTgId3Bsx5qejNmPx5oAS4EdU5DTnSCVcPmSqpahgX5hZX2J30Cas nLnwQpI3pC22J59C58kAqQPZW+x3DYRneOnK6ARaUX5r5WAe8vsifX9Hi56o75ZziJ9O P68gOspw+VWqHB9gYQieaRjXChkYRG7op6gmhEl5sJsoEd8Z1zVn9v1wteiNbAGyW7+7 40M6DqPJMM7OTgkr7zU3qnSXsp5zpzrn3+EJ3Mm/LPmjRERy/aOjywGpUO6oy710OaGu 1S1qQbNjPgLNyqUF81W9X3dDza0XdgE65yvXFVAB1YlFxOTlAVDMxSu6VH6Aau/+mDTY q7+A== X-Gm-Message-State: AMke39lXSyu2WUkZkDVFxUvmlYPmiSh4haKiUjhq5K/7qNv88+HavmtYpITPZyKGSRyxh9Uo X-Received: by 10.28.189.195 with SMTP id n186mr1555783wmf.77.1487055162758; Mon, 13 Feb 2017 22:52:42 -0800 (PST) Received: from anup-HP-Compaq-8100-Elite-CMT-PC.dhcp.avagotech.net ([192.19.237.250]) by smtp.gmail.com with ESMTPSA id k195sm8190562wmd.7.2017.02.13.22.52.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 13 Feb 2017 22:52:42 -0800 (PST) From: Anup Patel To: Vinod Koul , Rob Herring , Mark Rutland , Herbert Xu , "David S . Miller" , Jassi Brar Cc: Dan Williams , Ray Jui , Scott Branden , Jon Mason , Rob Rice , bcm-kernel-feedback-list@broadcom.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-raid@vger.kernel.org, Anup Patel Subject: [PATCH v4 2/4] async_tx: Fix DMA_PREP_FENCE usage in do_async_gen_syndrome() Date: Tue, 14 Feb 2017 12:21:50 +0530 Message-Id: <1487055112-5185-3-git-send-email-anup.patel@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1487055112-5185-1-git-send-email-anup.patel@broadcom.com> References: <1487055112-5185-1-git-send-email-anup.patel@broadcom.com> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The DMA_PREP_FENCE is to be used when preparing Tx descriptor if output of Tx descriptor is to be used by next/dependent Tx descriptor. The DMA_PREP_FENSE will not be set correctly in do_async_gen_syndrome() when calling dma->device_prep_dma_pq() under following conditions: 1. ASYNC_TX_FENCE not set in submit->flags 2. DMA_PREP_FENCE not set in dma_flags 3. src_cnt (= (disks - 2)) is greater than dma_maxpq(dma, dma_flags) This patch fixes DMA_PREP_FENCE usage in do_async_gen_syndrome() taking inspiration from do_async_xor() implementation. Signed-off-by: Anup Patel Reviewed-by: Ray Jui Reviewed-by: Scott Branden --- crypto/async_tx/async_pq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/crypto/async_tx/async_pq.c b/crypto/async_tx/async_pq.c index f83de99..56bd612 100644 --- a/crypto/async_tx/async_pq.c +++ b/crypto/async_tx/async_pq.c @@ -62,9 +62,6 @@ do_async_gen_syndrome(struct dma_chan *chan, dma_addr_t dma_dest[2]; int src_off = 0; - if (submit->flags & ASYNC_TX_FENCE) - dma_flags |= DMA_PREP_FENCE; - while (src_cnt > 0) { submit->flags = flags_orig; pq_src_cnt = min(src_cnt, dma_maxpq(dma, dma_flags)); @@ -83,6 +80,8 @@ do_async_gen_syndrome(struct dma_chan *chan, if (cb_fn_orig) dma_flags |= DMA_PREP_INTERRUPT; } + if (submit->flags & ASYNC_TX_FENCE) + dma_flags |= DMA_PREP_FENCE; /* Drivers force forward progress in case they can not provide * a descriptor