From patchwork Tue Aug 22 09:56:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 9914751 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9018D60381 for ; Tue, 22 Aug 2017 10:02:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D9532883F for ; Tue, 22 Aug 2017 10:02:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 926BE28854; Tue, 22 Aug 2017 10:02:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E1042883F for ; Tue, 22 Aug 2017 10:02:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932382AbdHVJ5g (ORCPT ); Tue, 22 Aug 2017 05:57:36 -0400 Received: from mail-wr0-f169.google.com ([209.85.128.169]:33718 "EHLO mail-wr0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932350AbdHVJ5e (ORCPT ); Tue, 22 Aug 2017 05:57:34 -0400 Received: by mail-wr0-f169.google.com with SMTP id a47so6384984wra.0 for ; Tue, 22 Aug 2017 02:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uiLFN68ay51CSOl/fUXfqDOc7Qgbj2P5aWAN94AqlY0=; b=XH8PBgmWpzfCp+79bQ74FEX4Zayh8SQJ44UO8WAIQIopd+2XjXVQOC2OB2l56tYtPT YuQ73sjgkswDbKaQfqq2yRrlhR2iLaJndMYHSJ1G7JDOQF0r1dcXOFHLlXqH13IQy+OM BmOqbDmVy2kALtfj+Hx+AH8Arz+NYQayq/eYU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uiLFN68ay51CSOl/fUXfqDOc7Qgbj2P5aWAN94AqlY0=; b=rY6uCAn8X/N6NP+UsQxCbl+6/RE1jhNJA0A2evrT98aCa4ykTjNKpYrXCpnA8No9vr pE/UvZXtNsxriLPeOasV/lj0Mxha38UCzr3vVoGPR89TTJojIDasqfO1Jha95vJgQwhJ ed9sDpm/nU9mFaxDkmkJsleNKL91yNKiI1Fvrs7Ux5Wdi7WOoy7Kc5rTUY9QLj95mbtg mf2f7VIjtigVQbFwTrLPUoSlz7Bz1aj+Hozd635KoEJWC3yVm4P/0hDZZh3BiFU3cYA2 dZYtEAidRnl8fktG+U1FJB6sZ+mj+al+mwsebbJtrgf1VZ8nI9l+stGSfSr3ofhOiNbB oR+w== X-Gm-Message-State: AHYfb5jZm3NVo195WKes4jzA1Mx/Hft7TjafXBV5bVgaS3BllQuayrIB iOMOkF46xaZcAxPB X-Received: by 10.28.147.10 with SMTP id v10mr71013wmd.9.1503395852664; Tue, 22 Aug 2017 02:57:32 -0700 (PDT) Received: from anup-HP-Compaq-8100-Elite-CMT-PC.dhcp.avagotech.net ([192.19.237.250]) by smtp.gmail.com with ESMTPSA id e137sm12257913wma.29.2017.08.22.02.57.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Aug 2017 02:57:30 -0700 (PDT) From: Anup Patel To: Vinod Koul , Dan Williams Cc: Florian Fainelli , Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Anup Patel Subject: [PATCH v3 01/17] dmaengine: bcm-sba-raid: Minor improvments in comments Date: Tue, 22 Aug 2017 15:26:50 +0530 Message-Id: <1503395827-19428-2-git-send-email-anup.patel@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503395827-19428-1-git-send-email-anup.patel@broadcom.com> References: <1503395827-19428-1-git-send-email-anup.patel@broadcom.com> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch does following improvments to comments: 1. Make section comments consistent across the driver by avoiding " SBA " in some of the comments 2. Add/update few more section comments Signed-off-by: Anup Patel --- drivers/dma/bcm-sba-raid.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c index e41bbc7..76999b7 100644 --- a/drivers/dma/bcm-sba-raid.c +++ b/drivers/dma/bcm-sba-raid.c @@ -48,7 +48,8 @@ #include "dmaengine.h" -/* SBA command related defines */ +/* ====== Driver macros and defines ===== */ + #define SBA_TYPE_SHIFT 48 #define SBA_TYPE_MASK GENMASK(1, 0) #define SBA_TYPE_A 0x0 @@ -88,6 +89,8 @@ #define to_sba_device(dchan) \ container_of(dchan, struct sba_device, dma_chan) +/* ===== Driver data structures ===== */ + enum sba_request_state { SBA_REQUEST_STATE_FREE = 1, SBA_REQUEST_STATE_ALLOCED = 2, @@ -164,7 +167,7 @@ struct sba_device { int reqs_free_count; }; -/* ====== SBA command helper routines ===== */ +/* ====== Command helper routines ===== */ static inline u64 __pure sba_cmd_enc(u64 cmd, u32 val, u32 shift, u32 mask) { @@ -196,7 +199,7 @@ static inline u32 __pure sba_cmd_pq_c_mdata(u32 d, u32 b1, u32 b0) ((d & SBA_C_MDATA_DNUM_MASK) << SBA_C_MDATA_DNUM_SHIFT); } -/* ====== Channel resource management routines ===== */ +/* ====== General helper routines ===== */ static struct sba_request *sba_alloc_request(struct sba_device *sba) {