diff mbox series

[3/3] dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet

Message ID 1534511023-7871-1-git-send-email-21cnbao@gmail.com (mailing list archive)
State Accepted
Headers show
Series [1/3] dmaengine: fsldma: move spin_lock_bh to spin_lock in tasklet | expand

Commit Message

Barry Song Aug. 17, 2018, 1:03 p.m. UTC 
as you are already in a tasklet, it is unnecessary to call spin_lock_bh.

Signed-off-by: Barry Song <21cnbao@gmail.com>
---
 drivers/dma/at_xdmac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ludovic Desroches Aug. 20, 2018, 9:28 a.m. UTC | #1 
On Fri, Aug 17, 2018 at 06:03:43AM -0700, Barry Song wrote:
> as you are already in a tasklet, it is unnecessary to call spin_lock_bh.
> 
> Signed-off-by: Barry Song <21cnbao@gmail.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com> 

Thanks
> ---
>  drivers/dma/at_xdmac.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index 4bf7256..4e55768 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -1600,7 +1600,7 @@ static void at_xdmac_tasklet(unsigned long data)
>  		if (atchan->status & AT_XDMAC_CIS_ROIS)
>  			dev_err(chan2dev(&atchan->chan), "request overflow error!!!");
>  
> -		spin_lock_bh(&atchan->lock);
> +		spin_lock(&atchan->lock);
>  		desc = list_first_entry(&atchan->xfers_list,
>  					struct at_xdmac_desc,
>  					xfer_node);
> @@ -1610,7 +1610,7 @@ static void at_xdmac_tasklet(unsigned long data)
>  		txd = &desc->tx_dma_desc;
>  
>  		at_xdmac_remove_xfer(atchan, desc);
> -		spin_unlock_bh(&atchan->lock);
> +		spin_unlock(&atchan->lock);
>  
>  		if (!at_xdmac_chan_is_cyclic(atchan)) {
>  			dma_cookie_complete(txd);
> -- 
> 2.7.4
>
diff mbox series

Patch

diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index 4bf7256..4e55768 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -1600,7 +1600,7 @@  static void at_xdmac_tasklet(unsigned long data)
 		if (atchan->status & AT_XDMAC_CIS_ROIS)
 			dev_err(chan2dev(&atchan->chan), "request overflow error!!!");
 
-		spin_lock_bh(&atchan->lock);
+		spin_lock(&atchan->lock);
 		desc = list_first_entry(&atchan->xfers_list,
 					struct at_xdmac_desc,
 					xfer_node);
@@ -1610,7 +1610,7 @@  static void at_xdmac_tasklet(unsigned long data)
 		txd = &desc->tx_dma_desc;
 
 		at_xdmac_remove_xfer(atchan, desc);
-		spin_unlock_bh(&atchan->lock);
+		spin_unlock(&atchan->lock);
 
 		if (!at_xdmac_chan_is_cyclic(atchan)) {
 			dma_cookie_complete(txd);