| Message ID | 1538241480-13844-5-git-send-email-radhey.shyam.pandey@xilinx.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dmaengine: xilinx_dma: Minor fix and refactoring | expand |
> -----Original Message----- > From: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > Sent: Saturday, September 29, 2018 10:48 PM > To: vkoul@kernel.org; dan.j.williams@intel.com; Michal Simek > <michals@xilinx.com>; Appana Durga Kedareswara Rao > <appanad@xilinx.com>; Radhey Shyam Pandey <radheys@xilinx.com> > Cc: dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org > Subject: [PATCH v2 4/4] dmaengine: xilinx_dma: Fix 64-bit simple CDMA > transfer > > In AXI CDMA simple mode also pass MSB bits of source and destination > address to xilinx_write function. This fixes simple CDMA operation mode using > 64-bit addressing. > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Reviewed-by: Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> Regards, Kedar. > --- > Changes for v2: > Use helper macro for preparing dma_addr_t. > --- > drivers/dma/xilinx/xilinx_dma.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c > index c27ab64..d04ef85 100644 > --- a/drivers/dma/xilinx/xilinx_dma.c > +++ b/drivers/dma/xilinx/xilinx_dma.c > @@ -1247,8 +1247,10 @@ static void xilinx_cdma_start_transfer(struct > xilinx_dma_chan *chan) > > hw = &segment->hw; > > - xilinx_write(chan, XILINX_CDMA_REG_SRCADDR, hw- > >src_addr); > - xilinx_write(chan, XILINX_CDMA_REG_DSTADDR, hw- > >dest_addr); > + xilinx_write(chan, XILINX_CDMA_REG_SRCADDR, > + xilinx_prep_dma_addr_t(hw->src_addr)); > + xilinx_write(chan, XILINX_CDMA_REG_DSTADDR, > + xilinx_prep_dma_addr_t(hw->dest_addr)); > > /* Start the transfer */ > dma_ctrl_write(chan, XILINX_DMA_REG_BTT, > -- > 1.7.1
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index c27ab64..d04ef85 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -1247,8 +1247,10 @@ static void xilinx_cdma_start_transfer(struct xilinx_dma_chan *chan) hw = &segment->hw; - xilinx_write(chan, XILINX_CDMA_REG_SRCADDR, hw->src_addr); - xilinx_write(chan, XILINX_CDMA_REG_DSTADDR, hw->dest_addr); + xilinx_write(chan, XILINX_CDMA_REG_SRCADDR, + xilinx_prep_dma_addr_t(hw->src_addr)); + xilinx_write(chan, XILINX_CDMA_REG_DSTADDR, + xilinx_prep_dma_addr_t(hw->dest_addr)); /* Start the transfer */ dma_ctrl_write(chan, XILINX_DMA_REG_BTT,