| Message ID | 1571814137-46002-3-git-send-email-zhouyanjie@zoho.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RESEND,1/2] dt-bindings: dmaengine: Add X1000 bindings. | expand |
Hi Zhou, Le mer., oct. 23, 2019 at 15:02, Zhou Yanjie <zhouyanjie@zoho.com> a écrit : > Add support for probing the dma-jz4780 driver on the X1000 Soc. > > Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com> > --- > drivers/dma/dma-jz4780.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c > index cafb1cc0..f809a6e 100644 > --- a/drivers/dma/dma-jz4780.c > +++ b/drivers/dma/dma-jz4780.c > @@ -1019,11 +1019,18 @@ static const struct jz4780_dma_soc_data > jz4780_dma_soc_data = { > .flags = JZ_SOC_DATA_ALLOW_LEGACY_DT | JZ_SOC_DATA_PROGRAMMABLE_DMA, > }; > > +static const struct jz4780_dma_soc_data x1000_dma_soc_data = { > + .nb_channels = 8, > + .transfer_ord_max = 7, > + .flags = JZ_SOC_DATA_ALLOW_LEGACY_DT | JZ_SOC_DATA_PROGRAMMABLE_DMA, Please don't use JZ_SOC_DATA_ALLOW_LEGACY_DT for new bindings. With that flag removed: Reviewed-by: Paul Cercueil <paul@crapouillou.net> > +}; > + > static const struct of_device_id jz4780_dma_dt_match[] = { > { .compatible = "ingenic,jz4740-dma", .data = &jz4740_dma_soc_data > }, > { .compatible = "ingenic,jz4725b-dma", .data = > &jz4725b_dma_soc_data }, > { .compatible = "ingenic,jz4770-dma", .data = &jz4770_dma_soc_data > }, > { .compatible = "ingenic,jz4780-dma", .data = &jz4780_dma_soc_data > }, > + { .compatible = "ingenic,x1000-dma", .data = &x1000_dma_soc_data }, > {}, > }; > MODULE_DEVICE_TABLE(of, jz4780_dma_dt_match); > -- > 2.7.4 > >
Hi Paul, On 2019年10月24日 00:08, Paul Cercueil wrote: > Hi Zhou, > > > Le mer., oct. 23, 2019 at 15:02, Zhou Yanjie <zhouyanjie@zoho.com> a > écrit : >> Add support for probing the dma-jz4780 driver on the X1000 Soc. >> >> Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com> >> --- >> drivers/dma/dma-jz4780.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c >> index cafb1cc0..f809a6e 100644 >> --- a/drivers/dma/dma-jz4780.c >> +++ b/drivers/dma/dma-jz4780.c >> @@ -1019,11 +1019,18 @@ static const struct jz4780_dma_soc_data >> jz4780_dma_soc_data = { >> .flags = JZ_SOC_DATA_ALLOW_LEGACY_DT | >> JZ_SOC_DATA_PROGRAMMABLE_DMA, >> }; >> >> +static const struct jz4780_dma_soc_data x1000_dma_soc_data = { >> + .nb_channels = 8, >> + .transfer_ord_max = 7, >> + .flags = JZ_SOC_DATA_ALLOW_LEGACY_DT | >> JZ_SOC_DATA_PROGRAMMABLE_DMA, > > Please don't use JZ_SOC_DATA_ALLOW_LEGACY_DT for new bindings. > > With that flag removed: > Reviewed-by: Paul Cercueil <paul@crapouillou.net> > I'll remove it in v2. Best regards! > >> +}; >> + >> static const struct of_device_id jz4780_dma_dt_match[] = { >> { .compatible = "ingenic,jz4740-dma", .data = >> &jz4740_dma_soc_data }, >> { .compatible = "ingenic,jz4725b-dma", .data = >> &jz4725b_dma_soc_data }, >> { .compatible = "ingenic,jz4770-dma", .data = >> &jz4770_dma_soc_data }, >> { .compatible = "ingenic,jz4780-dma", .data = >> &jz4780_dma_soc_data }, >> + { .compatible = "ingenic,x1000-dma", .data = &x1000_dma_soc_data }, >> {}, >> }; >> MODULE_DEVICE_TABLE(of, jz4780_dma_dt_match); >> -- >> 2.7.4 >> >> > >
diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c index cafb1cc0..f809a6e 100644 --- a/drivers/dma/dma-jz4780.c +++ b/drivers/dma/dma-jz4780.c @@ -1019,11 +1019,18 @@ static const struct jz4780_dma_soc_data jz4780_dma_soc_data = { .flags = JZ_SOC_DATA_ALLOW_LEGACY_DT | JZ_SOC_DATA_PROGRAMMABLE_DMA, }; +static const struct jz4780_dma_soc_data x1000_dma_soc_data = { + .nb_channels = 8, + .transfer_ord_max = 7, + .flags = JZ_SOC_DATA_ALLOW_LEGACY_DT | JZ_SOC_DATA_PROGRAMMABLE_DMA, +}; + static const struct of_device_id jz4780_dma_dt_match[] = { { .compatible = "ingenic,jz4740-dma", .data = &jz4740_dma_soc_data }, { .compatible = "ingenic,jz4725b-dma", .data = &jz4725b_dma_soc_data }, { .compatible = "ingenic,jz4770-dma", .data = &jz4770_dma_soc_data }, { .compatible = "ingenic,jz4780-dma", .data = &jz4780_dma_soc_data }, + { .compatible = "ingenic,x1000-dma", .data = &x1000_dma_soc_data }, {}, }; MODULE_DEVICE_TABLE(of, jz4780_dma_dt_match);
Add support for probing the dma-jz4780 driver on the X1000 Soc. Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com> --- drivers/dma/dma-jz4780.c | 7 +++++++ 1 file changed, 7 insertions(+)